-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(instrumentation-http): replace SpanAttributes
and MetricAttributes
with Attributes
#5023
refactor(instrumentation-http): replace SpanAttributes
and MetricAttributes
with Attributes
#5023
Conversation
…ibutes with Attributes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5023 +/- ##
==========================================
+ Coverage 93.39% 93.94% +0.54%
==========================================
Files 46 310 +264
Lines 712 8138 +7426
Branches 120 1633 +1513
==========================================
+ Hits 665 7645 +6980
- Misses 47 493 +446 |
@@ -331,7 +331,7 @@ export class HttpInstrumentation extends InstrumentationBase<HttpInstrumentation | |||
request: http.ClientRequest, | |||
span: Span, | |||
startTime: HrTime, | |||
metricAttributes: MetricAttributes | |||
metricAttributes: Attributes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we also need to change param names. But I think that would make it a breaking change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, I think that's fine here. The name here is actually helping us understand that the attributes here are intended for the metric data point. 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks 🙂
Which problem is this PR solving?
Replaces
SpanAttributes
andMetricsAttributes
withAttributes
. Mote this is not marked as a breaking change since@opentelemetry/api
dependency is already atv1.3.0
and types do not break.Refs #4175
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
compile and ran the test suite for instrumentation
Checklist: