Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sdk-metrics)!: replace MetricsAttributes with Attributes #5020

Conversation

david-luna
Copy link
Contributor

Which problem is this PR solving?

Replaces MetricsAttributes with Attributes

Refs #4175

Short description of the changes

Replace the interfaces in sources & tests. This PR targeting next since the changes in exported APIs make it a breaking change.

How Has This Been Tested?

at the root folder

  • npm run compile
  • npm run test

@david-luna david-luna requested a review from a team as a code owner September 26, 2024 14:20
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.96%. Comparing base (32564ad) to head (b997967).
Report is 3 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #5020   +/-   ##
=======================================
  Coverage   93.96%   93.96%           
=======================================
  Files         310      310           
  Lines        8147     8147           
  Branches     1630     1630           
=======================================
  Hits         7655     7655           
  Misses        492      492           
Files with missing lines Coverage Δ
packages/sdk-metrics/src/Instruments.ts 96.00% <100.00%> (ø)
packages/sdk-metrics/src/ObservableResult.ts 100.00% <100.00%> (ø)
packages/sdk-metrics/src/aggregator/types.ts 100.00% <ø> (ø)
...xemplar/AlignedHistogramBucketExemplarReservoir.ts 92.30% <ø> (ø)
...metrics/src/exemplar/AlwaysSampleExemplarFilter.ts 100.00% <ø> (ø)
...ages/sdk-metrics/src/exemplar/ExemplarReservoir.ts 95.65% <100.00%> (ø)
...-metrics/src/exemplar/NeverSampleExemplarFilter.ts 100.00% <ø> (ø)
...s/src/exemplar/SimpleFixedSizeExemplarReservoir.ts 77.77% <ø> (ø)
...dk-metrics/src/exemplar/WithTraceExemplarFilter.ts 100.00% <ø> (ø)
packages/sdk-metrics/src/export/MetricData.ts 100.00% <ø> (ø)
... and 5 more

@david-luna
Copy link
Contributor Author

actually this can target main as commented in #4175 (comment)

new PR: #5021

@david-luna david-luna closed this Sep 26, 2024
@david-luna david-luna deleted the dluna/4175-replace-attrib-interfaces-sdk-metrics branch September 26, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant