fix(otelhttp): make Body handling in Transport consistent with stdlib#8618
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8618 +/- ##
=======================================
- Coverage 82.2% 82.1% -0.1%
=======================================
Files 180 180
Lines 13750 13759 +9
=======================================
+ Hits 11304 11309 +5
- Misses 2044 2048 +4
Partials 402 402
🚀 New features to boost your workflow:
|
pellared
reviewed
Mar 3, 2026
Member
pellared
left a comment
pellared
left a comment
There was a problem hiding this comment.
Can you please add a changelog entry?
Member
Author
|
@pellared Done! |
First request uses Body, following requests use Body if it can be rewound, which is only possible for well-known types that stdlib knows about. Otherwise, GetBody is used, when available.
pellared
reviewed
Mar 4, 2026
pellared
approved these changes
Mar 4, 2026
pellared
changed the title
Body and GetBody() behavior consistent with stdlib
Co-authored-by: Robert Pająk <pellared@hotmail.com>
dmathieu
approved these changes
Mar 4, 2026
pellared
added a commit
that referenced
this pull request
Mar 6, 2026
#8649) ### Added - Add environment variables propagation carrier in `go.opentelemetry.io/contrib/propagators/envcar`. (#8442) ### Changed - Upgrade `go.opentelemetry.io/otel/semconv` to `v1.40.0`, including updates across instrumentation and detector modules. (#8631) - The semantic conventions v1.40.0 release introduces RPC breaking changes applied in this repository: - RPC spans and metrics no longer include `network.protocol.name`, `network.protocol.version`, or `network.transport` attributes. - `rpc.client.request.size`, `rpc.client.response.size`, `rpc.server.request.size`, and `rpc.server.response.size` are no longer emitted in `go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc`. - `rpc.message` span events and their message attributes are no longer emitted in `go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc` (including when `WithMessageEvents` is configured). See [semantic-conventions v1.40.0 release](https://github.com/open-telemetry/semantic-conventions/releases/tag/v1.40.0) for complete details. ### Fixed - Ignore informational response status codes (`100-199`) except `101 Switching Protocols` when storing the HTTP status code in `go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp` and `go.opentelemetry.io/contrib/instrumentation/github.com/gorilla/mux/otelmux`. (#6913) - Make `Body` handling in `Transport` consistent with stdlib in `go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp`. (#8618) - Fix bucket boundaries for `rpc.server.call.duration` and `rpc.client.call.duration` in `go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc`. (#8642) - Host resource detector in `go.opentelemetry.io/contrib/otelconf` now includes `os.` attributes. (#8578) ### Removed - Drop support for [Go 1.24]. (#8628) [Go 1.24]: https://go.dev/doc/go1.24
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First request uses
Body, following requests useBodyif it can be rewound, which is only possible for well-known types that stdlib knows about. Otherwise,GetBody()is used, when available.This is a follow up for #8532.
Fixes #8524.