otelhttp: Ignore informational response status codes when persisting status#6913
Merged
Merged
Conversation
VirrageS
force-pushed
the
update-writeheader
branch
from
607baeb to
2e15df2
Compare
dmathieu
reviewed
Mar 11, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6913 +/- ##
=====================================
Coverage 82.1% 82.1%
=====================================
Files 180 180
Lines 13759 13765 +6
=====================================
+ Hits 11307 11313 +6
Misses 2049 2049
Partials 403 403
🚀 New features to boost your workflow:
|
VirrageS
force-pushed
the
update-writeheader
branch
from
2e15df2 to
7d2573f
Compare
Contributor
Author
|
@dmathieu Should I add it to Changelog? |
Member
|
Yes, please |
VirrageS
force-pushed
the
update-writeheader
branch
from
7d2573f to
9b84d37
Compare
VirrageS
changed the title
VirrageS
force-pushed
the
update-writeheader
branch
from
9b84d37 to
84dde92
Compare
dmathieu
reviewed
Mar 12, 2025
VirrageS
force-pushed
the
update-writeheader
branch
from
84dde92 to
034029c
Compare
VirrageS
force-pushed
the
update-writeheader
branch
from
034029c to
5e505fb
Compare
dmathieu
approved these changes
Mar 12, 2025
…status Signed-off-by: Janusz Marcinkiewicz <januszm@nvidia.com>
VirrageS
force-pushed
the
update-writeheader
branch
from
5e505fb to
98e82cc
Compare
Member
|
@dmathieu, is this PR still valid? Should other @open-telemetry/go-approvers review it? |
Member
|
Yes, this is also still valid. |
pellared
approved these changes
Mar 4, 2026
pellared
reviewed
Mar 4, 2026
Member
|
@VirrageS, thank you for your contribution! |
pellared
added a commit
that referenced
this pull request
Mar 6, 2026
#8649) ### Added - Add environment variables propagation carrier in `go.opentelemetry.io/contrib/propagators/envcar`. (#8442) ### Changed - Upgrade `go.opentelemetry.io/otel/semconv` to `v1.40.0`, including updates across instrumentation and detector modules. (#8631) - The semantic conventions v1.40.0 release introduces RPC breaking changes applied in this repository: - RPC spans and metrics no longer include `network.protocol.name`, `network.protocol.version`, or `network.transport` attributes. - `rpc.client.request.size`, `rpc.client.response.size`, `rpc.server.request.size`, and `rpc.server.response.size` are no longer emitted in `go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc`. - `rpc.message` span events and their message attributes are no longer emitted in `go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc` (including when `WithMessageEvents` is configured). See [semantic-conventions v1.40.0 release](https://github.com/open-telemetry/semantic-conventions/releases/tag/v1.40.0) for complete details. ### Fixed - Ignore informational response status codes (`100-199`) except `101 Switching Protocols` when storing the HTTP status code in `go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp` and `go.opentelemetry.io/contrib/instrumentation/github.com/gorilla/mux/otelmux`. (#6913) - Make `Body` handling in `Transport` consistent with stdlib in `go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp`. (#8618) - Fix bucket boundaries for `rpc.server.call.duration` and `rpc.client.call.duration` in `go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc`. (#8642) - Host resource detector in `go.opentelemetry.io/contrib/otelconf` now includes `os.` attributes. (#8578) ### Removed - Drop support for [Go 1.24]. (#8628) [Go 1.24]: https://go.dev/doc/go1.24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6912