Use correct bucket boundaries for otelgrpc client and server histograms#8642
Merged
Conversation
pellared
approved these changes
Mar 5, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8642 +/- ##
=====================================
Coverage 82.1% 82.2%
=====================================
Files 182 182
Lines 13754 13766 +12
=====================================
+ Hits 11304 11316 +12
Misses 2048 2048
Partials 402 402
🚀 New features to boost your workflow:
|
dmathieu
approved these changes
Mar 6, 2026
Member
|
Merging this without the wait for 24h so we can get this into the upcoming release. |
pellared
added a commit
that referenced
this pull request
Mar 6, 2026
#8649) ### Added - Add environment variables propagation carrier in `go.opentelemetry.io/contrib/propagators/envcar`. (#8442) ### Changed - Upgrade `go.opentelemetry.io/otel/semconv` to `v1.40.0`, including updates across instrumentation and detector modules. (#8631) - The semantic conventions v1.40.0 release introduces RPC breaking changes applied in this repository: - RPC spans and metrics no longer include `network.protocol.name`, `network.protocol.version`, or `network.transport` attributes. - `rpc.client.request.size`, `rpc.client.response.size`, `rpc.server.request.size`, and `rpc.server.response.size` are no longer emitted in `go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc`. - `rpc.message` span events and their message attributes are no longer emitted in `go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc` (including when `WithMessageEvents` is configured). See [semantic-conventions v1.40.0 release](https://github.com/open-telemetry/semantic-conventions/releases/tag/v1.40.0) for complete details. ### Fixed - Ignore informational response status codes (`100-199`) except `101 Switching Protocols` when storing the HTTP status code in `go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp` and `go.opentelemetry.io/contrib/instrumentation/github.com/gorilla/mux/otelmux`. (#6913) - Make `Body` handling in `Transport` consistent with stdlib in `go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp`. (#8618) - Fix bucket boundaries for `rpc.server.call.duration` and `rpc.client.call.duration` in `go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc`. (#8642) - Host resource detector in `go.opentelemetry.io/contrib/otelconf` now includes `os.` attributes. (#8578) ### Removed - Drop support for [Go 1.24]. (#8628) [Go 1.24]: https://go.dev/doc/go1.24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8638
It follows:
The issue was introduced in #8481, where the unit changed from
mstosand we didn't catch it.This impacts the v1.40.0 and v1.41.0 releases.
It is hard to unit test histogram bucket boundaries because metricdatatest.IgnoreValue() also ignores the bucket boundaries. It seems like we could make IgnoreValue not ignore histogram buckets (since those are constant), but that would probably break a lot of existing tests. We don't test bucket boundaries for otelhttp either.