receiver/prometheus: add metricGroup.toSummaryPoint pdata conversion#3668
Merged
bogdandrutu merged 1 commit intoJul 21, 2021
Conversation
Member
Author
|
Another one, kindly cc-ing @bogdandrutu @Aneurysm9 @rakyll @alolita @tigrannajaryan @anuraaga |
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Jul 19, 2021
Implements metricGroupPdata toNumberDataPoint and added unit tests as well as equivalence tests to ensure the migration will render the same results. Updates #3137 Depends on PR open-telemetry#3668 Updates PR open-telemetry#3427
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Jul 19, 2021
Implements metricGroupPdata toNumberDataPoint and added unit tests as well as equivalence tests to ensure the migration will render the same results. Updates #3137 Depends on PR open-telemetry#3668 Updates PR open-telemetry#3427
Member
|
@Aneurysm9 @dashpole @rakyll please review - ty! |
bogdandrutu
reviewed
Jul 19, 2021
dashpole
approved these changes
Jul 20, 2021
Contributor
dashpole
left a comment
dashpole
left a comment
There was a problem hiding this comment.
toSummaryPoint looks good.
punya
added
the
ready-to-merge
Member
|
@dashpole indeed the Summary looks good but depends on a PR with some comments :) |
Contributor
|
Yes. This is not ready to merge. |
Aneurysm9
approved these changes
Jul 20, 2021
bogdandrutu
removed
the
ready-to-merge
cuonglm
approved these changes
Jul 21, 2021
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Jul 21, 2021
Implements metricGroupPdata toNumberDataPoint and added unit tests as well as equivalence tests to ensure the migration will render the same results. Updates #3137 Depends on PR open-telemetry#3668 Updates PR open-telemetry#3427
odeke-em
force-pushed
the
receiver-prometheus-metricGroupToSummaryPointPdata-migration
branch
from
8444434 to
a601910
Compare
Member
|
Please rebase |
Implements metricGroupPdata toSummaryPoint and added unit tests as well as equivalence tests to ensure the migration will render the same results. Updates #3137 Depends on PR open-telemetry#3667 Updates PR open-telemetry#3427
odeke-em
force-pushed
the
receiver-prometheus-metricGroupToSummaryPointPdata-migration
branch
from
a601910 to
cb9bd45
Compare
Member
Author
Rebase done, thanks @bogdandrutu! |
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Jul 21, 2021
Implements metricGroupPdata toNumberDataPoint and added unit tests as well as equivalence tests to ensure the migration will render the same results. Updates #3137 Depends on PR open-telemetry#3668 Updates PR open-telemetry#3427
odeke-em
deleted the
receiver-prometheus-metricGroupToSummaryPointPdata-migration
branch
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Jul 21, 2021
Implements metricGroupPdata toNumberDataPoint and added unit tests as well as equivalence tests to ensure the migration will render the same results. While here, added TODOs for issue open-telemetry#3691 which found a bug in which cumulative types weren't using the actual duration start timestamp. Given that this current change is a translation of prior logic and has parity checks, making that bug fix would complicate the PR. Updates #3137 Depends on PR open-telemetry#3668 Updates PR open-telemetry#3427 Updates open-telemetry#3691
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Jul 22, 2021
Implements metricGroupPdata toNumberDataPoint and added unit tests as well as equivalence tests to ensure the migration will render the same results. While here, added TODOs for issue open-telemetry#3691 which found a bug in which cumulative types weren't using the actual duration start timestamp. Given that this current change is a translation of prior logic and has parity checks, making that bug fix would complicate the PR. Updates #3137 Depends on PR open-telemetry#3668 Updates PR open-telemetry#3427 Updates open-telemetry#3691
bogdandrutu
pushed a commit
that referenced
this pull request
Jul 22, 2021
…on (#3674) Implements metricGroupPdata toNumberDataPoint and added unit tests as well as equivalence tests to ensure the migration will render the same results. While here, added TODOs for issue #3691 which found a bug in which cumulative types weren't using the actual duration start timestamp. Given that this current change is a translation of prior logic and has parity checks, making that bug fix would complicate the PR. Updates #3137 Depends on PR #3668 Updates PR #3427 Updates #3691
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements metricGroupPdata toSummaryPoint and added unit tests
as well as equivalence tests to ensure the migration will render
the same results.
Updates #3137
Depends on PR #3667
Updates PR #3427