receiver/prometheus: add metricGroup.toDistributionPoint pdata conversion#3667
Merged
bogdandrutu merged 1 commit intoJul 21, 2021
Conversation
odeke-em
force-pushed
the
receiver-prometheus-metricGroupToDistributionPointPdata-migration
branch
from
c3f2d8e to
7eeb9a3
Compare
Member
Author
|
Kindly cc-ing @tigrannajaryan @bogdandrutu @anuraaga @Aneurysm9 @rakyll. |
odeke-em
force-pushed
the
receiver-prometheus-metricGroupToDistributionPointPdata-migration
branch
3 times, most recently
from
662be84 to
f3ad1be
Compare
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Jul 18, 2021
Implements metricGroupPdata toSummaryPoint and added unit tests as well as equivalence tests to ensure the migration will render the same results. Updates #3137 Depends on PR open-telemetry#3667 Updates PR open-telemetry#3427
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Jul 18, 2021
Implements metricGroupPdata toSummaryPoint and added unit tests as well as equivalence tests to ensure the migration will render the same results. Updates #3137 Depends on PR open-telemetry#3667 Updates PR open-telemetry#3427
Member
|
@bogdandrutu @Aneurysm9 @jrcamp @rakyll - please review so that this PR can be merged. It is required part of achieving tracing stability. |
bogdandrutu
reviewed
Jul 19, 2021
| mg.sortPoints() | ||
|
|
||
| // for OCAgent Proto, the bounds won't include +inf | ||
| // TODO: (@odeke-em) should we also check OpenTelemetry Pdata for bucket bounds? |
Member
There was a problem hiding this comment.
The +Inf is implicit in Otel, so no need to add it.
Member
Author
There was a problem hiding this comment.
Hey @bogdandrutu that code is from the straight up translation from the prior code. To avoid too many moving parts and to keep parity with the existing code, I am going to file an issue to remind me to investigate and finish that TODO that was added ages ago.
Member
Author
There was a problem hiding this comment.
I filed https://github.com/open-telemetry/opentelemetry-collector/issues/3684 and I don't think this change is a blocker for this PR as this PR is a translation to directly use pdata. Thanks for the review and for the answer @bogdandrutu!
dashpole
approved these changes
Jul 20, 2021
Contributor
dashpole
left a comment
dashpole
left a comment
There was a problem hiding this comment.
Lgtm, other than the outstanding comment
Aneurysm9
approved these changes
Jul 20, 2021
cuonglm
approved these changes
Jul 21, 2021
odeke-em
force-pushed
the
receiver-prometheus-metricGroupToDistributionPointPdata-migration
branch
from
f3ad1be to
f67d45d
Compare
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Jul 21, 2021
Implements metricGroupPdata toSummaryPoint and added unit tests as well as equivalence tests to ensure the migration will render the same results. Updates #3137 Depends on PR open-telemetry#3667 Updates PR open-telemetry#3427
…sion Implements metricGroupPdata toDistributionPoint and added unit tests as well as equivalence tests to ensure the migration will render the same results. Updates #3137 Updates PR open-telemetry#3427
odeke-em
force-pushed
the
receiver-prometheus-metricGroupToDistributionPointPdata-migration
branch
from
f67d45d to
b34aa37
Compare
bogdandrutu
approved these changes
Jul 21, 2021
odeke-em
deleted the
receiver-prometheus-metricGroupToDistributionPointPdata-migration
branch
Member
Author
|
Thanks everyone for the reviews and merge! |
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Jul 21, 2021
Implements metricGroupPdata toSummaryPoint and added unit tests as well as equivalence tests to ensure the migration will render the same results. Updates #3137 Depends on PR open-telemetry#3667 Updates PR open-telemetry#3427
bogdandrutu
pushed a commit
that referenced
this pull request
Jul 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements metricGroupPdata toDistributionPoint and added unit tests
as well as equivalence tests to ensure the migration will render
the same results.
Updates #3137
Updates PR #3427