receiver/prometheus: add metricGroup.toNumberDataPoint pdata conversion#3674
Merged
bogdandrutu merged 1 commit intoJul 22, 2021
Conversation
Member
|
@dashpole @Aneurysm9 @rakyll please review. |
dashpole
approved these changes
Jul 20, 2021
Contributor
dashpole
left a comment
dashpole
left a comment
There was a problem hiding this comment.
toNumberDataPoint implementation and testing looks good.
Member
|
@odeke-em could you please appease the linter: |
odeke-em
force-pushed
the
receiver-prometheus-metricGroupToNumberDataPointPdata-migration
branch
from
1d422c6 to
0d94cb4
Compare
Member
|
@Aneurysm9 @rakyll do you plan to review? If not I can merge based on @dashpole's approval. |
odeke-em
force-pushed
the
receiver-prometheus-metricGroupToNumberDataPointPdata-migration
branch
from
0d94cb4 to
2606ea6
Compare
Member
Author
|
Thanks for the reviews @punya @dashpole @tigrannajaryan! @bogdandrutu this one too is ready :-) |
punya
added
the
ready-to-merge
bogdandrutu
requested changes
Jul 21, 2021
bogdandrutu
removed
the
ready-to-merge
odeke-em
force-pushed
the
receiver-prometheus-metricGroupToNumberDataPointPdata-migration
branch
from
2606ea6 to
ef882b9
Compare
Implements metricGroupPdata toNumberDataPoint and added unit tests as well as equivalence tests to ensure the migration will render the same results. While here, added TODOs for issue open-telemetry#3691 which found a bug in which cumulative types weren't using the actual duration start timestamp. Given that this current change is a translation of prior logic and has parity checks, making that bug fix would complicate the PR. Updates #3137 Depends on PR open-telemetry#3668 Updates PR open-telemetry#3427 Updates open-telemetry#3691
odeke-em
force-pushed
the
receiver-prometheus-metricGroupToNumberDataPointPdata-migration
branch
from
ef882b9 to
2ab79f2
Compare
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Jul 22, 2021
This change wires together the logic to convert the pdata converters into a method ToMetricPdata that appends converted metrics. The next change or two, will then hook everything up directly and will allow us to delete all the prior code!! Updates #3137 Updates PR open-telemetry#3674 Requires PR open-telemetry#3694 Updates open-telemetry#3691
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Jul 22, 2021
This change wires together the logic to convert the pdata converters into a method ToMetricPdata that appends converted metrics. The next change or two, will then hook everything up directly and will allow us to delete all the prior code!! Updates #3137 Updates PR open-telemetry#3674 Requires PR open-telemetry#3694 Updates open-telemetry#3691
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Jul 22, 2021
This change wires together the logic to convert the pdata converters into a method ToMetricPdata that appends converted metrics. The next change or two, will then hook everything up directly and will allow us to delete all the prior code!! Updates #3137 Updates PR open-telemetry#3674 Requires PR open-telemetry#3694 Updates open-telemetry#3691
bogdandrutu
approved these changes
Jul 22, 2021
odeke-em
deleted the
receiver-prometheus-metricGroupToNumberDataPointPdata-migration
branch
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Jul 23, 2021
This change wires together the logic to convert the pdata converters into a method ToMetricPdata that appends converted metrics. The next change or two, will then hook everything up directly and will allow us to delete all the prior code!! Updates #3137 Updates PR open-telemetry#3674 Requires PR open-telemetry#3694 Updates open-telemetry#3691
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Jul 29, 2021
This change wires together the logic to convert the pdata converters into a method ToMetricPdata that appends converted metrics. The next change or two, will then hook everything up directly and will allow us to delete all the prior code!! Updates #3137 Updates PR open-telemetry#3674 Requires PR open-telemetry#3694 Updates open-telemetry#3691
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Jul 29, 2021
This change wires together the logic to convert the pdata converters into a method ToMetricPdata that appends converted metrics. The next change or two, will then hook everything up directly and will allow us to delete all the prior code!! Updates #3137 Updates PR open-telemetry#3674 Requires PR open-telemetry#3694 Updates open-telemetry#3691
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Jul 29, 2021
This change wires together the logic to convert the pdata converters into a method ToMetricPdata that appends converted metrics. The next change or two, will then hook everything up directly and will allow us to delete all the prior code!! Updates #3137 Updates PR open-telemetry#3674 Requires PR open-telemetry#3694 Updates open-telemetry#3691
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Jul 30, 2021
This change wires together the logic to convert the pdata converters into a method ToMetricPdata that appends converted metrics. The next change or two, will then hook everything up directly and will allow us to delete all the prior code!! Updates #3137 Updates PR open-telemetry#3674 Requires PR open-telemetry#3694 Updates open-telemetry#3691
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Jul 30, 2021
This change wires together the logic to convert the pdata converters into a method ToMetricPdata that appends converted metrics. The next change or two, will then hook everything up directly and will allow us to delete all the prior code!! Updates #3137 Updates PR open-telemetry#3674 Requires PR open-telemetry#3694 Updates open-telemetry#3691
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Jul 30, 2021
This change wires together the logic to convert the pdata converters into a method ToMetricPdata that appends converted metrics. The next change or two, will then hook everything up directly and will allow us to delete all the prior code!! Updates #3137 Updates PR open-telemetry#3674 Requires PR open-telemetry#3694 Updates open-telemetry#3691
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Jul 30, 2021
This change wires together the logic to convert the pdata converters into a method ToMetricPdata that appends converted metrics. The next change or two, will then hook everything up directly and will allow us to delete all the prior code!! Updates #3137 Updates PR open-telemetry#3674 Requires PR open-telemetry#3694 Updates open-telemetry#3691
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Jul 30, 2021
This change wires together the logic to convert the pdata converters into a method ToMetricPdata that appends converted metrics. The next change or two, will then hook everything up directly and will allow us to delete all the prior code!! Updates #3137 Updates PR open-telemetry#3674 Requires PR open-telemetry#3694 Updates open-telemetry#3691
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Jul 31, 2021
This change wires together the logic to convert the pdata converters into a method ToMetricPdata that appends converted metrics. The next change or two, will then hook everything up directly and will allow us to delete all the prior code!! Updates #3137 Updates PR open-telemetry#3674 Requires PR open-telemetry#3694 Updates open-telemetry#3691
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Jul 31, 2021
This change wires together the logic to convert the pdata converters into a method ToMetricPdata that appends converted metrics. The next change or two, will then hook everything up directly and will allow us to delete all the prior code!! Updates #3137 Updates PR open-telemetry#3674 Requires PR open-telemetry#3694 Updates open-telemetry#3691
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Aug 2, 2021
This change wires together the logic to convert the pdata converters into a method ToMetricPdata that appends converted metrics. The next change or two, will then hook everything up directly and will allow us to delete all the prior code!! Updates #3137 Updates PR open-telemetry#3674 Requires PR open-telemetry#3694 Updates open-telemetry#3691
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Aug 2, 2021
This change wires together the logic to convert the pdata converters into a method ToMetricPdata that appends converted metrics. The next change or two, will then hook everything up directly and will allow us to delete all the prior code!! Updates #3137 Updates PR open-telemetry#3674 Requires PR open-telemetry#3694 Updates open-telemetry#3691
bogdandrutu
pushed a commit
that referenced
this pull request
Aug 3, 2021
This change wires together the logic to convert the pdata converters into a method ToMetricPdata that appends converted metrics. The next change or two, will then hook everything up directly and will allow us to delete all the prior code!! Updates #3137 Updates PR #3674 Requires PR #3694 Updates #3691
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Aug 4, 2021
This change wires together the logic to convert the pdata converters into a method ToMetricPdata that appends converted metrics. The next change or two, will then hook everything up directly and will allow us to delete all the prior code!! Updates #3137 Updates PR open-telemetry#3674 Requires PR open-telemetry#3694 Updates open-telemetry#3691
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Aug 4, 2021
This change wires together the logic to convert the pdata converters into a method ToMetricPdata that appends converted metrics. The next change or two, will then hook everything up directly and will allow us to delete all the prior code!! Updates #3137 Updates PR open-telemetry#3674 Requires PR open-telemetry#3694 Updates open-telemetry#3691
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Aug 12, 2021
This change wires together the logic to convert the pdata converters into a method ToMetricPdata that appends converted metrics. The next change or two, will then hook everything up directly and will allow us to delete all the prior code!! Updates #3137 Updates PR open-telemetry#3674 Requires PR open-telemetry#3694 Updates open-telemetry#3691
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Aug 17, 2021
This change wires together the logic to convert the pdata converters into a method ToMetricPdata that appends converted metrics. The next change or two, will then hook everything up directly and will allow us to delete all the prior code!! Updates #3137 Updates PR open-telemetry#3674 Requires PR open-telemetry#3694 Updates open-telemetry#3691
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements metricGroupPdata toNumberDataPoint and added unit tests
as well as equivalence tests to ensure the migration will render
the same results.
Updates #3137
Depends on PR #3668
Updates PR #3427