receiver/prometheus: add .ToMetric() directly to pdata.Metric#3427
Closed
odeke-em wants to merge 3 commits into
Closed
receiver/prometheus: add .ToMetric() directly to pdata.Metric#3427odeke-em wants to merge 3 commits into
odeke-em wants to merge 3 commits into
Conversation
odeke-em
force-pushed
the
receiver-prometheus-addToMetricPdata-directly
branch
from
dfce922 to
6312baf
Compare
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
odeke-em
force-pushed
the
receiver-prometheus-addToMetricPdata-directly
branch
from
6312baf to
cf3e5f1
Compare
Adds point-to-point converters for the various types so that
we can eventually replace with a direct Prometheus to OTLP
conversion. This change solely focuses on
(*metricFamilyPdata).ToMetric()
Updates #3137
odeke-em
force-pushed
the
receiver-prometheus-addToMetricPdata-directly
branch
from
cf3e5f1 to
1ff57db
Compare
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Jul 17, 2021
…sion Implements metricGroupPdata toDistributionPoint and added unit tests as well as equivalence tests to ensure the migration will render the same results. Updates #3137 Updates PR open-telemetry#3427
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Jul 17, 2021
…sion Implements metricGroupPdata toDistributionPoint and added unit tests as well as equivalence tests to ensure the migration will render the same results. Updates #3137 Updates PR open-telemetry#3427
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Jul 17, 2021
…sion Implements metricGroupPdata toDistributionPoint and added unit tests as well as equivalence tests to ensure the migration will render the same results. Updates #3137 Updates PR open-telemetry#3427
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Jul 17, 2021
…sion Implements metricGroupPdata toDistributionPoint and added unit tests as well as equivalence tests to ensure the migration will render the same results. Updates #3137 Updates PR open-telemetry#3427
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Jul 17, 2021
…sion Implements metricGroupPdata toDistributionPoint and added unit tests as well as equivalence tests to ensure the migration will render the same results. Updates #3137 Updates PR open-telemetry#3427
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Jul 18, 2021
Implements metricGroupPdata toSummaryPoint and added unit tests as well as equivalence tests to ensure the migration will render the same results. Updates #3137 Depends on PR open-telemetry#3667 Updates PR open-telemetry#3427
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Jul 18, 2021
Implements metricGroupPdata toSummaryPoint and added unit tests as well as equivalence tests to ensure the migration will render the same results. Updates #3137 Depends on PR open-telemetry#3667 Updates PR open-telemetry#3427
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Jul 19, 2021
Implements metricGroupPdata toNumberDataPoint and added unit tests as well as equivalence tests to ensure the migration will render the same results. Updates #3137 Depends on PR open-telemetry#3668 Updates PR open-telemetry#3427
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Jul 19, 2021
Implements metricGroupPdata toNumberDataPoint and added unit tests as well as equivalence tests to ensure the migration will render the same results. Updates #3137 Depends on PR open-telemetry#3668 Updates PR open-telemetry#3427
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Jul 21, 2021
Implements metricGroupPdata toNumberDataPoint and added unit tests as well as equivalence tests to ensure the migration will render the same results. Updates #3137 Depends on PR open-telemetry#3668 Updates PR open-telemetry#3427
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Jul 21, 2021
…sion Implements metricGroupPdata toDistributionPoint and added unit tests as well as equivalence tests to ensure the migration will render the same results. Updates #3137 Updates PR open-telemetry#3427
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Jul 21, 2021
Implements metricGroupPdata toSummaryPoint and added unit tests as well as equivalence tests to ensure the migration will render the same results. Updates #3137 Depends on PR open-telemetry#3667 Updates PR open-telemetry#3427
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Jul 21, 2021
…sion Implements metricGroupPdata toDistributionPoint and added unit tests as well as equivalence tests to ensure the migration will render the same results. Updates #3137 Updates PR open-telemetry#3427
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Jul 21, 2021
Implements metricGroupPdata toSummaryPoint and added unit tests as well as equivalence tests to ensure the migration will render the same results. Updates #3137 Depends on PR open-telemetry#3667 Updates PR open-telemetry#3427
bogdandrutu
pushed a commit
that referenced
this pull request
Jul 21, 2021
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Jul 21, 2021
Implements metricGroupPdata toNumberDataPoint and added unit tests as well as equivalence tests to ensure the migration will render the same results. Updates #3137 Depends on PR open-telemetry#3668 Updates PR open-telemetry#3427
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Jul 21, 2021
Implements metricGroupPdata toNumberDataPoint and added unit tests as well as equivalence tests to ensure the migration will render the same results. While here, added TODOs for issue open-telemetry#3691 which found a bug in which cumulative types weren't using the actual duration start timestamp. Given that this current change is a translation of prior logic and has parity checks, making that bug fix would complicate the PR. Updates #3137 Depends on PR open-telemetry#3668 Updates PR open-telemetry#3427 Updates open-telemetry#3691
odeke-em
added a commit
to orijtech/opentelemetry-collector
that referenced
this pull request
Jul 22, 2021
Implements metricGroupPdata toNumberDataPoint and added unit tests as well as equivalence tests to ensure the migration will render the same results. While here, added TODOs for issue open-telemetry#3691 which found a bug in which cumulative types weren't using the actual duration start timestamp. Given that this current change is a translation of prior logic and has parity checks, making that bug fix would complicate the PR. Updates #3137 Depends on PR open-telemetry#3668 Updates PR open-telemetry#3427 Updates open-telemetry#3691
bogdandrutu
pushed a commit
that referenced
this pull request
Jul 22, 2021
…on (#3674) Implements metricGroupPdata toNumberDataPoint and added unit tests as well as equivalence tests to ensure the migration will render the same results. While here, added TODOs for issue #3691 which found a bug in which cumulative types weren't using the actual duration start timestamp. Given that this current change is a translation of prior logic and has parity checks, making that bug fix would complicate the PR. Updates #3137 Depends on PR #3668 Updates PR #3427 Updates #3691
Member
|
Closing this since it seems to be halfway merged, please reopen otherwise |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds point-to-point converters for the various types so that
we can eventually replace with a direct Prometheus to OTLP
conversion. This change solely focuses on
Updates #3137