Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

feat(node/net): rewire unsafe block sender from engine to network#2378

Merged
theochap merged 1 commit intomainfrom
theo/send-payloads-to-network-2
Jul 9, 2025
Merged

feat(node/net): rewire unsafe block sender from engine to network#2378
theochap merged 1 commit intomainfrom
theo/send-payloads-to-network-2

Conversation

@theochap
Copy link
Member

@theochap theochap commented Jul 8, 2025

Description

Rewire the sequencer unsafe payload sender from the engine to the network.

Previously, the sequencer was sending the unsafe blocks it received from the network BuildTask back to the network to call InsertUnsafeTask. Since the BuildTask inserts the newly built payloads to the engine state (like what the InsertUnsafeTask would do), this resulted in a no-op.

Instead, the sequencer should send the payloads to the network to gossip them to the p2p mesh.

Misc

Close #2244
Built on top of #2376

@theochap theochap self-assigned this Jul 8, 2025
@theochap theochap added K-feature Kind: feature A-node Area: cl node (eq. Go op-node) handles single-chain consensus A-p2p Area: p2p labels Jul 8, 2025
@theochap theochap moved this to In Review in Project Tracking Jul 8, 2025
@theochap theochap linked an issue Jul 8, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.2%. Comparing base (42839d1) to head (a769675).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Base automatically changed from theo/send-payloads-to-network to main July 8, 2025 23:23
@theochap theochap force-pushed the theo/send-payloads-to-network-2 branch from a2a8605 to a769675 Compare July 9, 2025 13:18
@theochap theochap enabled auto-merge July 9, 2025 13:19
@theochap theochap added this pull request to the merge queue Jul 9, 2025
Merged via the queue into main with commit 7db78be Jul 9, 2025
25 checks passed
@theochap theochap deleted the theo/send-payloads-to-network-2 branch July 9, 2025 13:41
@github-project-automation github-project-automation bot moved this from In Review to Done in Project Tracking Jul 9, 2025
theochap added a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
…-rs/kona#2378)

## Description

Rewire the sequencer unsafe payload sender from the engine to the
network.

Previously, the sequencer was sending the unsafe blocks it received from
the network `BuildTask` back to the network to call `InsertUnsafeTask`.
Since the `BuildTask` inserts the newly built payloads to the engine
state (like what the `InsertUnsafeTask` would do), this resulted in a
no-op.

Instead, the sequencer should send the payloads to the network to gossip
them to the p2p mesh.

## Misc

Close op-rs/kona#2244
Built on top of op-rs/kona#2376
theochap added a commit to ethereum-optimism/optimism that referenced this pull request Jan 14, 2026
…-rs/kona#2378)

## Description

Rewire the sequencer unsafe payload sender from the engine to the
network.

Previously, the sequencer was sending the unsafe blocks it received from
the network `BuildTask` back to the network to call `InsertUnsafeTask`.
Since the `BuildTask` inserts the newly built payloads to the engine
state (like what the `InsertUnsafeTask` would do), this resulted in a
no-op.

Instead, the sequencer should send the payloads to the network to gossip
them to the p2p mesh.

## Misc

Close #2244
Built on top of #2376
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A-node Area: cl node (eq. Go op-node) handles single-chain consensus A-p2p Area: p2p K-feature Kind: feature

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

feat(node/service): Send built payloads to NetworkActor

2 participants