supports go.work#2376
Closed
islishude wants to merge 3 commits intoethereum-optimism:developfrom
islishude:feat-gowork
Closed
supports go.work#2376islishude wants to merge 3 commits intoethereum-optimism:developfrom islishude:feat-gowork
islishude wants to merge 3 commits intoethereum-optimism:developfrom
islishude:feat-gowork
Conversation
islishude
requested review from
Inphi,
cfromknecht,
mslipper,
optimisticben,
smartcontracts and
tynes
as code owners
|
Contributor
|
Thanks for the work! I'd prefer to do this in sections instead of in a single PR. The first section could be updating the versions of go in each go module + dockerfiles. The next section could be introducing the workspaces |
Contributor
Author
|
Okay then |
theochap
added a commit
that referenced
this pull request
Dec 10, 2025
#2376) ## Description This PR refactors the network driver and moves it inside the network actor. This reduces the levels of indirection and allow the network actor to comply more with the new builder refactor of the node services by avoiding to define channels inside the driver. Changes: - Removes the `net` module inside `kona-p2p`. Moves the relevant files to the `kona-node-services` crate. - Removes the `broadcast` module inside the network actor. This can now be directly handled using a mpsc channel inside the network actor to implement the notion of queue. Outer interactions with the network actor happen through the `NetworkActor` context (see for instance op-rs/kona@main...theo/send-payloads-to-network#diff-b4e04fd02334c1ae45e956ad21312e81efacba5a7c1d477b176711dbae458c32R87-R126 or op-rs/kona@main...theo/send-payloads-to-network#diff-00c31e9f9de711af31ebbd3b81f610ea12ea100a6a8d0db6a2ef86f52f298849L80-R75) - Divides the network actor module with the following pattern to propagate the lower level abstractions (resp `Discv5Driver`/`Discv5Handler`/`GossipDriver`): ``` NodeBuilder ->build NodeDriver ->(async) start NodeHandler ``` Close #2365
theochap
added a commit
that referenced
this pull request
Dec 10, 2025
) ## Description Rewire the sequencer unsafe payload sender from the engine to the network. Previously, the sequencer was sending the unsafe blocks it received from the network `BuildTask` back to the network to call `InsertUnsafeTask`. Since the `BuildTask` inserts the newly built payloads to the engine state (like what the `InsertUnsafeTask` would do), this resulted in a no-op. Instead, the sequencer should send the payloads to the network to gossip them to the p2p mesh. ## Misc Close #2244 Built on top of #2376
theochap
added a commit
that referenced
this pull request
Jan 14, 2026
…-rs/kona#2378) ## Description Rewire the sequencer unsafe payload sender from the engine to the network. Previously, the sequencer was sending the unsafe blocks it received from the network `BuildTask` back to the network to call `InsertUnsafeTask`. Since the `BuildTask` inserts the newly built payloads to the engine state (like what the `InsertUnsafeTask` would do), this resulted in a no-op. Instead, the sequencer should send the payloads to the network to gossip them to the p2p mesh. ## Misc Close #2244 Built on top of #2376
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A clear and concise description of the features you're adding in this pull request.
go 1.18 introduced go workpace feature, it supports mulit-modules better.
Additional context
Metadata
https://go.dev/ref/mod#workspaces