chore(node/net): integrate the network driver inside the network actor by theochap · Pull Request #2376 · op-rs/kona

theochap · 2025-07-08T17:45:42Z

Description

This PR refactors the network driver and moves it inside the network actor. This reduces the levels of indirection and allow the network actor to comply more with the new builder refactor of the node services by avoiding to define channels inside the driver.

Changes:

Removes the net module inside kona-p2p. Moves the relevant files to the kona-node-services crate.
Removes the broadcast module inside the network actor. This can now be directly handled using a mpsc channel inside the network actor to implement the notion of queue. Outer interactions with the network actor happen through the NetworkActor context (see for instance main...theo/send-payloads-to-network#diff-b4e04fd02334c1ae45e956ad21312e81efacba5a7c1d477b176711dbae458c32R87-R126 or main...theo/send-payloads-to-network#diff-00c31e9f9de711af31ebbd3b81f610ea12ea100a6a8d0db6a2ef86f52f298849L80-R75)
Divides the network actor module with the following pattern to propagate the lower level abstractions (resp Discv5Driver/Discv5Handler/GossipDriver):

NodeBuilder ->build NodeDriver ->(async) start NodeHandler

Close #2365

codecov · 2025-07-08T17:48:06Z

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.

Project coverage is 82.3%. Comparing base (22b1dd5) to head (3a2c987).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
crates/node/p2p/src/gossip/driver.rs	0.0%	27 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

crates/node/service/src/actors/network/actor.rs

crates/node/service/src/actors/network/mod.rs

crates/node/service/src/actors/network/handler.rs

refcell · 2025-07-08T18:32:29Z

crates/node/service/src/actors/network/driver.rs

+    /// The frequency at which to inspect peer scores to ban poorly performing peers.
+    pub(super) const PEER_SCORE_INSPECT_FREQUENCY: Duration = Duration::from_secs(1);


Should this be configurable too?

Can open an issue for it, I think we can configure it indeed!

Oh actually it is already defined as a static constant here

kona/crates/node/p2p/src/gossip/config.rs

Lines 54 to 56 in 489b377

/// The pper score inspect frequency.

/// The frequency at which peer scores are inspected.

pub static ref PEER_SCORE_INSPECT_FREQUENCY: Duration = 15 * Duration::from_secs(1);

How about we keep it constant for now then?

crates/node/p2p/src/lib.rs

refcell

I'm happy with this. Will make it easier to split up kona-p2p into separate discovery and gossip crates, so I'm a proponent.

I think there's a few small things remaining that could be cleaned up. Otherwise nice work!

refcell

This looks good

) ## Description Rewire the sequencer unsafe payload sender from the engine to the network. Previously, the sequencer was sending the unsafe blocks it received from the network `BuildTask` back to the network to call `InsertUnsafeTask`. Since the `BuildTask` inserts the newly built payloads to the engine state (like what the `InsertUnsafeTask` would do), this resulted in a no-op. Instead, the sequencer should send the payloads to the network to gossip them to the p2p mesh. ## Misc Close #2244 Built on top of #2376

op-rs/kona#2376) ## Description This PR refactors the network driver and moves it inside the network actor. This reduces the levels of indirection and allow the network actor to comply more with the new builder refactor of the node services by avoiding to define channels inside the driver. Changes: - Removes the `net` module inside `kona-p2p`. Moves the relevant files to the `kona-node-services` crate. - Removes the `broadcast` module inside the network actor. This can now be directly handled using a mpsc channel inside the network actor to implement the notion of queue. Outer interactions with the network actor happen through the `NetworkActor` context (see for instance op-rs/kona@main...theo/send-payloads-to-network#diff-b4e04fd02334c1ae45e956ad21312e81efacba5a7c1d477b176711dbae458c32R87-R126 or op-rs/kona@main...theo/send-payloads-to-network#diff-00c31e9f9de711af31ebbd3b81f610ea12ea100a6a8d0db6a2ef86f52f298849L80-R75) - Divides the network actor module with the following pattern to propagate the lower level abstractions (resp `Discv5Driver`/`Discv5Handler`/`GossipDriver`): ``` NodeBuilder ->build NodeDriver ->(async) start NodeHandler ``` Close op-rs/kona#2365

…-rs/kona#2378) ## Description Rewire the sequencer unsafe payload sender from the engine to the network. Previously, the sequencer was sending the unsafe blocks it received from the network `BuildTask` back to the network to call `InsertUnsafeTask`. Since the `BuildTask` inserts the newly built payloads to the engine state (like what the `InsertUnsafeTask` would do), this resulted in a no-op. Instead, the sequencer should send the payloads to the network to gossip them to the p2p mesh. ## Misc Close op-rs/kona#2244 Built on top of op-rs/kona#2376

op-rs/kona#2376) ## Description This PR refactors the network driver and moves it inside the network actor. This reduces the levels of indirection and allow the network actor to comply more with the new builder refactor of the node services by avoiding to define channels inside the driver. Changes: - Removes the `net` module inside `kona-p2p`. Moves the relevant files to the `kona-node-services` crate. - Removes the `broadcast` module inside the network actor. This can now be directly handled using a mpsc channel inside the network actor to implement the notion of queue. Outer interactions with the network actor happen through the `NetworkActor` context (see for instance op-rs/kona@main...theo/send-payloads-to-network#diff-b4e04fd02334c1ae45e956ad21312e81efacba5a7c1d477b176711dbae458c32R87-R126 or op-rs/kona@main...theo/send-payloads-to-network#diff-00c31e9f9de711af31ebbd3b81f610ea12ea100a6a8d0db6a2ef86f52f298849L80-R75) - Divides the network actor module with the following pattern to propagate the lower level abstractions (resp `Discv5Driver`/`Discv5Handler`/`GossipDriver`): ``` NodeBuilder ->build NodeDriver ->(async) start NodeHandler ``` Close #2365

theochap requested review from clabby, dhyaniarun1993, emhane, itschaindev, refcell and sadiq1971 as code owners July 8, 2025 17:45

theochap self-assigned this Jul 8, 2025

theochap added K-chore Kind: chore A-node Area: cl node (eq. Go op-node) handles single-chain consensus A-services Area: rollup services/actors labels Jul 8, 2025

theochap added this to Project Tracking Jul 8, 2025

theochap moved this to In Review in Project Tracking Jul 8, 2025

theochap added this to the [kona-node] Phase 5: Sequencer Mode milestone Jul 8, 2025