Skip to content

feat: fix teleportr ci, and lint target#2244

Merged
mslipper merged 1 commit intoethereum-optimism:developfrom
cfromknecht:fix-teleportr-ci
Mar 2, 2022
Merged

feat: fix teleportr ci, and lint target#2244
mslipper merged 1 commit intoethereum-optimism:developfrom
cfromknecht:fix-teleportr-ci

Conversation

@cfromknecht
Copy link
Contributor

Also fixes a linter error that wasn't caught while the CI was broken.

The yaml failed to parse because the postgres env vars didn't have dashes before them:

The workflow is not valid. .github/workflows/teleportr.yml (Line: 28, Col: 11): A sequence was not expected

Example of failed run: https://github.com/ethereum-optimism/optimism/actions/runs/1924304434

Also fixes a linter error that wasn't caught while the CI was broken.
@changeset-bot
Copy link

changeset-bot bot commented Mar 2, 2022

⚠️ No Changeset found

Latest commit: 0671bb7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added 2-reviewers M-ci Meta: ci related work labels Mar 2, 2022
@mslipper mslipper merged commit c1619de into ethereum-optimism:develop Mar 2, 2022
@cfromknecht cfromknecht deleted the fix-teleportr-ci branch March 2, 2022 20:38
theochap added a commit that referenced this pull request Dec 10, 2025
)

## Description

Rewire the sequencer unsafe payload sender from the engine to the
network.

Previously, the sequencer was sending the unsafe blocks it received from
the network `BuildTask` back to the network to call `InsertUnsafeTask`.
Since the `BuildTask` inserts the newly built payloads to the engine
state (like what the `InsertUnsafeTask` would do), this resulted in a
no-op.

Instead, the sequencer should send the payloads to the network to gossip
them to the p2p mesh.

## Misc

Close #2244
Built on top of #2376
theochap added a commit that referenced this pull request Jan 14, 2026
…-rs/kona#2378)

## Description

Rewire the sequencer unsafe payload sender from the engine to the
network.

Previously, the sequencer was sending the unsafe blocks it received from
the network `BuildTask` back to the network to call `InsertUnsafeTask`.
Since the `BuildTask` inserts the newly built payloads to the engine
state (like what the `InsertUnsafeTask` would do), this resulted in a
no-op.

Instead, the sequencer should send the payloads to the network to gossip
them to the p2p mesh.

## Misc

Close #2244
Built on top of #2376
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

M-ci Meta: ci related work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants