Skip to content

feat: feel the power claude ;)#184

Merged
louisliu2048 merged 1 commit intomainfrom
vui-chee/feel-the-power-ga
Mar 11, 2026
Merged

feat: feel the power claude ;)#184
louisliu2048 merged 1 commit intomainfrom
vui-chee/feel-the-power-ga

Conversation

@Vui-Chee
Copy link
Contributor

No description provided.

@louisliu2048 louisliu2048 merged commit f34d166 into main Mar 11, 2026
1 check passed
@Vui-Chee Vui-Chee deleted the vui-chee/feel-the-power-ga branch March 11, 2026 10:27
@claude claude bot mentioned this pull request Mar 11, 2026
Comment on lines +1 to +2
name: Claude Code

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 The workflow file .github/workflows/claude.md has a .md extension, but GitHub Actions only recognizes .yml or .yaml files in the workflows directory. This means the workflow will never trigger and the entire PR is non-functional. Rename the file to claude.yml.

Extended reasoning...

Bug Description

The PR adds a new GitHub Actions workflow file at .github/workflows/claude.md. While the file contents are valid YAML defining a workflow that triggers on issue comments, PR review comments, and issue events to run Claude Code, the file has a .md (Markdown) extension instead of the required .yml or .yaml extension.

Why This Is a Problem

GitHub Actions only discovers and executes workflow files that have .yml or .yaml extensions within the .github/workflows/ directory. This is explicitly documented in GitHub Actions documentation. Any file with a different extension — including .md — is silently ignored.

Step-by-Step Proof

  1. A user creates an issue mentioning @claude in the body.
  2. GitHub Actions checks .github/workflows/ for workflow files.
  3. GitHub Actions scans for files matching *.yml or *.yaml.
  4. claude.md does not match either pattern, so it is skipped entirely.
  5. No workflow runs. The Claude Code action never executes.
  6. The same applies for all other trigger events (issue comments, PR review comments, PR reviews).

Impact

This renders the entire PR non-functional. The workflow will never trigger under any circumstances, regardless of the events configured inside the file. No other workflow files exist in this repository that would provide this functionality.

Fix

Rename .github/workflows/claude.md to .github/workflows/claude.yml. No changes to the file contents are needed — the YAML syntax inside is valid.

Vui-Chee added a commit that referenced this pull request Mar 13, 2026
* main: (25 commits)
  fix: bump quinn-proto to 0.11.14 to patch CVE-2026-31812 DoS vuln (#183)
  pre-job authorization (#193)
  fix: trigger review skill failed to ack (#192)
  feat: trigger skill review separately (#191)
  feat: add Claude skills and CLAUDE.md for AI-assisted development (#190)
  rename ext (#185)
  supply workflow for claude (#184)
  feat(builder): incremental trie cache optimization for flashblocks state root (#163)
  chore(flashblocks-rpc): migrate op-reth flashblocks into xlayer-reth (#175)
  Feat(chainspec): adding xlayer-devnet chainspec (#167)
  chore(builder): flatten flashblocks builder, remove unnecessary trait interfaces (#172)
  rpc: remove unnecessary trait bounds and dependencies from XlayerRpcExtApiServer impl (#171)
  fix fmt in bin/tools/gen_genesis.rs (#170)
  fix(builder): Resolve bugs on upstream flashblocks timing scheduler (#169)
  Feat(tools): Add a tool to generate a custom genesis file based on a template and existing chain data (#159)
  feat(flashblocks): Add flashblocks sequence persistence logic on RPC and sequence replay flashblock builder (#162)
  chore(builder): remove unused custom-engine-api feature flag in tests (#168)
  fix: p2p test hang due to hang on port (#165)
  fix: update testcontainers to v0.27.0 to remediate CVE-2025-62518 (#164)
  chore(builder): further clean up builder crate (#161)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants