rpc: remove unnecessary trait bounds and dependencies from XlayerRpcExtApiServer impl#171
Merged
louisliu2048 merged 1 commit intomainfrom Mar 5, 2026
Merged
Conversation
…xtApiServer impl The XlayerRpcExtApiServer impl for XlayerRpcExt only uses PendingFlashBlockProvider via has_pending_flashblock(), but had excessive trait bounds including EthFees, LoadFee, LoadBlock, EthApiTypes, SequencerClientProvider, Clone, and complex Provider bounds that were never used. Changes: - Remove unused trait bounds from XlayerRpcExtApiServer impl, keeping only PendingFlashBlockProvider + Send + Sync + 'static - Remove unused imports (reth_chainspec, reth_rpc_eth_api helpers, reth_storage_api) from xlayer_ext.rs - Remove unused crate dependencies (reth-chainspec, reth-storage-api) from Cargo.toml This improves compile times by reducing trait resolution work and dependency graph, and makes the code clearer about actual requirements. Co-Authored-By: vuicheesiew@gmail.com <vuicheesiew@gmail.com>
Vui-Chee
added a commit
that referenced
this pull request
Mar 9, 2026
* main: Feat(chainspec): adding xlayer-devnet chainspec (#167) chore(builder): flatten flashblocks builder, remove unnecessary trait interfaces (#172) rpc: remove unnecessary trait bounds and dependencies from XlayerRpcExtApiServer impl (#171) fix fmt in bin/tools/gen_genesis.rs (#170) fix(builder): Resolve bugs on upstream flashblocks timing scheduler (#169) Feat(tools): Add a tool to generate a custom genesis file based on a template and existing chain data (#159) feat(flashblocks): Add flashblocks sequence persistence logic on RPC and sequence replay flashblock builder (#162) chore(builder): remove unused custom-engine-api feature flag in tests (#168) fix: p2p test hang due to hang on port (#165)
Vui-Chee
added a commit
that referenced
this pull request
Mar 13, 2026
* main: (25 commits) fix: bump quinn-proto to 0.11.14 to patch CVE-2026-31812 DoS vuln (#183) pre-job authorization (#193) fix: trigger review skill failed to ack (#192) feat: trigger skill review separately (#191) feat: add Claude skills and CLAUDE.md for AI-assisted development (#190) rename ext (#185) supply workflow for claude (#184) feat(builder): incremental trie cache optimization for flashblocks state root (#163) chore(flashblocks-rpc): migrate op-reth flashblocks into xlayer-reth (#175) Feat(chainspec): adding xlayer-devnet chainspec (#167) chore(builder): flatten flashblocks builder, remove unnecessary trait interfaces (#172) rpc: remove unnecessary trait bounds and dependencies from XlayerRpcExtApiServer impl (#171) fix fmt in bin/tools/gen_genesis.rs (#170) fix(builder): Resolve bugs on upstream flashblocks timing scheduler (#169) Feat(tools): Add a tool to generate a custom genesis file based on a template and existing chain data (#159) feat(flashblocks): Add flashblocks sequence persistence logic on RPC and sequence replay flashblock builder (#162) chore(builder): remove unused custom-engine-api feature flag in tests (#168) fix: p2p test hang due to hang on port (#165) fix: update testcontainers to v0.27.0 to remediate CVE-2025-62518 (#164) chore(builder): further clean up builder crate (#161) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
XlayerRpcExtApiServerimpl forXlayerRpcExt<T>had excessive trait bounds that were never actually used. The only method (flashblocks_enabled) callsself.backend.has_pending_flashblock(), which only requiresPendingFlashBlockProvider. This PR strips the unused bounds and their corresponding imports/dependencies.Removed trait bounds on
T:EthFees,LoadFee,LoadBlock,EthApiTypes<NetworkTypes = Net>,SequencerClientProvider,Clone, and the entireT::Provider: ChainSpecProvider<...> + BlockReaderIdExt + HeaderProviderclause.Removed unused crate dependencies:
reth-chainspec,reth-storage-api.Kept:
PendingFlashBlockProvider + Send + Sync + 'static(the only bounds actually needed).This reduces compile-time trait resolution work and shrinks the dependency graph for the
xlayer-rpccrate.Type of Change
Checklist
Testing
cargo check -p xlayer-rpc— passescargo test -p xlayer-rpc— all 4 existing tests passHuman Review Checklist
bin/node/src/main.rs) instantiatesXlayerRpcExtwithArc<OpEthApi<...>>. Confirm it compiles with the reduced bounds (local build hit an unrelatedopenssl-syssystem dep issue before reaching that crate).#[rpc]macro generatesinto_rpc()— verify it doesn't silently depend on any removed bounds at the call site inmain.rs.Additional Notes
Link to Devin session: https://app.devin.ai/sessions/12a9c90470fa4e81a5441eb476edce91
Requested by: @Vui-Chee