fix: p2p test hang due to hang on port#165
Merged
louisliu2048 merged 2 commits intomainfrom Mar 3, 2026
Merged
Conversation
Happens when we run devnet. Find next free port and execute request send with timeout.
JimmyShi22
reviewed
Mar 2, 2026
| if let Ok(Some(received)) = | ||
| tokio::time::timeout(Duration::from_millis(200), rx.recv()).await | ||
| { | ||
| return received; |
Contributor
There was a problem hiding this comment.
If tx2 is a bounded channel and the connection hasn't been established yet, repeated send(...).unwrap() inside the loop could panic when the channel fills up. Either use try_send and handle the full-channel case, or wait for the connection to complete before entering the send loop.
Contributor
|
The above comments are all within test code, so feel free to address them however works best — or leave them if the tradeoffs are acceptable for a test-only context. No blockers from my side. |
Vui-Chee
changed the title
- Fix TOCTOU race by binding both listeners simultaneously and holding them as guards until right before node construction - Add max retry count (100) for distinct port selection instead of unbounded loop - Use try_send instead of send().unwrap() to avoid panicking when the channel is full before connection is established
Vui-Chee
added a commit
that referenced
this pull request
Mar 9, 2026
* main: Feat(chainspec): adding xlayer-devnet chainspec (#167) chore(builder): flatten flashblocks builder, remove unnecessary trait interfaces (#172) rpc: remove unnecessary trait bounds and dependencies from XlayerRpcExtApiServer impl (#171) fix fmt in bin/tools/gen_genesis.rs (#170) fix(builder): Resolve bugs on upstream flashblocks timing scheduler (#169) Feat(tools): Add a tool to generate a custom genesis file based on a template and existing chain data (#159) feat(flashblocks): Add flashblocks sequence persistence logic on RPC and sequence replay flashblock builder (#162) chore(builder): remove unused custom-engine-api feature flag in tests (#168) fix: p2p test hang due to hang on port (#165)
Vui-Chee
added a commit
that referenced
this pull request
Mar 13, 2026
* main: (25 commits) fix: bump quinn-proto to 0.11.14 to patch CVE-2026-31812 DoS vuln (#183) pre-job authorization (#193) fix: trigger review skill failed to ack (#192) feat: trigger skill review separately (#191) feat: add Claude skills and CLAUDE.md for AI-assisted development (#190) rename ext (#185) supply workflow for claude (#184) feat(builder): incremental trie cache optimization for flashblocks state root (#163) chore(flashblocks-rpc): migrate op-reth flashblocks into xlayer-reth (#175) Feat(chainspec): adding xlayer-devnet chainspec (#167) chore(builder): flatten flashblocks builder, remove unnecessary trait interfaces (#172) rpc: remove unnecessary trait bounds and dependencies from XlayerRpcExtApiServer impl (#171) fix fmt in bin/tools/gen_genesis.rs (#170) fix(builder): Resolve bugs on upstream flashblocks timing scheduler (#169) Feat(tools): Add a tool to generate a custom genesis file based on a template and existing chain data (#159) feat(flashblocks): Add flashblocks sequence persistence logic on RPC and sequence replay flashblock builder (#162) chore(builder): remove unused custom-engine-api feature flag in tests (#168) fix: p2p test hang due to hang on port (#165) fix: update testcontainers to v0.27.0 to remediate CVE-2025-62518 (#164) chore(builder): further clean up builder crate (#161) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Happens when running devnet locally, just make test find next free port.