Windows

[MisterDA]

This pull request:

• updates vendored dependencies to their latest commit (on master branch) (required for client bug-fixes);
• updates the minimum OCaml version to 4.12;
• updates the requirement on Lwt to 5.4.1 for Windows bugfixes;
• adds a pipeline for building Windows Docker images containing fdopen's Docker for Windows Opam and OCaml installations;
• allows to run the client on Windows.

Building Windows Docker images requires OCluster workers running on Windows (see OCluster PR 128) are used. The current pipeline doesn't create multiarch images for different OS (i.e., an image containing Linux and Windows images). It doesn't change the current Linux tags in any way.

It uses three new distros: windows-mingw, windows-msvc, and cygwin, corresponding to the three OCaml Windows ports. Cygwin is currently disabled until newer versions of OCaml (4.12.1 ?) and Opam (2.1 ?) are made available.

The pushed Windows tags have the current scheme, where <distro> is one of windows-mingw or windows-msvc:

• <distro>-<win_version>-opam;
• <distro>-<win_version>-ocaml-<ocaml_version>;
• <distro>-<win_version> -> <distro>-<win_version>-ocaml-<ocaml_version_latest>;
• <distro>-ocaml-<ocaml_version>, a multiarch image containing all <distro>-<win_version>-ocaml-<ocaml_version> for each win_version.
• <distro> , a multiarch image containing all <distro>-<win_version> for each <win_version>.

The <win_version> corresponds to the mcr.microsoft.com/windows:<win_version> base image.

Some possible set of tags that aren't in this PR is:

• <distro>-opam, a multiarch image containing all <distro>-<win_version>-opam for all win_version, but as opam images are intermediary, we don't have to bother with it.

A image is generated for each version of Windows 10 (LTSC and Semi Annual releases only). Images for earlier versions of Windows 10 are not available. As Microsoft doesn't provide a "latest" tags for its images, we won't either provide an image based on the "latest" version of Windows.

Depends on :

• Windows ocaml-dockerfile#32
• Windows fixes ocaml-dockerfile#41
• New super Windows fixes! ocaml-dockerfile#42
• Better support for Windows 10 Updates ocaml-dockerfile#50
• Fix ENV directive quoting, use Fmt.str ocaml-dockerfile#53
• Winget fixes ocaml-dockerfile#54
• Remove RO bit on Windows file when deleting tmpdir ocurrent#270
• Don't pin current_ansi to this repo in Dockerfile ocurrent#268
• Fixes ocurrent#253
• Windows ocurrent#246
• Switch from "capnpc" to "capnp compile" ocurrent#233
• Update dependencies #119
• Get the list of aliases from the whole list of distros #120
• Lwt 5.4.1 + patch

Might depend on (but not sure as I haven't changed the API used):

• Windows support ocluster#128

[avsm]

All the prerequisites for this are now merged.

[talex5]

CI is failing. Probably the Dockerfile needs updating.

[talex5]

I split out some commits to #119 and #120. #119 is merged and I rebased on that. If you're happy with #120 we can merge and rebase on that too. That should leave just Windows stuff in this PR.

[avsm]

Winget Pr merged into dockerfile

[talex5]

Thanks, this is looking very good!

I rebased it on master to get the new diff test. There are two changes to the Linux builds that are probably accidental. I'm not qualified to say whether the Windows builds work.

Things to do before merging:

• Undo the changes to the Linux builds.
• @MisterDA mentioned that ocaml-dockerfile should be updated to remove the [TMP] bit in the last commit).

[talex5]

Suggested change

	match os_family with `Linux | `Cygwin -> cmd "bash" | `Windows -> cmd_exec ["cmd.exe"] @@
	(match os_family with `Linux | `Cygwin -> cmd "bash" | `Windows -> cmd_exec ["cmd.exe"]) @@

Otherwise it's doing something different ;-)

[talex5]

Was this change to the order of the commands intentional?

[talex5]

Deployed live, but some of the builds failed.

https://base-images.ocamllabs.io/job/2021-07-08/165647-ocluster-build-fde59f:

#=== ERROR while compiling ocaml-variants.4.09.1+mingw64 ======================#
# /bin/dash: 1: iconv: not found
# make[4]: *** [../../Makefile.common:71: getserv.o] Error 1

https://base-images.ocamllabs.io/job/2021-07-08/165647-ocluster-build-65fbee:

[ERROR] The sources of the following couldn't be obtained, aborting:
          - config-file.1.2: curl error code       0 [main] curl 834 child_info_fork::abort: \??\C:\cygwin64\bin\cygssl-1.1.dll: Loaded to different address: parent(0x3FE3A0000) != child(0x400000)
          - depext-cygwinports.0.0.8: curl error code       0 [main] curl 835 child_info_fork::abort: \??\C:\cygwin64\bin\cygssl-1.1.dll: Loaded to different address: parent(0x3FE3A0000) != child(0x400000)

https://base-images.ocamllabs.io/job/2021-07-08/165647-ocluster-build-dfdae0:

# File "C:\opam\.opam\4.06\.opam-switch\build\ocaml-variants.4.06.1+mingw64\middle_end\inlining_decision.ml", line 1:
# Error: Assembler error, input left in file C:\cygwin64\tmp\camlasmc2b619.s
# make[1]: *** [Makefile:1297: middle_end/inlining_decision.cmx] Error 2

[talex5]

After clicking the rebuild buttons a few times, everything is now passing.