New super Windows fixes! #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Can this be accompanied by an issue so we don't forget about it? I expect that what will happen is that by later in the summer when the Windows compiler are in opam-repository then we'll just be able to turn them back on here, rather than having to dig into the details in opam-repository-mingw but let's make sure we don't forget! |
MisterDA
force-pushed
the
windows-fixes
branch
2 times, most recently
from
7e928a2 to
29c3f09
Compare
Contributor
Author
|
This is good for merging, it will only require two minor updates when OCaml versions are released with the binutils 2.36 patch and when flexdll 0.39 enters Cygwin stable. |
Cygwin's setup 2.908 allows installing a specific version of a package. As GNU ld 2.36 broke OCaml, we'll stay on 2.35.2 until a fix is released in OCaml, then selectively install binutils 2.35.2 or the latest version depending on the fix being available in OCaml.
There's no particular need for using the servercore image as we pull the windows image anyway. By using the base windows image we avoid pulling servercore.
avsm
reviewed
May 17, 2021
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.