Windows #32
Merged
Windows #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
MisterDA
force-pushed
the
windows
branch
9 times, most recently
from
777815f to
db322c7
Compare
MisterDA
force-pushed
the
windows
branch
10 times, most recently
from
edde4c4 to
163d52b
Compare
This switches the base image from windows/servercore to windows, and moves all Cygwin-related functions in a dedicated submodule, with simplifies the code and allows the possibility of selecting the Cygwin root and mirror in the API. Thanks to David Allsopp for the help!
This makes the `cyg` parameter controlling Cygwin's root and mirror optional, with sane defaults.
Otherwise file paths containing spaces are not supported. Files are now escaped too.
When a single envvar was given, its value wasn't quoted. Now, the behaviour is unified.
Install visual studio and (respectively) cygwin packages in a single batch. This has the advantage of not duplicating the installer work, but the disadvantage that in case of a builder crash, more data is lost at each step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.