Windows fixes #41
Merged
Windows fixes #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dra27
reviewed
Mar 17, 2021
Collaborator
dra27
left a comment
dra27
left a comment
There was a problem hiding this comment.
#40's on its way in, so you can rebase without that commit with a few bits and bobs here there. Definitely skip Cygwin in this part for now - the aim is to spin out Cygwin into a container of its own which we won't maintain here (but which we may well then go on to consume for the mingw/msvc images)
FIXME: move Opam's cold compiler from 4.09 to 4.12
The name of the distro conflicts with multiarch images on Windows which bundle multiple versions of Windows. Microsoft doesn't provide a latest tag either.
Older versions are not build if they're deprecated, an we loose Windows multiarch images.
15 tasks
MisterDA
force-pushed
the
windows-fixes
branch
2 times, most recently
from
c55ffe7 to
e4cbcf8
Compare
I used to split the install to recover most of the cache in case of a Docker crash. Now we know crashes were caused by nested virtualization.
FIXME: telemetry can be disabled in newer winget, but that requires modifying some json (which is doable using powershell 6, not 5 because the json doc has comments; but the base image has powershell 5).
Doc: https://github.com/microsoft/winget-cli/blob/master/doc/Settings.md#telemetry The Powershell 5 JSON parser doesn't support comments, which the default settings.json file of WinGet contains. We resort to a hacky hack to add the necessary fields to disable telemetry. Another option could be to pull a JSON parser (e.g., jq, Powershell 6 or 7). The file needs to be generated with `winget settings`. It seems to be encoded in UTF-8 (without BOM) with LF line endings. Powershell 5 doesn't support UTF-8 without BOM, let's stick to ASCII. Running winget settings again validates the settings file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New batch of fixes!
This in particular duplicates the base Windows image to have mingw and msvc images. The final design still may change.
Incorporates #40.