fix: general solution for accessing associated constants by asterite · Pull Request #8417 · noir-lang/noir

asterite · 2025-05-08T13:19:18Z

Description

Problem

Follow-up to #8403
Fixes #7812
Fixes #7812

Summary

For each associated constant we create a definition (DefinitionId) with a new kind, DefinitionKind::AssociatedConstant, that holds a trait impl ID and the associated constant name
When looking up an associated constant, we know it's numeric type. We can also get a DefinitionId for it, so we elaborate it with those things.
Eventually during monomorphization and in the comptime interpreter, when we come across this new DefinitionKind we can look up the associated constant type and try to evaluate it to a number.

Additional Context

Documentation

Check one:

No documentation needed.
Documentation included in this PR.
[For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist

I have tested the changes locally.
I have formatted the changes with Prettier and/or cargo fmt on default settings.

github-actions

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Compilation Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: `5db9aed`	Previous: `ef6d866`	Ratio
`rollup-merge`	`1.468` s	`1.16` s	`1.27`

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

TomAFrench · 2025-05-16T12:09:27Z

Looks like this PR is going to be a requirement for #8545.

compiler/noirc_frontend/src/monomorphization/mod.rs

asterite · 2025-05-16T14:14:31Z

Force-pushed because there was a bad merge along the way.

This still doesn't work as when I wrote it I was just trying to see if an approach like this would work.

…elf_general_solution

github-actions

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: `b177feb`	Previous: `6cbf5c4`	Ratio
`test_report_zkpassport_noir_rsa_`	`3` s	`2` s	`1.50`

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

compiler/noirc_frontend/src/hir/comptime/interpreter.rs

compiler/noirc_frontend/src/monomorphization/mod.rs

tooling/nargo_cli/build.rs

…elf_general_solution

TomAFrench · 2025-05-27T14:31:50Z

@michaeljklein

Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE fix(fmt): correctly format mixed secondary attributes and doc comments (noir-lang/noir#8735) fix!: require types for trait impl associated constants (noir-lang/noir#8734) fix!: Prevent returning references from if expressions (noir-lang/noir#8731) fix: cast signed to u1 follow-up (noir-lang/noir#8730) fix: cast signed to u1 (noir-lang/noir#8720) fix: do not mutate arrays later copied inside other arrays (noir-lang/noir#8701) chore: box `AsTraitPath` and `TypePath` in `ExpressionKind` (noir-lang/noir#8716) fix: general solution for accessing associated constants (noir-lang/noir#8417) fix(ssa): Validate checked signed add/sub is followed by a truncate (noir-lang/noir#8706) chore: add pre- and post-check on `array_set` optimization pass (noir-lang/noir#8714) fix: merge expr bindings with instantiations bindings during monomorphization (noir-lang/noir#8713) fix: better way to do LSP file overrides (noir-lang/noir#8702) fix(fmt): correct indentation when formatting long struct patterns (noir-lang/noir#8711) fix(fuzz): Prevent breaking/continuing out from let blocks in the AST fuzzer (noir-lang/noir#8708) chore: remove override for zero length inputs (noir-lang/noir#8709) feat: Replace converging jmpif with empty block destinations with a single jmp (noir-lang/noir#8613) feat(cli): Add `nargo interpret` command (noir-lang/noir#8700) chore: more 1-tuple printing fixes (noir-lang/noir#8699) chore(fuzz): Fuzz the SSA parser (noir-lang/noir#8647) fix: (SSA parser) translate blocks in logical order rather than syntax order (noir-lang/noir#8668) fix(SSA): show and parse range_check's assert_message (noir-lang/noir#8652) chore: Show the step number in the SSA message (noir-lang/noir#8698) chore(docs): Add pointers to tests (noir-lang/noir#8695) chore(fuzz): Capture comptime print output (noir-lang/noir#8635) fix: nargo expand reexports correctly implemented (noir-lang/noir#8693) feat(cli): Show multiple SSA passes (noir-lang/noir#8692) chore(test): Add regression test for defunctionalize (noir-lang/noir#8691) chore: add an assertion when parsing SSA that all functions are well-formed (noir-lang/noir#8671) feat!: prevent compiling blake3 hashes which barretenberg cannot prove (noir-lang/noir#8690) fix(ssa): Remove the array cache from the function inserter (noir-lang/noir#8607) chore: bump external pinned commits (noir-lang/noir#8684) chore: reenable fuzzing tests in CI (noir-lang/noir#8688) fix: Handle `&mut function` in defunctionalize (noir-lang/noir#8665) fix(defunctionalize): Higher order functions (HOF) dynamic dispatch and HOFs in arrays (noir-lang/noir#8672) chore(ci): avoid running fuzzer tests in the merge queue (noir-lang/noir#8664) fix: Make casts in `comptime` consistent with runtime casts (noir-lang/noir#8669) fix: relax connectedness requirement on purity analysis pass (noir-lang/noir#8667) fix: always use `u32` for indexing arrays in SSA (noir-lang/noir#8633) chore: explicitly pull from `next` branch in aztec-packages (noir-lang/noir#8660) chore(fuzz): Build the dictionary from the SSA (noir-lang/noir#8591) chore(docs): Remove old versioned docs (noir-lang/noir#8061) chore: bump external pinned commits (noir-lang/noir#8634) fix(SSA): don't use string literal if byte is "form feed" ('\f') (noir-lang/noir#8653) chore(defunctionalize): Add regression test for missing lambda variants panic (noir-lang/noir#8642) chore(ci): Do not run ast_fuzzer orig vs. morph in ci (noir-lang/noir#8646) fix: disable underflow fix for fields (noir-lang/noir#8631) fix: revert "fix: error on unused generic in trait impl (noir-lang/noir#8395)" (noir-lang/noir#8636) fix(ssa interpreter): Default to zero when we have an overflowing shl (noir-lang/noir#8638) fix: ensure that purity analysis pass explores all functions (noir-lang/noir#8452) feat: acir_formal_proofs (noir-lang/noir#8140) fix: error on unused generic in trait impl (noir-lang/noir#8395) fix(expand): use re-exports for non-visibile items (noir-lang/noir#8374) END_COMMIT_OVERRIDE --------- Co-authored-by: AztecBot <tech@aztecprotocol.com> Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com> Co-authored-by: Ary Borenszweig <asterite@gmail.com>

asterite mentioned this pull request May 8, 2025

fix: allowing accessing associated constants via Self::... #8403

Merged

5 tasks

Base automatically changed from ab/access_trait_associated_constants_via_self to master May 13, 2025 17:28

github-actions bot reviewed May 16, 2025

View reviewed changes

jfecher reviewed May 16, 2025

View reviewed changes

compiler/noirc_frontend/src/monomorphization/mod.rs Show resolved Hide resolved

fix: general solution for accessing associated constants

fbda87a

asterite force-pushed the ab/access_trait_associated_constants_via_self_general_solution branch from 5db9aed to fbda87a Compare May 16, 2025 14:13

Fixes

7c1ddea

asterite mentioned this pull request May 16, 2025

Cannot resolve TraitAsPaths to define an associate constant in terms of another associated constant. #8548

Closed

asterite added 9 commits May 16, 2025 13:52

Ignore new nargo_expand test

02cb03e

Wrap associated types in type variables

dc09a56

Register definition IDs for each associated constant

0502b3f

Don't use type variables

cfcd411

Make it work for the interpreter

1f33012

Undo unneeded change

b0166ef

Properly handle error during comptime interpreter

5a2d07b

Properly handle error during monomorphization

8232e19

Merge branch 'master' into ab/access_trait_associated_constants_via_s…

748e262

…elf_general_solution

asterite requested a review from jfecher May 19, 2025 19:38

asterite added 3 commits May 20, 2025 11:13

Merge branch 'master' into ab/access_trait_associated_constants_via_s…

68a8257

…elf_general_solution

Merge branch 'master' into ab/access_trait_associated_constants_via_s…

bd2912b

…elf_general_solution

Snapshot

ea7ed64

github-actions bot reviewed May 22, 2025

View reviewed changes

asterite requested a review from a team May 22, 2025 14:08

michaeljklein suggested changes May 22, 2025

View reviewed changes

compiler/noirc_frontend/src/hir/comptime/interpreter.rs Outdated Show resolved Hide resolved

compiler/noirc_frontend/src/monomorphization/mod.rs Show resolved Hide resolved

tooling/nargo_cli/build.rs Show resolved Hide resolved

Only fetch location when needed

48ac45f

asterite requested a review from michaeljklein May 23, 2025 17:24

Merge branch 'master' into ab/access_trait_associated_constants_via_s…

b177feb

…elf_general_solution

TomAFrench approved these changes May 27, 2025

View reviewed changes

michaeljklein approved these changes May 29, 2025

View reviewed changes

asterite enabled auto-merge May 29, 2025 17:17

jfecher approved these changes May 29, 2025

View reviewed changes

asterite added this pull request to the merge queue May 29, 2025

Merged via the queue into master with commit 5d4a46c May 29, 2025
118 checks passed

asterite deleted the ab/access_trait_associated_constants_via_self_general_solution branch May 29, 2025 18:15

noirwhal mentioned this pull request May 29, 2025

chore: Release Noir(1.0.0-beta.7) #8520

Merged

AztecBot mentioned this pull request May 30, 2025

chore: Bump Noir reference AztecProtocol/aztec-packages#14492

Merged

AztecBot mentioned this pull request Jun 1, 2025

chore(next): release 0.88.0 AztecProtocol/aztec-packages#14495

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: general solution for accessing associated constants#8417

fix: general solution for accessing associated constants#8417
asterite merged 16 commits intomasterfrom
ab/access_trait_associated_constants_via_self_general_solution

asterite commented May 8, 2025 •

edited

Loading

Uh oh!

github-actions bot left a comment

Uh oh!

TomAFrench commented May 16, 2025 •

edited

Loading

Uh oh!

Uh oh!

asterite commented May 16, 2025

Uh oh!

github-actions bot left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TomAFrench commented May 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

asterite commented May 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Problem

Summary

Additional Context

Documentation

PR Checklist

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

Uh oh!

TomAFrench commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

asterite commented May 16, 2025

Uh oh!

github-actions bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TomAFrench commented May 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

asterite commented May 8, 2025 •

edited

Loading

TomAFrench commented May 16, 2025 •

edited

Loading

github-actions bot left a comment •

edited

Loading