chore: update quicksort from iterative noir_sort version#7348
Merged
michaeljklein merged 24 commits intomasterfrom Apr 30, 2025
Merged
chore: update quicksort from iterative noir_sort version#7348michaeljklein merged 24 commits intomasterfrom
quicksort from iterative noir_sort version#7348michaeljklein merged 24 commits intomasterfrom
Conversation
Contributor
Changes to Brillig bytecode sizes
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Contributor
Changes to number of Brillig opcodes executed
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Contributor
Author
|
Note: currently blocked by #7372 |
* master: (74 commits) feat: optimize out range checks on limiting cases (#7510) chore: clippy fixes (#7505) chore(docs): Supplement docs on `modexp` as a required precompile for Barretenberg's Solidity verifier (#7508) feat(debugger): REPL add breakpoint by sourcecode line (#5204) fix: issue duplicate error on impl function without self (#7490) feat(experimental): Support struct constructors in match patterns (#7489) feat: use resolved type instead of needing Constructor.struct_type (#7500) feat: better error message when keyword is found instead of type in p… (#7501) chore: bump external pinned commits (#7497) feat(experimental): Add invalid pattern syntax error (#7487) fix(performance): Accurately mark safe constant indices for arrays of complex types (#7491) fix(experimental): Allow shadowing in match patterns (#7484) chore: regression test #7195 (#7233) chore(docs): Section on `noir-profiler execution-opcodes` (#7480) chore: improve proptesting of 128bit values in `noirc_abi` (#7485) chore(profiler): Use brillig names for outputted flamegraphs (#7470) chore(docs): Profiler images reference (#7481) fix: don't use dummy location when inserting debug code (#7482) feat(cli)!: Add `--unstable-features` to gate unstable features (#7449) feat: Sync from aztec-packages (#7474) ...
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 657d360 | Previous: f0d47f8 | Ratio |
|---|---|---|---|
zkemail_noir-jwt_ |
5 s |
3 s |
1.67 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
jfecher
reviewed
Apr 29, 2025
Contributor
jfecher
left a comment
jfecher
left a comment
There was a problem hiding this comment.
Looks good, just curious why Env was removed.
Confusing errors when passing an Env containing references since this function is given to brillig?
jfecher
approved these changes
Apr 29, 2025
Contributor
jfecher
left a comment
jfecher
left a comment
There was a problem hiding this comment.
LGTM. Just need to exclude some tests from the debugger
github-merge-queue bot
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
May 1, 2025
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE feat: add `--debug-compile-stdin` to read `main.nr` from `STDIN` for testing (noir-lang/noir#8253) feat: better error message on unicode whitespace that isn't ascii whitespace (noir-lang/noir#8295) chore: update `quicksort` from iterative `noir_sort` version (noir-lang/noir#7348) fix: use correct meta attribute names in contract custom attributes (noir-lang/noir#8273) feat: `nargo expand` to show code after macro expansions (noir-lang/noir#7613) feat: allow specifying fuzz-related dirs when invoking `nargo test` (noir-lang/noir#8293) chore: redo typo PR by ciaranightingale (noir-lang/noir#8292) chore: Extend the bug list with issues found by the AST fuzzer (noir-lang/noir#8285) fix: don't disallow writing to memory after passing it to brillig (noir-lang/noir#8276) chore: test against zkpassport rsa lib (noir-lang/noir#8278) feat: omit element size array for more array types (noir-lang/noir#8257) chore: refactor array handling in ACIRgen (noir-lang/noir#8256) chore: document cast (noir-lang/noir#8268) END_COMMIT_OVERRIDE --------- Co-authored-by: AztecBot <tech@aztecprotocol.com> Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #7213
Summary*
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.