Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'ACVM Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: d875198 | Previous: 888f3a9 | Ratio |
|---|---|---|---|
perfectly_parallel_batch_inversion_opcodes |
4090221 ns/iter (± 18999) |
3216630 ns/iter (± 3626) |
1.27 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
TomAFrench
reviewed
Apr 30, 2025
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
TomAFrench
approved these changes
Apr 30, 2025
Member
TomAFrench
left a comment
TomAFrench
left a comment
There was a problem hiding this comment.
LGTM, a lexer test to check we get these errors would be nice.
Collaborator
Author
|
I included one, but only for one of the characters: https://github.com/noir-lang/noir/pull/8295/files#diff-45538d15b63063d6197de80fb67ad239351379090d3b4bba4ccb65ad51755140R1648 |
…com:noir-lang/noir into ab/better-error-when-non-unicode-whitespace
github-merge-queue bot
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
May 1, 2025
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE feat: add `--debug-compile-stdin` to read `main.nr` from `STDIN` for testing (noir-lang/noir#8253) feat: better error message on unicode whitespace that isn't ascii whitespace (noir-lang/noir#8295) chore: update `quicksort` from iterative `noir_sort` version (noir-lang/noir#7348) fix: use correct meta attribute names in contract custom attributes (noir-lang/noir#8273) feat: `nargo expand` to show code after macro expansions (noir-lang/noir#7613) feat: allow specifying fuzz-related dirs when invoking `nargo test` (noir-lang/noir#8293) chore: redo typo PR by ciaranightingale (noir-lang/noir#8292) chore: Extend the bug list with issues found by the AST fuzzer (noir-lang/noir#8285) fix: don't disallow writing to memory after passing it to brillig (noir-lang/noir#8276) chore: test against zkpassport rsa lib (noir-lang/noir#8278) feat: omit element size array for more array types (noir-lang/noir#8257) chore: refactor array handling in ACIRgen (noir-lang/noir#8256) chore: document cast (noir-lang/noir#8268) END_COMMIT_OVERRIDE --------- Co-authored-by: AztecBot <tech@aztecprotocol.com> Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
Resolves #5163
Summary
Here's an example error we get now:
This is similar to what Rust outputs.
Additional Context
Documentation
Check one:
PR Checklist
cargo fmton default settings.