chore: regression test #7195 by michaeljklein · Pull Request #7233 · noir-lang/noir

michaeljklein · 2025-01-29T22:37:02Z

Description

Problem*

Resolves #7207

Summary*

Additional Context

Documentation*

Check one:

No documentation needed.
Documentation included in this PR.
[For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

I have tested the changes locally.
I have formatted the changes with Prettier and/or cargo fmt on default settings.

… test of expected trace when stepping through test that was failing in #7195

github-actions

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: `6809698`	Previous: `668a476`	Ratio
`noir-lang_noir_json_parser_`	`11` s	`9` s	`1.22`

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

github-actions

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: `b19100f`	Previous: `6d319af`	Ratio
`global_var_regression_entry_points`	`0.009` s	`0.007` s	`1.29`

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

TomAFrench · 2025-01-29T23:18:48Z

Haven't looked at this in depth but we'll also want to make some brillig calls to make sure that we stitch the ACIR and brillig callstacks together properly.

…ger-indicated lines

tooling/debugger/src/repl.rs

tooling/debugger/tests/debug.rs

asterite

Looks good! I left a couple of questions.

…omment

tooling/nargo_cli/src/cli/debug_cmd.rs

aakoshh · 2025-02-10T13:26:40Z

It would be interesting to know why the call stack in these comments points at the use statements:

tooling/debugger/tests/debug.rs

TomAFrench · 2025-02-19T17:12:58Z

I'm good merging this. Just needs a format of noir code.

* master: (74 commits) feat: optimize out range checks on limiting cases (#7510) chore: clippy fixes (#7505) chore(docs): Supplement docs on `modexp` as a required precompile for Barretenberg's Solidity verifier (#7508) feat(debugger): REPL add breakpoint by sourcecode line (#5204) fix: issue duplicate error on impl function without self (#7490) feat(experimental): Support struct constructors in match patterns (#7489) feat: use resolved type instead of needing Constructor.struct_type (#7500) feat: better error message when keyword is found instead of type in p… (#7501) chore: bump external pinned commits (#7497) feat(experimental): Add invalid pattern syntax error (#7487) fix(performance): Accurately mark safe constant indices for arrays of complex types (#7491) fix(experimental): Allow shadowing in match patterns (#7484) chore: regression test #7195 (#7233) chore(docs): Section on `noir-profiler execution-opcodes` (#7480) chore: improve proptesting of 128bit values in `noirc_abi` (#7485) chore(profiler): Use brillig names for outputted flamegraphs (#7470) chore(docs): Profiler images reference (#7481) fix: don't use dummy location when inserting debug code (#7482) feat(cli)!: Add `--unstable-features` to gate unstable features (#7449) feat: Sync from aztec-packages (#7474) ...

feat: let all compiler errors carry a Location instead of a Span (noir-lang/noir#7486) chore: Increaes base64's allotted time (noir-lang/noir#7521) fix: don't crash on broken impl syntax (noir-lang/noir#7512) feat: optimize out range checks on limiting cases (noir-lang/noir#7510) chore: clippy fixes (noir-lang/noir#7505) chore(docs): Supplement docs on `modexp` as a required precompile for Barretenberg's Solidity verifier (noir-lang/noir#7508) feat(debugger): REPL add breakpoint by sourcecode line (noir-lang/noir#5204) fix: issue duplicate error on impl function without self (noir-lang/noir#7490) feat(experimental): Support struct constructors in match patterns (noir-lang/noir#7489) feat: use resolved type instead of needing Constructor.struct_type (noir-lang/noir#7500) feat: better error message when keyword is found instead of type in p… (noir-lang/noir#7501) chore: bump external pinned commits (noir-lang/noir#7497) feat(experimental): Add invalid pattern syntax error (noir-lang/noir#7487) fix(performance): Accurately mark safe constant indices for arrays of complex types (noir-lang/noir#7491) fix(experimental): Allow shadowing in match patterns (noir-lang/noir#7484) chore: regression test #7195 (noir-lang/noir#7233) chore(docs): Section on `noir-profiler execution-opcodes` (noir-lang/noir#7480) chore: improve proptesting of 128bit values in `noirc_abi` (noir-lang/noir#7485) chore(profiler): Use brillig names for outputted flamegraphs (noir-lang/noir#7470) chore(docs): Profiler images reference (noir-lang/noir#7481) fix: don't use dummy location when inserting debug code (noir-lang/noir#7482) feat(cli)!: Add `--unstable-features` to gate unstable features (noir-lang/noir#7449)

Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE chore: bump external pinned commits (noir-lang/noir#7515) feat: let all compiler errors carry a Location instead of a Span (noir-lang/noir#7486) chore: Increaes base64's allotted time (noir-lang/noir#7521) fix: don't crash on broken impl syntax (noir-lang/noir#7512) feat: optimize out range checks on limiting cases (noir-lang/noir#7510) chore: clippy fixes (noir-lang/noir#7505) chore(docs): Supplement docs on `modexp` as a required precompile for Barretenberg's Solidity verifier (noir-lang/noir#7508) feat(debugger): REPL add breakpoint by sourcecode line (noir-lang/noir#5204) fix: issue duplicate error on impl function without self (noir-lang/noir#7490) feat(experimental): Support struct constructors in match patterns (noir-lang/noir#7489) feat: use resolved type instead of needing Constructor.struct_type (noir-lang/noir#7500) feat: better error message when keyword is found instead of type in p… (noir-lang/noir#7501) chore: bump external pinned commits (noir-lang/noir#7497) feat(experimental): Add invalid pattern syntax error (noir-lang/noir#7487) fix(performance): Accurately mark safe constant indices for arrays of complex types (noir-lang/noir#7491) fix(experimental): Allow shadowing in match patterns (noir-lang/noir#7484) chore: regression test #7195 (noir-lang/noir#7233) chore(docs): Section on `noir-profiler execution-opcodes` (noir-lang/noir#7480) chore: improve proptesting of 128bit values in `noirc_abi` (noir-lang/noir#7485) chore(profiler): Use brillig names for outputted flamegraphs (noir-lang/noir#7470) chore(docs): Profiler images reference (noir-lang/noir#7481) fix: don't use dummy location when inserting debug code (noir-lang/noir#7482) feat(cli)!: Add `--unstable-features` to gate unstable features (noir-lang/noir#7449) END_COMMIT_OVERRIDE --------- Co-authored-by: guipublic <guipublic@gmail.com> Co-authored-by: guipublic <47281315+guipublic@users.noreply.github.com>

add raw-source-printing flag to debugger to disable highlighting, add…

d5d87fe

… test of expected trace when stepping through test that was failing in #7195

github-actions bot reviewed Jan 29, 2025

View reviewed changes

michaeljklein and others added 2 commits January 29, 2025 17:53

cargo clippy

69313d9

Merge branch 'master' into michaeljklein/regression_test_7195

b19100f

michaeljklein requested a review from a team January 29, 2025 22:53

michaeljklein changed the title ~~Regression test #7195~~ chore: regression test #7195 Jan 29, 2025

github-actions bot reviewed Jan 29, 2025

View reviewed changes

Merge branch 'master' into michaeljklein/regression_test_7195

816faf8

michaeljklein marked this pull request as draft January 30, 2025 16:47

michaeljklein and others added 5 commits February 4, 2025 10:36

Merge branch 'master' into michaeljklein/regression_test_7195

3e80dd5

Merge branch 'master' into michaeljklein/regression_test_7195

c427370

wip debugging, add unconstrained call to test, wip only testing debug…

cbbd7db

…ger-indicated lines

debugging test and cleanup

4e7dc83

Merge branch 'master' into michaeljklein/regression_test_7195

e64e1b5

michaeljklein marked this pull request as ready for review February 6, 2025 10:35

Merge branch 'master' into michaeljklein/regression_test_7195

7ebb52a

This was referenced Feb 6, 2025

brillig opcode execution flamegraphs seem broken #7093

Closed

Stack trace order in nargo debug is broken #7195

Closed

asterite reviewed Feb 6, 2025

View reviewed changes

tooling/debugger/src/repl.rs Show resolved Hide resolved

asterite reviewed Feb 6, 2025

View reviewed changes

tooling/debugger/tests/debug.rs Outdated Show resolved Hide resolved

asterite approved these changes Feb 6, 2025

View reviewed changes

michaeljklein and others added 3 commits February 7, 2025 10:44

Merge branch 'master' into michaeljklein/regression_test_7195

b1bc63a

responding to review comments: small refactor and add detail to doc c…

674c758

…omment

cargo clippy

c1506c1

aakoshh reviewed Feb 10, 2025

View reviewed changes

tooling/nargo_cli/src/cli/debug_cmd.rs Outdated Show resolved Hide resolved

TomAFrench reviewed Feb 10, 2025

View reviewed changes

tooling/debugger/tests/debug.rs Show resolved Hide resolved

TomAFrench mentioned this pull request Feb 10, 2025

Debugger panics when run in ACIR mode #7336

Open

aakoshh reviewed Feb 10, 2025

View reviewed changes

tooling/debugger/tests/debug.rs Show resolved Hide resolved

michaeljklein and others added 4 commits February 11, 2025 21:20

Merge branch 'master' into michaeljklein/regression_test_7195

6809698

remove redundant default clap cli value

33d36dc

Merge branch 'master' into michaeljklein/regression_test_7195

ce0c698

Merge branch 'master' into michaeljklein/regression_test_7195

c00cc64

TomAFrench enabled auto-merge February 18, 2025 21:58

michaeljklein and others added 2 commits February 19, 2025 12:42

Merge branch 'master' into michaeljklein/regression_test_7195

f563b9f

nargo fmt

cc6c4ba

michaeljklein requested a review from aakoshh February 19, 2025 23:29

Merge branch 'master' into michaeljklein/regression_test_7195

9af4834

asterite mentioned this pull request Feb 21, 2025

fix: don't use dummy location when inserting debug code #7482

Merged

5 tasks

vezenovm approved these changes Feb 21, 2025

View reviewed changes

TomAFrench added this pull request to the merge queue Feb 21, 2025

Merged via the queue into master with commit 47aec5d Feb 21, 2025
102 checks passed

TomAFrench deleted the michaeljklein/regression_test_7195 branch February 21, 2025 19:42

AztecBot mentioned this pull request Feb 26, 2025

feat: Sync from noir AztecProtocol/aztec-packages#12279

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: regression test #7195#7233

chore: regression test #7195#7233
TomAFrench merged 20 commits intomasterfrom
michaeljklein/regression_test_7195

michaeljklein commented Jan 29, 2025

Uh oh!

github-actions bot left a comment •

edited

Loading

Uh oh!

github-actions bot left a comment

Uh oh!

TomAFrench commented Jan 29, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

asterite left a comment

Uh oh!

Uh oh!

aakoshh commented Feb 10, 2025

Uh oh!

Uh oh!

Uh oh!

TomAFrench commented Feb 19, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

michaeljklein commented Jan 29, 2025

Description

Problem*

Summary*

Additional Context

Documentation*

PR Checklist*

Uh oh!

github-actions bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

Uh oh!

TomAFrench commented Jan 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

asterite left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aakoshh commented Feb 10, 2025

Uh oh!

Uh oh!

Uh oh!

TomAFrench commented Feb 19, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

github-actions bot left a comment •

edited

Loading

TomAFrench commented Jan 29, 2025 •

edited

Loading