Skip to content

fix: failing js tests #2722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kobyhallx merged 4 commits into from
Sep 15, 2023
Merged

fix: failing js tests #2722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cd53f49
fix: add source-resolver build to get integration testing on track
kobyhallx Sep 15, 2023
1e2c672
fix: missing import
kobyhallx Sep 15, 2023
28264e9
chore: drop playwright from integration tests
kobyhallx Sep 15, 2023
7e8edde
chore: updating lock
kobyhallx Sep 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/test-integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,13 @@ jobs:
path: ${{ env.UPLOAD_PATH }}
retention-days: 3

- name: Run `integration-tests`
- name: Setup `integration-tests`
run: |
yarn install --immutable
yarn workspace @noir-lang/noir-source-resolver build

- name: Run `integration-tests`
run: |
yarn test:integration

- name: Alert on nightly test failure
Expand Down
1 change: 0 additions & 1 deletion compiler/integration-tests/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
"@noir-lang/noirc_abi": "workspace:*",
"@web/dev-server-esbuild": "^0.3.6",
"@web/test-runner": "^0.15.3",
"@web/test-runner-playwright": "^0.10.0",
"@web/test-runner-webdriver": "^0.7.0"
}
}
2 changes: 1 addition & 1 deletion tooling/noirc_abi_wasm/test/browser/abi_encode.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { expect } from "@esm-bundle/chai";
import initNoirAbi, { abiEncode, abiDecode, WitnessMap } from "../../../../result";
import initNoirAbi, { abiEncode, abiDecode, WitnessMap } from "@noir-lang/noirc_abi";
import { DecodedInputs } from "../types";

beforeEach(async () => {
Expand Down
1 change: 0 additions & 1 deletion yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4277,7 +4277,6 @@ __metadata:
"@noir-lang/noirc_abi": "workspace:*"
"@web/dev-server-esbuild": ^0.3.6
"@web/test-runner": ^0.15.3
"@web/test-runner-playwright": ^0.10.0
"@web/test-runner-webdriver": ^0.7.0
languageName: unknown
linkType: soft
Expand Down