feat: Allow methods defined in a contract to be non-entry points#2687
Merged
feat: Allow methods defined in a contract to be non-entry points#2687
Conversation
TomAFrench
added a commit
that referenced
this pull request
Sep 15, 2023
* master: chore: Add deprecation message for default type in for loop (#2689) chore!: Change `noir-lang/noir-source-resolver` to `noir-lang/source-resolver` (#2718) chore: clippy fixes (#2719) chore: Integrate noir.js into workspace and CI release workflow (#2705) feat: Add initial version of noir.js (#2681) chore: switch `release-source-resolver.yml` to use yarn (#2704) chore: move stranded test to correct directory (#2701) chore(ci): deny wildcard dependencies (#2702) chore: fix `noirc_abi_wasm` publish for release-please (#2699) chore: introduce workspace for js packages (#2677) feat: Allow methods defined in a contract to be non-entry points (#2687) chore: revert some unwanted small changes from PR2180 (#2685) feat(lsp): Add nargo capabilities for test metadata (#2532) chore(ci): Add `cargo deny` workflow (#2682)
jfecher
reviewed
Sep 18, 2023
Comment on lines
+166
to
+168
| let functions = function_ids | ||
| .into_iter() | ||
| .map(|id| { |
Contributor
There was a problem hiding this comment.
We shouldn't collect into function_ids then call into_iter immediately afterward, the intermediate Vec is not needed.
Collaborator
|
cc @noir-lang/developerrelations @rahul-kothari not sure if this needs to be documented on aztec.nr's end. |
Contributor
|
I'm not sure, I'll defer to @rahul-kothari |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related to #2688
Problem*
Resolves
Summary*
Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.