Skip to content

feat(ssa): Perform dead instruction elimination on intrinsic functions#2276

Merged
TomAFrench merged 10 commits intomasterfrom
intrinsic-die
Aug 15, 2023
Merged

feat(ssa): Perform dead instruction elimination on intrinsic functions#2276
TomAFrench merged 10 commits intomasterfrom
intrinsic-die

Conversation

@TomAFrench
Copy link
Member

@TomAFrench TomAFrench commented Aug 10, 2023

Description

Problem*

Resolves

Summary*

This PR allows us to perform dead instruction elimination on any instrinsic functions which don't have side effects.

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench requested a review from jfecher August 10, 2023 21:43
@TomAFrench TomAFrench changed the title feat: Perform dead instruction elimination on intrinsics feat(ssa): Perform dead instruction elimination on intrinsics Aug 11, 2023
jfecher
jfecher requested changes Aug 11, 2023
View reviewed changes
jfecher
jfecher previously approved these changes Aug 15, 2023
View reviewed changes
@TomAFrench
Merge branch 'master' into intrinsic-die
70aaf04 
* master: (26 commits)
  chore(noir): Release 0.10.0 (#2039)
  fix(lsp): Ensure lsp does not crawl past the root specified (#2322)
  fix: Prevent panic when passing relative paths to `--program-dir` (#2324)
  fix: Overflowing assignment will result in an error (#2321)
  chore: clippy fixes (#2320)
  chore: Parameterize the build mode for noir-wasm (#2317)
  chore: Make `wasm` tests pull from `result` directory (#2319)
  chore: Fix typo (#2315)
  chore: Reuse workspace target directory in wasm build script (#2312)
  feat(nargo): Add `--workspace` flag to run commands in every package (#2313)
  chore(frontend): Replace `ModuleOrigin` with `Location` on `ModuleData` (#2308)
  fix: Fix 3 parser test cases in parsing (#2284)
  fix: Require package names to be non-empty (#2293)
  fix(nargo)!: Remove `-p` short flag from the `--program-dir` flag (#2300)
  feat: optionally output a debug artifact on compile (#2260)
  chore: `nargo info` now prints information as a prettified table  (#2282)
  fix(lsp): Pass `--program-dir` to test command from codelens (#2292)
  fix(nargo): Allow `--program-dir` flag anywhere in a command (#2290)
  feat: Execute brillig opcodes with constant inputs at compile-time (#2190)
  feat: Add basic benchmarking (#2213)
  ...
@TomAFrench
chore: handle Intrinsic::AssertConstant
e9fe52d
jfecher
jfecher previously approved these changes Aug 15, 2023
View reviewed changes
jfecher
jfecher previously approved these changes Aug 15, 2023
View reviewed changes
@TomAFrench
Merge branch 'master' into intrinsic-die
9db7912 
* master:
  feat: Improved error message for unexpected return type (#2302)
  feat(stdlib): Implement `str` `as_bytes` and `into_bytes` function (#2298)
  chore(ci): automatically convert changelog entries to sentence case (#2325)
@TomAFrench
chore: add Intrinsic::StrAsBytes to match
4f1ecea
@TomAFrench TomAFrench changed the title feat(ssa): Perform dead instruction elimination on intrinsics feat(ssa): Perform dead instruction elimination on intrinsic functions Aug 15, 2023
jfecher
jfecher approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take 3

@TomAFrench TomAFrench enabled auto-merge August 15, 2023 20:34
@TomAFrench TomAFrench added this pull request to the merge queue Aug 15, 2023
@TomAFrench
Copy link
Member Author

TomAFrench commented Aug 15, 2023

Sadly we've got conflicts with #2277 so our integration test will be broken. 😢 Can fix this later though as I don't want a take 4

Merged via the queue into master with commit 3fe3f8c Aug 15, 2023
@TomAFrench TomAFrench deleted the intrinsic-die branch August 15, 2023 21:34
@kevaundray kevaundray mentioned this pull request Aug 15, 2023
Merged
TomAFrench added a commit that referenced this pull request Aug 15, 2023
@TomAFrench
Merge branch 'master' into cleanup-integration
b0d11bd 
* master:
  feat(ssa): Perform dead instruction elimination on intrinsic functions (#2276)
  feat: Add full call stacks to runtime errors (#2310)
  chore(ci): fix mismatched input name to publish workflow (#2327)
@TomAFrench TomAFrench mentioned this pull request Aug 16, 2023
Merged
5 tasks
TomAFrench added a commit that referenced this pull request Aug 16, 2023
@TomAFrench
Merge branch 'master' into assert-eq-builtin
9f60f3c 
* master: (34 commits)
  chore: move orphaned integration tests to new directory (#2331)
  chore(noir): Release 0.10.1 (#2328)
  feat(ssa): Switch mem2reg pass to be per function rather than per block (#2243)
  feat(ssa): Perform dead instruction elimination on intrinsic functions (#2276)
  feat: Add full call stacks to runtime errors (#2310)
  chore(ci): fix mismatched input name to publish workflow (#2327)
  chore: add README for integration test structure (#2277)
  feat: Improved error message for unexpected return type (#2302)
  feat(stdlib): Implement `str` `as_bytes` and `into_bytes` function (#2298)
  chore(ci): automatically convert changelog entries to sentence case (#2325)
  chore(noir): Release 0.10.0 (#2039)
  fix(lsp): Ensure lsp does not crawl past the root specified (#2322)
  fix: Prevent panic when passing relative paths to `--program-dir` (#2324)
  fix: Overflowing assignment will result in an error (#2321)
  chore: clippy fixes (#2320)
  chore: Parameterize the build mode for noir-wasm (#2317)
  chore: Make `wasm` tests pull from `result` directory (#2319)
  chore: Fix typo (#2315)
  chore: Reuse workspace target directory in wasm build script (#2312)
  feat(nargo): Add `--workspace` flag to run commands in every package (#2313)
  ...
TomAFrench added a commit that referenced this pull request Aug 17, 2023
@TomAFrench
Merge branch 'master' into abi-wasm
c970b4f 
* master: (25 commits)
  chore: update noir-source-resolver from `1.1.2` to `^1.1.3` (#2349)
  chore(ci): Avoid writing to cache in workflows triggered by the merge queue (#2341)
  chore(noir): Release 0.10.3 (#2344)
  feat(lsp): Add `Execute` code lens for `main` functions (#2330)
  feat(lsp): Add `Compile` code lens for `main` function and contracts (#2309)
  feat: Allow calling higher-order functions with closures (#2335)
  fix: Display warning if last expression of block is unused (#2314)
  chore(noir): Release 0.10.2 (#2343)
  fix: Prevent dead instruction elimination of brillig functions which may contain side-effects (#2340)
  chore: Separate integration tests for contracts and programs (#2339)
  chore: move orphaned integration tests to new directory (#2331)
  chore(noir): Release 0.10.1 (#2328)
  feat(ssa): Switch mem2reg pass to be per function rather than per block (#2243)
  feat(ssa): Perform dead instruction elimination on intrinsic functions (#2276)
  feat: Add full call stacks to runtime errors (#2310)
  chore(ci): fix mismatched input name to publish workflow (#2327)
  chore: add README for integration test structure (#2277)
  feat: Improved error message for unexpected return type (#2302)
  feat(stdlib): Implement `str` `as_bytes` and `into_bytes` function (#2298)
  chore(ci): automatically convert changelog entries to sentence case (#2325)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vezenovm vezenovm vezenovm left review comments

@jfecher jfecher jfecher approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TomAFrench @jfecher @vezenovm