chore(ci): Avoid writing to cache in workflows triggered by the merge queue#2341
Merged
TomAFrench merged 19 commits intomasterfrom Aug 16, 2023
Merged
chore(ci): Avoid writing to cache in workflows triggered by the merge queue#2341TomAFrench merged 19 commits intomasterfrom
TomAFrench merged 19 commits intomasterfrom
Conversation
phated
reviewed
Aug 16, 2023
phated
reviewed
Aug 16, 2023
phated
reviewed
Aug 16, 2023
phated
suggested changes
Aug 16, 2023
Contributor
phated
left a comment
phated
left a comment
There was a problem hiding this comment.
I don't think env vars are expanded in the inputs section without the ${{ }} syntax
phated
reviewed
Aug 16, 2023
TomAFrench
changed the title
phated
suggested changes
Aug 16, 2023
Contributor
phated
left a comment
phated
left a comment
There was a problem hiding this comment.
One nit, and since this is closing the "revisit caching" issue, can you add nix caching to the build-wasm job inside wasm.yml? That is the longest step in the CI process because it doesn't have a cache for the cargo deps.
Member
Author
I was going to handle this in a follow-up PR to maintain the scope of this one but ok. |
phated
reviewed
Aug 16, 2023
phated
approved these changes
Aug 16, 2023
Contributor
phated
left a comment
phated
left a comment
There was a problem hiding this comment.
Thanks for this! One thing I'm still noticing is that we build wasm-bindgen-cli from source each time which takes a majority of the 7min CI. We can fix that later though
TomAFrench
added a commit
that referenced
this pull request
Aug 16, 2023
* master: chore: update noir-source-resolver from `1.1.2` to `^1.1.3` (#2349) chore(ci): Avoid writing to cache in workflows triggered by the merge queue (#2341) chore(noir): Release 0.10.3 (#2344) feat(lsp): Add `Execute` code lens for `main` functions (#2330) feat(lsp): Add `Compile` code lens for `main` function and contracts (#2309) feat: Allow calling higher-order functions with closures (#2335)
TomAFrench
added a commit
that referenced
this pull request
Aug 17, 2023
* master: (25 commits) chore: update noir-source-resolver from `1.1.2` to `^1.1.3` (#2349) chore(ci): Avoid writing to cache in workflows triggered by the merge queue (#2341) chore(noir): Release 0.10.3 (#2344) feat(lsp): Add `Execute` code lens for `main` functions (#2330) feat(lsp): Add `Compile` code lens for `main` function and contracts (#2309) feat: Allow calling higher-order functions with closures (#2335) fix: Display warning if last expression of block is unused (#2314) chore(noir): Release 0.10.2 (#2343) fix: Prevent dead instruction elimination of brillig functions which may contain side-effects (#2340) chore: Separate integration tests for contracts and programs (#2339) chore: move orphaned integration tests to new directory (#2331) chore(noir): Release 0.10.1 (#2328) feat(ssa): Switch mem2reg pass to be per function rather than per block (#2243) feat(ssa): Perform dead instruction elimination on intrinsic functions (#2276) feat: Add full call stacks to runtime errors (#2310) chore(ci): fix mismatched input name to publish workflow (#2327) chore: add README for integration test structure (#2277) feat: Improved error message for unexpected return type (#2302) feat(stdlib): Implement `str` `as_bytes` and `into_bytes` function (#2298) chore(ci): automatically convert changelog entries to sentence case (#2325) ...
TomAFrench
added a commit
that referenced
this pull request
Aug 22, 2023
* master: (46 commits) chore: Remove `serde` from `noirc_frontend` (#2390) chore: allow parenthesizing in two type locations (#2388) chore(ci): automatically delete cache entries associated with closed PRs (#2342) feat: Perform more checks for compile-time arithmetic (#2380) chore: Remove `noirc_abi::FunctionSignature` and define in terms of HIR (#2372) feat: Update to `acvm` 0.22.0 (#2363) chore: Update committed ACIR artifacts (#2376) feat(ssa): Merge slices in if statements with witness conditions (#2347) chore: Separate frontend `Visibility` and `Distinctness` from the ABI (#2369) feat: add syntax for specifying function type environments (#2357) chore: Remove unused `Directive::Log` (#2366) chore: clippy fixes (#2365) chore: Extract bytecode from artifact files for backend integration test inputs (#2356) feat: Add trait definition representation in DefCollector and HIR (#2338) chore: Remove unused `Intrinsic::Println` (#2358) fix: Remove duplicte `T` in `expected T, found T` error on tuple assignment (#2360) chore(brillig): Fix brillig radix instruction return vector size (#2350) fix: Show types in error message in same order as in source code (#2353) chore: update noir-source-resolver from `1.1.2` to `^1.1.3` (#2349) chore(ci): Avoid writing to cache in workflows triggered by the merge queue (#2341) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #2274
Summary*
This PR wraps our usage of the
actions/cacheaction with an action which choses between this andactions/cache/restorebased on a boolean input. We can then perform a read-only cache restore if the workflow was triggered by themerge_grouptrigger.Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.