Skip to content

feat: optionally output a debug artifact on compile#2260

Merged
sirasistant merged 8 commits intomasterfrom
arv/debug_symbols
Aug 14, 2023
Merged

feat: optionally output a debug artifact on compile#2260
sirasistant merged 8 commits intomasterfrom
arv/debug_symbols

Conversation

@sirasistant
Copy link
Contributor

@sirasistant sirasistant commented Aug 10, 2023 •
edited by TomAFrench
Loading

Description

Problem*

Resolves #2279

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

BEGIN_COMMIT_OVERRIDE
feat: Optionally output a debug artifact on compile (#2260)
END_COMMIT_OVERIDE

sirasistant
sirasistant commented Aug 10, 2023
View reviewed changes
sirasistant
sirasistant commented Aug 10, 2023
View reviewed changes
@sirasistant sirasistant requested a review from kevaundray August 11, 2023 07:24
@sirasistant sirasistant marked this pull request as ready for review August 11, 2023 07:24
TomAFrench
TomAFrench reviewed Aug 11, 2023
View reviewed changes
@sirasistant @TomAFrench
Update crates/nargo_cli/src/cli/compile_cmd.rs
e6adb6c 
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
kevaundray
kevaundray reviewed Aug 11, 2023
View reviewed changes
kevaundray
kevaundray reviewed Aug 11, 2023
View reviewed changes
kevaundray
kevaundray reviewed Aug 11, 2023
View reviewed changes
@sirasistant sirasistant enabled auto-merge August 11, 2023 10:07
TomAFrench
TomAFrench requested changes Aug 11, 2023
View reviewed changes
Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm currently making pretty large changes to these same files for #2164 which I think this would conflict pretty heavily with. I think it would be easier if those changes went in first and then I can merge them into here.

@kevaundray
Copy link
Contributor

kevaundray commented Aug 14, 2023

I'm currently making pretty large changes to these same files for #2164 which I think this would conflict pretty heavily with. I think it would be easier if those changes went in first and then I can merge them into here.

@TomAFrench what is the corresponding PR which is blocking this one?

TomAFrench
TomAFrench approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the PRs again and the overlap is smaller and less tangled than I initially thought so I don't have any objections for this going in first. Sorry for the delay @sirasistant!

@sirasistant sirasistant added this pull request to the merge queue Aug 14, 2023
Merged via the queue into master with commit edded24 Aug 14, 2023
@sirasistant sirasistant deleted the arv/debug_symbols branch August 14, 2023 15:22
@kevaundray kevaundray mentioned this pull request Aug 14, 2023
Merged
TomAFrench added a commit that referenced this pull request Aug 14, 2023
@TomAFrench
Merge branch 'master' into remove-backend-solver
ecfba96 
* master:
  fix: Require package names to be non-empty (#2293)
  fix(nargo)!: Remove `-p` short flag from the `--program-dir` flag (#2300)
  feat: optionally output a debug artifact on compile (#2260)
TomAFrench added a commit that referenced this pull request Aug 15, 2023
@TomAFrench
Merge branch 'master' into remove-keys-from-artifact
d9236f4 
* master:
  chore: Reuse workspace target directory in wasm build script (#2312)
  feat(nargo): Add `--workspace` flag to run commands in every package (#2313)
  chore(frontend): Replace `ModuleOrigin` with `Location` on `ModuleData` (#2308)
  fix: Fix 3 parser test cases in parsing (#2284)
  fix: Require package names to be non-empty (#2293)
  fix(nargo)!: Remove `-p` short flag from the `--program-dir` flag (#2300)
  feat: optionally output a debug artifact on compile (#2260)
  chore: `nargo info` now prints information as a prettified table  (#2282)
  fix(lsp): Pass `--program-dir` to test command from codelens (#2292)
  fix(nargo): Allow `--program-dir` flag anywhere in a command (#2290)
  feat: Execute brillig opcodes with constant inputs at compile-time (#2190)
  feat: Add basic benchmarking (#2213)
  feat: Include struct names in ABIs (#2266)
  feat(nargo): Add `--exact` flag to `nargo test` (#2272)
TomAFrench added a commit that referenced this pull request Aug 15, 2023
@TomAFrench
Merge branch 'master' into abi-wasm
075fde8 
* master: (23 commits)
  chore: Reuse workspace target directory in wasm build script (#2312)
  feat(nargo): Add `--workspace` flag to run commands in every package (#2313)
  chore(frontend): Replace `ModuleOrigin` with `Location` on `ModuleData` (#2308)
  fix: Fix 3 parser test cases in parsing (#2284)
  fix: Require package names to be non-empty (#2293)
  fix(nargo)!: Remove `-p` short flag from the `--program-dir` flag (#2300)
  feat: optionally output a debug artifact on compile (#2260)
  chore: `nargo info` now prints information as a prettified table  (#2282)
  fix(lsp): Pass `--program-dir` to test command from codelens (#2292)
  fix(nargo): Allow `--program-dir` flag anywhere in a command (#2290)
  feat: Execute brillig opcodes with constant inputs at compile-time (#2190)
  feat: Add basic benchmarking (#2213)
  feat: Include struct names in ABIs (#2266)
  feat(nargo): Add `--exact` flag to `nargo test` (#2272)
  fix: Fix assignment when both `mut` and `&mut` are used (#2264)
  feat: Add `assert_constant` (#2242)
  feat(nargo): Add support for contracts in `nargo check` (#2267)
  chore(ci): Name wasm job more clearly (#2269)
  chore(ci): Create cache key with consideration to target (#2273)
  chore(ci): Run publish workflow against PRs (#2268)
  ...
TomAFrench added a commit that referenced this pull request Aug 15, 2023
@TomAFrench
Merge branch 'master' into intrinsic-die
70aaf04 
* master: (26 commits)
  chore(noir): Release 0.10.0 (#2039)
  fix(lsp): Ensure lsp does not crawl past the root specified (#2322)
  fix: Prevent panic when passing relative paths to `--program-dir` (#2324)
  fix: Overflowing assignment will result in an error (#2321)
  chore: clippy fixes (#2320)
  chore: Parameterize the build mode for noir-wasm (#2317)
  chore: Make `wasm` tests pull from `result` directory (#2319)
  chore: Fix typo (#2315)
  chore: Reuse workspace target directory in wasm build script (#2312)
  feat(nargo): Add `--workspace` flag to run commands in every package (#2313)
  chore(frontend): Replace `ModuleOrigin` with `Location` on `ModuleData` (#2308)
  fix: Fix 3 parser test cases in parsing (#2284)
  fix: Require package names to be non-empty (#2293)
  fix(nargo)!: Remove `-p` short flag from the `--program-dir` flag (#2300)
  feat: optionally output a debug artifact on compile (#2260)
  chore: `nargo info` now prints information as a prettified table  (#2282)
  fix(lsp): Pass `--program-dir` to test command from codelens (#2292)
  fix(nargo): Allow `--program-dir` flag anywhere in a command (#2290)
  feat: Execute brillig opcodes with constant inputs at compile-time (#2190)
  feat: Add basic benchmarking (#2213)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomAFrench TomAFrench TomAFrench approved these changes

@kevaundray kevaundray Awaiting requested review from kevaundray

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Output debug files for external trazability of errors

3 participants

@sirasistant @kevaundray @TomAFrench