Skip to content

chore: Bump async-lsp to v0.0.5#2186

Merged
phated merged 4 commits intomasterfrom
phated/async-lsp-updates
Aug 9, 2023
Merged

chore: Bump async-lsp to v0.0.5#2186
phated merged 4 commits intomasterfrom
phated/async-lsp-updates

Conversation

@phated
Copy link
Contributor

@phated phated commented Aug 4, 2023

Description

Problem*

Ref #2168

Summary*

WIP to get us on latest async-lsp changes to make sure they work and then we can request a new official release

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench changed the title WIP: async-lsp updates chore: Bump async-lsp to v0.0.5 Aug 8, 2023
@TomAFrench TomAFrench linked an issue Aug 8, 2023 that may be closed by this pull request
Remove patch for async-lsp #2168
Closed
@TomAFrench
Copy link
Member

TomAFrench commented Aug 8, 2023

@phated async-lsp has made a new release so we can get off of the patched version now. I'm going to let you be in charge of deciding to merge this.

@phated
Copy link
Contributor Author

phated commented Aug 8, 2023

One thing that I'd still like to do here is fix the errors returned so we can use our own thiserror stuff instead of creating async-lsp errors.

@phated
Copy link
Contributor Author

phated commented Aug 9, 2023

One thing that I'd still like to do here is fix the errors returned so we can use our own thiserror stuff instead of creating async-lsp errors.

Notifications still don't allow returning custom errors correctly so I'm going to skip that for now. This should be good to land.

@phated phated marked this pull request as ready for review August 9, 2023 16:59
@phated phated added this pull request to the merge queue Aug 9, 2023
Merged via the queue into master with commit f74cbec Aug 9, 2023
@phated phated deleted the phated/async-lsp-updates branch August 9, 2023 17:20
TomAFrench added a commit that referenced this pull request Aug 10, 2023
@TomAFrench
Merge branch 'master' into abi-wasm
285ee1a 
* master: (80 commits)
  fix: properly capture lvalues in closure environments (#2120) (#2257)
  fix: Optimize contracts built by `nargo info` (#2259)
  chore: impl Display for DebugType (#2258)
  chore: update `noir_wasm` build process to match `acvm_js` (#2067)
  feat: Implement traits - parser support #2094 (#2230)
  chore: Refactor DefCollector duplicate errors (#2231)
  chore: Address clippy warnings (#2246)
  feat: Support `contract` package type in `nargo info` command (#2249)
  feat: Add slice append (#2241)
  chore: Bump `async-lsp` to v0.0.5 (#2186)
  chore: Move the remaining `nargo_cli` lib funcs into `nargo` crate (#2225)
  chore: Add test for eddsa (#2237)
  chore: Split `Nargo.toml` operations into separate package (#2224)
  fix(stdlib): correct `tecurve::contains` formula (#1821)
  feat: Remove `comptime` and warn upon usage (#2178)
  fix: Remove last vestige of array of structs to struct of arrays conversion (#2217)
  fix: Add foreign impl error (#2216)
  feat(nargo)!: Replace `--contracts` flag with `contract` package type (#2204)
  feat: Optimize `x < 0` for unsigned `x` to false (#2206)
  fix: Initialize numeric generics' type to a polymorphic integer when used in an expression (#2179)
  ...
TomAFrench added a commit that referenced this pull request Aug 11, 2023
@TomAFrench
Merge branch 'master' into constant-brillig-execution
34b7982 
* master: (29 commits)
  feat(nargo): Add support for contracts in `nargo check` (#2267)
  chore(ci): Name wasm job more clearly (#2269)
  chore(ci): Create cache key with consideration to target (#2273)
  chore(ci): Run publish workflow against PRs (#2268)
  chore: Merge in contents of `build-nargo` repository (#2211)
  fix(lsp): Improve dependency resolution in context of `Nargo.toml` (#2226)
  chore: Remove unnecessary duplication in how we test Noir compiler (#2248)
  fix: properly capture lvalues in closure environments (#2120) (#2257)
  fix: Optimize contracts built by `nargo info` (#2259)
  chore: impl Display for DebugType (#2258)
  chore: update `noir_wasm` build process to match `acvm_js` (#2067)
  feat: Implement traits - parser support #2094 (#2230)
  chore: Refactor DefCollector duplicate errors (#2231)
  chore: Address clippy warnings (#2246)
  feat: Support `contract` package type in `nargo info` command (#2249)
  feat: Add slice append (#2241)
  chore: Bump `async-lsp` to v0.0.5 (#2186)
  chore: Move the remaining `nargo_cli` lib funcs into `nargo` crate (#2225)
  chore: Add test for eddsa (#2237)
  chore: Split `Nargo.toml` operations into separate package (#2224)
  ...
TomAFrench added a commit that referenced this pull request Aug 11, 2023
@TomAFrench
Merge branch 'master' into assert-eq-builtin
7b2b9cb 
* master:
  feat: Add slice append (#2241)
  chore: Bump `async-lsp` to v0.0.5 (#2186)
  chore: Move the remaining `nargo_cli` lib funcs into `nargo` crate (#2225)
  chore: Add test for eddsa (#2237)
  chore: Split `Nargo.toml` operations into separate package (#2224)
  fix(stdlib): correct `tecurve::contains` formula (#1821)
  feat: Remove `comptime` and warn upon usage (#2178)
  fix: Remove last vestige of array of structs to struct of arrays conversion (#2217)
  fix: Add foreign impl error (#2216)
  feat(nargo)!: Replace `--contracts` flag with `contract` package type (#2204)
  feat: Optimize `x < 0` for unsigned `x` to false (#2206)
  fix: Initialize numeric generics' type to a polymorphic integer when used in an expression (#2179)
  chore(nargo)!: remove `flat_witness` feature flag (#2208)
  chore: Revert "feat: Only create new witnesses for distinctiveness when duplicates exist" (#2209)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomAFrench TomAFrench TomAFrench approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove patch for async-lsp

2 participants

@phated @TomAFrench