chore: Merge in contents of build-nargo repository#2211
Merged
TomAFrench merged 28 commits intomasterfrom Aug 10, 2023
Merged
Conversation
kevaundray
reviewed
Aug 8, 2023
kevaundray
reviewed
Aug 8, 2023
Member
Author
|
This PR is currently in draft as I perform testing, once I'm happy with the setup I'll restrict when it runs and re-enable alerts/publishing. |
Member
Author
|
We need to clone the noir repo into the |
Contributor
|
In a separate PR, we can make it such that each night, a new tag is created using the date like in Rust such that we can do the following: |
Contributor
|
Note: we have quite a bit of complexity from needing to cross compile barretenberg which should be minimized once we use prebuilt binaries |
Member
Author
|
This should be ready now. |
TomAFrench
commented
Aug 8, 2023
kevaundray
reviewed
Aug 8, 2023
kevaundray
reviewed
Aug 8, 2023
kevaundray
reviewed
Aug 8, 2023
kevaundray
previously approved these changes
Aug 8, 2023
Contributor
kevaundray
left a comment
kevaundray
left a comment
There was a problem hiding this comment.
This looks good to me, can change to GITHUB_TOKEN in a separate PR since there are concerns
TomAFrench
force-pushed
the
build-workflow
branch
from
203bb3c to
92d7d00
Compare
phated
suggested changes
Aug 9, 2023
Contributor
phated
left a comment
phated
left a comment
There was a problem hiding this comment.
Looking good. Just a couple more things and a clarification.
TomAFrench
commented
Aug 10, 2023
phated
previously approved these changes
Aug 10, 2023
Contributor
phated
left a comment
phated
left a comment
There was a problem hiding this comment.
Just some thoughts on future improvements. It'd be nice to have all these as issues 🙏
Member
Author
|
Issue for comments related to |
phated
approved these changes
Aug 10, 2023
TomAFrench
added a commit
that referenced
this pull request
Aug 11, 2023
* master: (29 commits) feat(nargo): Add support for contracts in `nargo check` (#2267) chore(ci): Name wasm job more clearly (#2269) chore(ci): Create cache key with consideration to target (#2273) chore(ci): Run publish workflow against PRs (#2268) chore: Merge in contents of `build-nargo` repository (#2211) fix(lsp): Improve dependency resolution in context of `Nargo.toml` (#2226) chore: Remove unnecessary duplication in how we test Noir compiler (#2248) fix: properly capture lvalues in closure environments (#2120) (#2257) fix: Optimize contracts built by `nargo info` (#2259) chore: impl Display for DebugType (#2258) chore: update `noir_wasm` build process to match `acvm_js` (#2067) feat: Implement traits - parser support #2094 (#2230) chore: Refactor DefCollector duplicate errors (#2231) chore: Address clippy warnings (#2246) feat: Support `contract` package type in `nargo info` command (#2249) feat: Add slice append (#2241) chore: Bump `async-lsp` to v0.0.5 (#2186) chore: Move the remaining `nargo_cli` lib funcs into `nargo` crate (#2225) chore: Add test for eddsa (#2237) chore: Split `Nargo.toml` operations into separate package (#2224) ...
TomAFrench
added a commit
that referenced
this pull request
Aug 11, 2023
* master: feat(nargo): Add support for contracts in `nargo check` (#2267) chore(ci): Name wasm job more clearly (#2269) chore(ci): Create cache key with consideration to target (#2273) chore(ci): Run publish workflow against PRs (#2268) chore: Merge in contents of `build-nargo` repository (#2211) fix(lsp): Improve dependency resolution in context of `Nargo.toml` (#2226) chore: Remove unnecessary duplication in how we test Noir compiler (#2248) fix: properly capture lvalues in closure environments (#2120) (#2257) fix: Optimize contracts built by `nargo info` (#2259) chore: impl Display for DebugType (#2258) chore: update `noir_wasm` build process to match `acvm_js` (#2067) feat: Implement traits - parser support #2094 (#2230) chore: Refactor DefCollector duplicate errors (#2231) chore: Address clippy warnings (#2246) feat: Support `contract` package type in `nargo info` command (#2249)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #2188
Summary*
Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.