feat(nargo)!: Replace --contracts flag with contract package type#2204
Merged
TomAFrench merged 3 commits intomasterfrom Aug 8, 2023
Merged
feat(nargo)!: Replace --contracts flag with contract package type#2204TomAFrench merged 3 commits intomasterfrom
--contracts flag with contract package type#2204TomAFrench merged 3 commits intomasterfrom
Conversation
phated
commented
Aug 8, 2023
phated
commented
Aug 8, 2023
5 tasks
TomAFrench
previously approved these changes
Aug 8, 2023
Member
|
We don't have a |
TomAFrench
approved these changes
Aug 8, 2023
Member
TomAFrench
left a comment
TomAFrench
left a comment
There was a problem hiding this comment.
LGTM. Can create new contract projects and compile.
TomAFrench
added a commit
that referenced
this pull request
Aug 10, 2023
* master: (80 commits) fix: properly capture lvalues in closure environments (#2120) (#2257) fix: Optimize contracts built by `nargo info` (#2259) chore: impl Display for DebugType (#2258) chore: update `noir_wasm` build process to match `acvm_js` (#2067) feat: Implement traits - parser support #2094 (#2230) chore: Refactor DefCollector duplicate errors (#2231) chore: Address clippy warnings (#2246) feat: Support `contract` package type in `nargo info` command (#2249) feat: Add slice append (#2241) chore: Bump `async-lsp` to v0.0.5 (#2186) chore: Move the remaining `nargo_cli` lib funcs into `nargo` crate (#2225) chore: Add test for eddsa (#2237) chore: Split `Nargo.toml` operations into separate package (#2224) fix(stdlib): correct `tecurve::contains` formula (#1821) feat: Remove `comptime` and warn upon usage (#2178) fix: Remove last vestige of array of structs to struct of arrays conversion (#2217) fix: Add foreign impl error (#2216) feat(nargo)!: Replace `--contracts` flag with `contract` package type (#2204) feat: Optimize `x < 0` for unsigned `x` to false (#2206) fix: Initialize numeric generics' type to a polymorphic integer when used in an expression (#2179) ...
TomAFrench
added a commit
that referenced
this pull request
Aug 11, 2023
* master: feat: Add slice append (#2241) chore: Bump `async-lsp` to v0.0.5 (#2186) chore: Move the remaining `nargo_cli` lib funcs into `nargo` crate (#2225) chore: Add test for eddsa (#2237) chore: Split `Nargo.toml` operations into separate package (#2224) fix(stdlib): correct `tecurve::contains` formula (#1821) feat: Remove `comptime` and warn upon usage (#2178) fix: Remove last vestige of array of structs to struct of arrays conversion (#2217) fix: Add foreign impl error (#2216) feat(nargo)!: Replace `--contracts` flag with `contract` package type (#2204) feat: Optimize `x < 0` for unsigned `x` to false (#2206) fix: Initialize numeric generics' type to a polymorphic integer when used in an expression (#2179) chore(nargo)!: remove `flat_witness` feature flag (#2208) chore: Revert "feat: Only create new witnesses for distinctiveness when duplicates exist" (#2209)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Ref #2075
Summary*
This implements the
contractpackage type in Nargo.toml but only replaces the--contractsflag onnargo compile; it doesn't implement contract support for other commands.Technically this could close #2075 since we only supported
nargo compilefor contracts, but I think we should work to support thecontractpackage type uniformly across all commands. I've started diving down this rabbit hole but there are still some unanswered questions so I wanted to unblock @Ethan-000's #2088 without causing unnecessary churn.Documentation
This PR requires documentation updates when merged.
The
--contractsflag was removed from thenargo compilecommand and instead thecontractpackage type needs to be specified in Nargo.tomlAdditional Context
PR Checklist*
cargo fmton default settings.