Merged
Conversation
Contributor
|
Seems the MacOS error was spurious so I restarted CI |
5 tasks
6 tasks
phated
force-pushed
the
phated/acvm-0.12.0
branch
from
091fad1 to
e1f5b61
Compare
6 tasks
* master: fix: Fix modulo operator for comptime values (#1361) chore: clarify that `verify_signature` takes a hashed message (#1365) feat: pass in closure to `Driver` to signal backend opcode support (#1349) feat(nargo)!: retire print-acir in favour of flag (#1328) chore(ssa): enable cse for assert (#1350) chore(ssa refactor): Add basic instruction simplification (#1329) chore(noir): Release 0.6.0 (#1279)
1 task
Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com> Co-authored-by: Tom French <tom@tomfren.ch>
TomAFrench
previously approved these changes
May 23, 2023
kevaundray
reviewed
May 23, 2023
kevaundray
reviewed
May 23, 2023
kevaundray
reviewed
May 23, 2023
kevaundray
reviewed
May 23, 2023
kevaundray
reviewed
May 23, 2023
kevaundray
reviewed
May 23, 2023
kevaundray
reviewed
May 23, 2023
kevaundray
reviewed
May 23, 2023
Contributor
kevaundray
left a comment
kevaundray
left a comment
There was a problem hiding this comment.
Mostly looks fine, for TODOs we should make issues so that we don't need to parse the codebase to figure these out and relevant discussions can be had in the issue
vezenovm
reviewed
May 23, 2023
Contributor
vezenovm
left a comment
vezenovm
left a comment
There was a problem hiding this comment.
One minor comment, though it is not blocking. Good with merging once issues are made for the TODOs
TomAFrench
previously approved these changes
May 24, 2023
* master: chore(ssa refactor): Add loop unrolling pass (#1364) chore: Add terms added in ssa refactor to `cspell` (#1385) chore(ssa refactor): Optimize constant `jmpif`s into `jmp`s (#1374) feat: Allow warnings by default (#1383) chore(github): Update GitHub Pull Request Template (#1370) chore(github): Update GitHub Bug Report Template (#1368) chore(ssa refactor): Update mem2reg pass to work with multiple functions and blocks (#1375) chore(ssa refactor): Add pass to simplify the control flow graph (#1373) chore(github): Update GitHub Feature Request Template (#1369)
TomAFrench
approved these changes
May 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #1302
Description
Summary of changes
This builds upon #1332 and switches the dependency overrides to using the patch syntax. I'm creating this draft because it is needed as the basis of my CRS work and we can keep it updated for other ACVM 0.12 updates.
Dependency additions / changes
Test additions / changes
Checklist
cargo fmtwith default settings.Documentation needs
Additional context