fix: to-bits and to-radix for > 128 bits#1312
Merged
guipublic merged 2 commits intonoir-lang:masterfrom May 11, 2023
Merged
Conversation
6 tasks
guipublic
reviewed
May 10, 2023
Contributor
guipublic
left a comment
guipublic
left a comment
There was a problem hiding this comment.
I am OK with replacing u128 with field elements for intrinsic arguments, but I am not sure your changes in the overflow check is correct. Could you provide a proof of correctness?
Contributor
Author
|
I reverted to the old overflow check based on the comments. There are also a couple of other issues in the
I guess I can fix these in a follow-up PR once I know what the right behaviour should be. |
guipublic
approved these changes
May 11, 2023
guipublic
pushed a commit
that referenced
this pull request
May 12, 2023
* fix: to-bits and to-radix for > 128 bits * revert: use earlier overflow check that ensures unicity
1 task
TomAFrench
added a commit
that referenced
this pull request
May 17, 2023
* master: (66 commits) feat(nargo)!: retire print-acir in favour of flag (#1328) chore(ssa): enable cse for assert (#1350) chore(ssa refactor): Add basic instruction simplification (#1329) chore(noir): Release 0.6.0 (#1279) feat: enable to_radix for any field element (#1343) chore(ssa refactor): Simplify inlining pass and fix inlining failure (#1337) chore!: Update to acvm 0.11.0 (#1322) feat: Add ECDSA secp256k1 builtin test (#1294) chore: add support for encoding/decoding inputs from JSON (#1325) feat: Issue an error when attempting to use a `return` expression (#1330) chore(ssa refactor): Fix inlining bug (#1335) fix: to-bits and to-radix for > 128 bits (#1312) chore(parser): Parser error optimisation (#1292) chore(ssa refactor): Implement function inlining (#1293) chore: fix installation link in readme (#1326) chore: fix installation link in readme (#1326) feat(stdlib): Add keccak (#1249) fix: Parsing nested generics (#1319) chore(ssa refactor): Document some SSA-gen functions (#1321) fix: Assigning to tuple fields (#1318) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #1311
See #1109 (comment)
Description
Summary of changes
u128before converting to bits or bytesAllowto_radix_baseto work for elements close to the modulusDependency additions / changes
Test additions / changes
Checklist
cargo fmtwith default settings.Documentation needs
Additional context
BEGIN_COMMIT_OVERRIDE
fix(stdlib): support use of
to_bitsandto_radixfor values >128 bits (#1312)END_COMMIT_OVERRIDE