feat: Add ECDSA secp256k1 builtin test#1294
Merged
kevaundray merged 20 commits intomasterfrom May 12, 2023
Merged
Conversation
Collaborator
Member
|
It could be helpful to move an equivalent of this across to aztec_backend as ideally we'd have a test for each black box function over there. |
1 task
kevaundray
force-pushed
the
kw/add-bck-ecdsa
branch
from
3a603d5 to
a693d74
Compare
Contributor
Author
|
This now fails with a constraint not satisfied error which is perhaps because of a misconfiguration in acvm/pwg. Before it was crashing -- Note, we are currently committed to a branch of barretenberg, so this is not mergable until that branch gets merged into bb/master |
kevaundray
commented
May 11, 2023
kevaundray
commented
May 11, 2023
Contributor
Author
|
Hmm tests taking so long implies that the nix cache may not be working fully |
vezenovm
approved these changes
May 11, 2023
Contributor
vezenovm
left a comment
vezenovm
left a comment
There was a problem hiding this comment.
Just some nits, good to merge with tests passing
This was referenced May 12, 2023
TomAFrench
added a commit
that referenced
this pull request
May 17, 2023
* master: (66 commits) feat(nargo)!: retire print-acir in favour of flag (#1328) chore(ssa): enable cse for assert (#1350) chore(ssa refactor): Add basic instruction simplification (#1329) chore(noir): Release 0.6.0 (#1279) feat: enable to_radix for any field element (#1343) chore(ssa refactor): Simplify inlining pass and fix inlining failure (#1337) chore!: Update to acvm 0.11.0 (#1322) feat: Add ECDSA secp256k1 builtin test (#1294) chore: add support for encoding/decoding inputs from JSON (#1325) feat: Issue an error when attempting to use a `return` expression (#1330) chore(ssa refactor): Fix inlining bug (#1335) fix: to-bits and to-radix for > 128 bits (#1312) chore(parser): Parser error optimisation (#1292) chore(ssa refactor): Implement function inlining (#1293) chore: fix installation link in readme (#1326) chore: fix installation link in readme (#1326) feat(stdlib): Add keccak (#1249) fix: Parsing nested generics (#1319) chore(ssa refactor): Document some SSA-gen functions (#1321) fix: Assigning to tuple fields (#1318) ...
spalladino
pushed a commit
to spalladino/noir
that referenced
this pull request
May 24, 2023
* Copy ECDSA from commit 92ef9b4 * rework for new syntax * commit since github was down * [NOT MERGEABLE] - Skip all tests except ecdsa * change parameter order * update flake.lock * update test * update flake.lock * update flake.lock * modify test * add message + hashed_message to program * remove underscore * modify input to use low-S * commit s variant 1 * commit variant S2 * modify s value in signature to value that passes in acvm/pwg * update flake.lock * remove if statement to make tests go faster * cleanup test
sirasistant
pushed a commit
that referenced
this pull request
May 31, 2023
* feat: enable to_radix for any field element (#1343) * Enable to_radix for any field element * add integration test * use proper bound during modulo (and small optimisation) * update integration test * feat: Add ECDSA secp256k1 builtin test (#1294) * Copy ECDSA from commit 92ef9b4 * rework for new syntax * commit since github was down * [NOT MERGEABLE] - Skip all tests except ecdsa * change parameter order * update flake.lock * update test * update flake.lock * update flake.lock * modify test * add message + hashed_message to program * remove underscore * modify input to use low-S * commit s variant 1 * commit variant S2 * modify s value in signature to value that passes in acvm/pwg * update flake.lock * remove if statement to make tests go faster * cleanup test --------- Co-authored-by: guipublic <47281315+guipublic@users.noreply.github.com> Co-authored-by: kevaundray <kevtheappdev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #
Description
This adds back the ECDSA secp256k1 test, to see what the status of it is since UltraPlonk
Summary of changes
Dependency additions / changes
Test additions / changes
Checklist
cargo fmtwith default settings.Documentation needs
Additional context
BEGIN_COMMIT_OVERRIDE
chore: Add ECDSA secp256k1 builtin test (#1294)
END_COMMIT_OVERRIDE