chore(ssa refactor): Implement function inlining#1293
Merged
kevaundray merged 7 commits intomasterfrom May 9, 2023
Merged
Conversation
Contributor
Author
|
Open questions:
|
joss-aztec
reviewed
May 5, 2023
Contributor
Probably out of scope for this PR, but if tested in conjunction with constant folding and DCE, we could:
E.g. check that Reduces to I guess we'd also need other simplification passes if were we to test a program containing functions that compromise of more than a single block. |
kevaundray
approved these changes
May 9, 2023
TomAFrench
added a commit
that referenced
this pull request
May 12, 2023
* phated/acvm-0.12.0: (45 commits) chore!: Update to ACVM 0.12.0 official release of backend feat: use dummy constructor for bb call chore: add missing `?` chore: use `try_vecmap` in old `vecmap` locations chore: update `acvm-backend-barretenberg` to 0.1.0 commit latest master fix: improve variable resolution test: re enabled sort test chore: update cargo tomls feat: adapted to heterogeneous bb calls remove unneeded import fix grep problems chore: replace long `Backend` type parameters with `B` update to latest commit chore: Make CliError generic over a Backend chore: Update nargo core to return backend errors chore!: Update to acvm 0.11.0 chore(parser): Parser error optimisation (#1292) chore(ssa refactor): Implement function inlining (#1293) ...
TomAFrench
added a commit
that referenced
this pull request
May 17, 2023
* master: (66 commits) feat(nargo)!: retire print-acir in favour of flag (#1328) chore(ssa): enable cse for assert (#1350) chore(ssa refactor): Add basic instruction simplification (#1329) chore(noir): Release 0.6.0 (#1279) feat: enable to_radix for any field element (#1343) chore(ssa refactor): Simplify inlining pass and fix inlining failure (#1337) chore!: Update to acvm 0.11.0 (#1322) feat: Add ECDSA secp256k1 builtin test (#1294) chore: add support for encoding/decoding inputs from JSON (#1325) feat: Issue an error when attempting to use a `return` expression (#1330) chore(ssa refactor): Fix inlining bug (#1335) fix: to-bits and to-radix for > 128 bits (#1312) chore(parser): Parser error optimisation (#1292) chore(ssa refactor): Implement function inlining (#1293) chore: fix installation link in readme (#1326) chore: fix installation link in readme (#1326) feat(stdlib): Add keccak (#1249) fix: Parsing nested generics (#1319) chore(ssa refactor): Document some SSA-gen functions (#1321) fix: Assigning to tuple fields (#1318) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #
Description
Summary of changes
Implements function inlining for the ssa refactoring. This pass will attempt to inline all functions into (a copy of) main. If it fails to inline all functions because a function in a function call is still unknown, it will keep each function in the
Ssastruct and set the new main function to the partially-inlined version. If all functions are successfully inlined, the fully-inlined main function is the new main function and all other functions are removed.Dependency additions / changes
Test additions / changes
Checklist
cargo fmtwith default settings.Documentation needs
Additional context