feat(stdlib): EdDSA sig verification

[shuklaayush]

Related issue(s)

Resolves #1109
Supercedes #1136
Depends on #1312, #1343

Description

Summary of changes

• Add a eddsa::eddsa_poseidon_verify function to stdlib
• Update std::ec functions to use builtin to_bits
• Create std::compat with a is_bn254 function

Dependency additions / changes

Test additions / changes

Checklist

• I have tested the changes locally.
• I have formatted the changes with Prettier and/or cargo fmt with default settings.
• I have linked this PR to the issue(s) that it resolves.
• I have reviewed the changes on GitHub, line by line.
• I have ensured all changes are covered in the description.

Documentation needs

• This PR requires documentation updates when merged.

Additional context

[guipublic]

I implemented the to_bits for any field in PR #1343, could you compare the cost between your noir implementation vs the PR?
In my tests, it was only 2% better.

[shuklaayush]

I'm getting a Error: could not satisfy all constraints in this line with your changes

noir/crates/nargo_cli/tests/test_data/eddsa/src/main.nr

Line 57 in a04e78a

assert(!eddsa_poseidon_verify(pub_key_a.x, pub_key_a.y, s_a, r8_a.x, r8_a.y, msg + 1));

noir/noir_stdlib/src/eddsa.nr

Line 50 in a04e78a

let right = bjj.curve.add(signature_r8, bjj.curve.mul(hash, pub_key_mul_8));

[guipublic]

I'm getting a Error: could not satisfy all constraints in this line with your changes

I don't think it is related to the to_bits, I checked the to_bits used and they produce the same version with the noir implementation and with my changes.

UPDATE: Using the ex you provided, I was able to see the issue and it is fixed

[shuklaayush]

UPDATE: Using the ex you provided, I was able to see the issue and it is fixed

Thanks, everything seems to work now and total constraints are back to ~145k compared to ~247k constraints in #1312 (comment)

[shuklaayush]

@kevaundray This should be good for review

[guipublic]

My points have been addressed so for me this is OK to go, but I let final approval to Kev as I did not review the cryptography part.

[kevaundray]

Left one question re commented out code

approved in above comment