chore: add ECDSA support to the aztec3-hacky branch#1396
chore: add ECDSA support to the aztec3-hacky branch#1396sirasistant merged 2 commits intonoir-lang:aztec3-hackyfrom
Conversation
* Enable to_radix for any field element * add integration test * use proper bound during modulo (and small optimisation) * update integration test
* Copy ECDSA from commit 92ef9b4 * rework for new syntax * commit since github was down * [NOT MERGEABLE] - Skip all tests except ecdsa * change parameter order * update flake.lock * update test * update flake.lock * update flake.lock * modify test * add message + hashed_message to program * remove underscore * modify input to use low-S * commit s variant 1 * commit variant S2 * modify s value in signature to value that passes in acvm/pwg * update flake.lock * remove if statement to make tests go faster * cleanup test
|
Tagging @sirasistant |
spalladino
changed the title
|
Clippy errors originate from the branch itself, so this is fine. For reference + context; ECDSA was broken in the barretenberg backend and recently got fixed. Since it is not a Noir only error, we will also need to point to the version of barretenberg that introduces this fix. This is likely why the tests won't pass. We also cannot point to the latest barretenberg because I think this includes breaking changes between the version that the hacky branch points to and the version with the ECDSA fix. It is definitely possible to patch an old version of barretenberg too and point to a branch in barretenberg, let me know if this is something you wish to pursue |
|
FWIW ECDSA is working fine here using this branch! |
Oh thanks for the correction :) I'm not quite sure why this works then since I also had to make a change in barretenberg too to make the verifier not panic + a few other miscellaneous fixes by Zac. If it's working on your end for the hacky branch though, then please feel free to ignore me :) |
|
My guess is @sirasistant magic 🪄 |
|
Every feature that we can add to the hacky branch is welcome :D |
4 participants
Cherry-pick the commits needed for ECDSA support to the aztec3-hacky branch, so we can use it from Noir contracts in Aztec.