fix(ssa-interpreter): Ignore index overflow when side effects are disabled#10183
Merged
TomAFrench merged 3 commits intomasterfrom Oct 14, 2025
Merged
fix(ssa-interpreter): Ignore index overflow when side effects are disabled#10183TomAFrench merged 3 commits intomasterfrom
TomAFrench merged 3 commits intomasterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 5a1dc6e | Previous: d5d7c2a | Ratio |
|---|---|---|---|
test_report_zkpassport_noir-ecdsa_ |
3 s |
1 s |
3 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
vezenovm
approved these changes
Oct 14, 2025
github-merge-queue bot
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Oct 15, 2025
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE feat(ACIR): exact element_type_sizes_array (noir-lang/noir#10188) chore: add unit test for keep_last_store (noir-lang/noir#10177) fix(ssa-interpreter): Ignore index overflow when side effects are disabled (noir-lang/noir#10183) fix: emit error on oracle functions with function bodies (noir-lang/noir#10132) chore: bump bb version (noir-lang/noir#10181) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #10180
Summary*
Fixes the logic introduced in #10110 to not fail
interpret_array_getif the index overflows, but we are under a disabled predicate. (interpret_array_setdidn't even look up the index when side effects were disabled, so it needed no fix).Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.