Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions compiler/noirc_evaluator/src/ssa/interpreter/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -964,24 +964,39 @@ impl<'ssa, W: Write> Interpreter<'ssa, W> {
result: ValueId,
side_effects_enabled: bool,
) -> IResult<()> {
// When there is a problem indexing the array, but side effects are disabled,
// define the value as uninitialized.
let uninitialized = |this: &mut Self| {
let typ = this.dfg().type_of_value(result);
let value = Value::uninitialized(&typ, result);
this.define(result, value)
};

let offset = self.dfg().array_offset(array, index);
let array = self.lookup_array_or_slice(array, "array get")?;
let length = array.elements.borrow().len() as u32;
let index = self.lookup_array_index(index, "array get index", length)?;

let index = match self.lookup_array_index(index, "array get index", length) {
Err(InterpreterError::IndexOutOfBounds { .. }) if !side_effects_enabled => {
return uninitialized(self);
}
other => other?,
};
let mut index = index - offset.to_u32();

let element = if length == 0 {
if length == 0 {
// Accessing an array of 0-len is replaced by asserting
// the branch is not-taken during acir-gen and
// a zeroed type is used in case of array get
// So we can simply replace it with uninitialized value
if side_effects_enabled {
return Err(InterpreterError::IndexOutOfBounds { index: index.into(), length });
} else {
let typ = self.dfg().type_of_value(result);
Value::uninitialized(&typ, result)
return uninitialized(self);
}
} else {
}

let element = {
// An array_get with false side_effects_enabled is replaced
// by a load at a valid index during acir-gen.
if !side_effects_enabled {
Expand Down
6 changes: 6 additions & 0 deletions test_programs/execution_success/regression_10180/Nargo.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
[package]
name = "regression_10180"
type = "bin"
authors = [""]

[dependencies]
2 changes: 2 additions & 0 deletions test_programs/execution_success/regression_10180/Prover.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
b = true
return = "193432430920915057603408161267722629873"
12 changes: 12 additions & 0 deletions test_programs/execution_success/regression_10180/src/main.nr
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
global G_B: [(str<2>, Field)] = &[
("SM", 193432430920915057603408161267722629873),
("QK", 28517051330822917784420357897851281178),
("XJ", -303354957477210748157621923488550325890),
];
fn main(b: bool) -> pub Field {
if b {
G_B[(1783103175_u32 % G_B.len())].1
} else {
(G_B[1771627614_u32].1 / G_B[2334904280_u32].1)
}
}

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading