fix: emit error on oracle functions with function bodies#10132
fix: emit error on oracle functions with function bodies#10132TomAFrench merged 14 commits intomasterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 1ac9617 | Previous: 86565a2 | Ratio |
|---|---|---|---|
test_report_noir-lang_noir_bigcurve_ |
407 s |
328 s |
1.24 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 1ac9617 | Previous: 86565a2 | Ratio |
|---|---|---|---|
rollup-checkpoint-merge |
0.004 s |
0.003 s |
1.33 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
aakoshh
left a comment
aakoshh
left a comment
There was a problem hiding this comment.
Looks good 👍
I couldn't see an oracle appear as a function in SSA as an fn, rather than just an identifier, so it looks like there is nothing to look at for an empty function body.
|
Huh, I'm having the debugger tests all passing locally so not sure why this is failing in CI. |
|
For some reason if you run Another thing I noticed is that the new code is put for built-in, low-level, etc., so I thought maybe it's erroring in those cases but no... |
|
Ah, no... I think the debugger tests use a compiled |
https://docs.rs/assert_cmd/latest/assert_cmd/cargo/index.html |
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE feat(ACIR): exact element_type_sizes_array (noir-lang/noir#10188) chore: add unit test for keep_last_store (noir-lang/noir#10177) fix(ssa-interpreter): Ignore index overflow when side effects are disabled (noir-lang/noir#10183) fix: emit error on oracle functions with function bodies (noir-lang/noir#10132) chore: bump bb version (noir-lang/noir#10181) END_COMMIT_OVERRIDE
4 participants
Description
Problem*
Resolves #10131
Summary*
I've added a quick check where we skip elaboration of a presumed empty function body to ensure that it doesn't include any statements.
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.