Skip to content

feat(ACIR): exact element_type_sizes_array#10188

Merged
TomAFrench merged 1 commit intomasterfrom
ab/acir-exact_element_type_sizes_array
Oct 14, 2025
Merged

feat(ACIR): exact element_type_sizes_array#10188
TomAFrench merged 1 commit intomasterfrom
ab/acir-exact_element_type_sizes_array

Conversation

@asterite
Copy link
Collaborator

Description

Problem

Resolves #10187

Summary

Additional Context

Documentation

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@github-actions
Copy link
Contributor

Changes to circuit sizes

Generated at commit: ee112d8e5ff53ba20c324cc06b168e77e4d1bae6, compared to commit: 96fb8193436323f4469e5e6f6c7090a0be99be8f

🧾 Summary (10% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
regression_struct_array_conditional -1 ✅ -1.43% -5 ✅ -0.15%
nested_array_dynamic -2 ✅ -0.07% -26 ✅ -0.22%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
array_dynamic_nested_blackbox_input 118 (-1) -0.84% 17,416 (0) 0.00%
databus_composite_calldata 136 (-1) -0.73% 3,136 (-3) -0.10%
regression_10141 9 (-1) -10.00% 2,817 (-4) -0.14%
nested_array_in_slice 816 (-1) -0.12% 4,924 (-7) -0.14%
regression_struct_array_conditional 69 (-1) -1.43% 3,233 (-5) -0.15%
nested_array_dynamic 2,996 (-2) -0.07% 11,704 (-26) -0.22%

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: 71f637b Previous: 96fb819 Ratio
test_report_zkpassport_noir-ecdsa_ 3 s 2 s 1.50
test_report_zkpassport_noir_rsa_ 2 s 0 s +∞

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: 71f637b Previous: 96fb819 Ratio
rollup-block-root-single-tx 0.003 s 0.002 s 1.50

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

@asterite asterite requested a review from a team October 14, 2025 16:12
Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomAFrench TomAFrench added this pull request to the merge queue Oct 14, 2025
Merged via the queue into master with commit 82ec52a Oct 14, 2025
131 checks passed
@TomAFrench TomAFrench deleted the ab/acir-exact_element_type_sizes_array branch October 14, 2025 16:45
github-merge-queue bot pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Oct 15, 2025
Automated pull of nightly from the
[noir](https://github.com/noir-lang/noir) programming language, a
dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
feat(ACIR): exact element_type_sizes_array
(noir-lang/noir#10188)
chore: add unit test for keep_last_store
(noir-lang/noir#10177)
fix(ssa-interpreter): Ignore index overflow when side effects are
disabled (noir-lang/noir#10183)
fix: emit error on oracle functions with function bodies
(noir-lang/noir#10132)
chore: bump bb version (noir-lang/noir#10181)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ACIR element_type_sizes array might have an extra element

2 participants