Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v19.8.0 release proposal #47087

Merged
merged 216 commits into from
Mar 14, 2023
Merged

v19.8.0 release proposal #47087

merged 216 commits into from
Mar 14, 2023

Conversation

targos
Copy link
Member

@targos targos commented Mar 14, 2023

2023-03-14, Version 19.8.0 (Current), @targos

Notable Changes

  • [2fece54ca1] - (SEMVER-MINOR) buffer: add Buffer.copyBytesFrom(...) (James M Snell) #46500
  • [2eb887549a] - (SEMVER-MINOR) events: add listener argument to listenerCount (Paolo Insogna) #46523
  • [c1651bea41] - (SEMVER-MINOR) lib: add AsyncLocalStorage.bind() and .snapshot() (flakey5) #46387
  • [36f36b99b0] - (SEMVER-MINOR) src: add fs.openAsBlob to support File-backed Blobs (James M Snell) #45258
  • [bb9b1c637d] - (SEMVER-MINOR) tls: support automatic DHE (Tobias Nießen) #46978
  • [1e20b05acd] - (SEMVER-MINOR) url: implement URLSearchParams size getter (James M Snell) #46308
  • [60e5f45141] - (SEMVER-MINOR) wasi: add support for version when creating WASI (Michael Dawson) #46469
  • [a646a22d0f] - (SEMVER-MINOR) worker: add support for worker name in inspector and trace_events (Debadree Chatterjee) #46832
  • [bd5ef380a5] - doc: add marco-ippolito to collaborators (Marco Ippolito) #46816

Commits

  • [e11f08e2c2] - assert: fix exception message for assert(0) on try catch block (hidecology) #46760
  • [a38de61e87] - assert: remove deprecated getFunction() usage (Ruben Bridgewater) #46661
  • [e07c9b82b7] - assert,util: revert recursive breaking change (Ruben Bridgewater) #46593
  • [7f85a2cb6f] - assert,util: improve deep equal comparison performance (Ruben Bridgewater) #46593
  • [7cfd31a753] - benchmark: add a benchmark for URLSearchParams creation and toString() (Debadree Chatterjee) #46810
  • [258d5f7b3c] - benchmark: replace table in docs with description of file tree structure (Theodor Steiner) #46991
  • [0617c5e81b] - benchmark: stablize encode benchmark (Joyee Cheung) #46658
  • [04166fe2fa] - benchmark: split Buffer.byteLength benchmark (Joyee Cheung) #46616
  • [760a35144f] - benchmark: add benchmark for EventTarget add and remove (Debadree Chatterjee) #46779
  • [9890eaa23d] - benchmark: fix worker startup benchmark (Joyee Cheung) #46680
  • [86b36212f6] - benchmark: rework assert benchmarks for correctness (Ruben Bridgewater) #46593
  • [cc74821477] - bootstrap: print stack trace during environment creation failure (Joyee Cheung) #46533
  • [2fece54ca1] - (SEMVER-MINOR) buffer: add Buffer.copyBytesFrom(...) (James M Snell) #46500
  • [b3e1034660] - buffer: use v8 fast API calls for Buffer.byteLength implementation (Joyee Cheung) #46616
  • [4b3b009afd] - build: fix Visual Studio installation detection for Arm64 (Radek Bartoň) #46420
  • [d4899b2b75] - build,test: add proper support for IBM i (Xu Meng) #46739
  • [81592ff073] - child_process: add trailing commas in source files (Antoine du Hamel) #46758
  • [16bbbacba8] - cluster: add trailing commas in source files (Antoine du Hamel) #46695
  • [2b7eb56e9b] - debugger: improve validations and documents for watch and unwatch (Eungyu Lee) #46947
  • [afbd818669] - debugger: add a command to set which lines to check for context (Eungyu Lee) #46812
  • [83b529ff27] - debugger: add trailing commas in source files (Antoine du Hamel) #46714
  • [84f5a1f942] - deps: update undici to 5.21.0 (Node.js GitHub Bot) #47063
  • [fb1ac98900] - deps: update simdutf to 3.2.2 (Node.js GitHub Bot) #46841
  • [7ab7f97c4e] - deps: update uvwasi to v0.0.16 (Michael Dawson) #46434
  • [b825e2db65] - deps: update ada to 1.0.4 (Node.js GitHub Bot) #46853
  • [8b1afe3f45] - deps: update corepack to 0.17.0 (Node.js GitHub Bot) #46842
  • [151fb60b28] - deps: update simdutf to 3.2.1 (Node.js GitHub Bot) #46800
  • [92f2f1910e] - deps: upgrade npm to 9.5.1 (npm team) #46783
  • [4e18e0a43a] - deps: update ada to 1.0.3 (Node.js GitHub Bot) #46784
  • [68dde38c8e] - deps: update nghttp2 to 1.52.0 (Michaël Zasso) #46636
  • [d9069e7614] - deps: fix libuv for android (Julian Dropmann) #46746
  • [c786ed3ecc] - deps: V8: cherry-pick 90be99fab31c (Michaël Zasso) #46646
  • [fb146ee741] - deps: update simdutf to 3.2.0 (Node.js GitHub Bot) #46621
  • [adff278c47] - deps,test: update postject to 1.0.0-alpha.5 (Node.js GitHub Bot) #46934
  • [247dfb7d73] - dgram: fix unhandled exception aborting a closed udp socket (Ramana Venkata) #46770
  • [c310a32857] - doc: remove remaining SSL_OP_NETSCAPE_*_BUG (Tobias Nießen) #47066
  • [89f31a1c7f] - doc: fix typo in test.md (Victor Hiairrassary) #47053
  • [94882f579f] - doc: amend support tier qualifier (Gireesh Punathil) #42805
  • [cbdaaf6197] - doc: fix typo on esm loaders example (Ruy Adorno) #47015
  • [17d3eb02f7] - doc: add missing test runner flags to man page (Colin Ihrig) #46982
  • [5f0f1c4197] - doc: fix history information for node:diagnostics_channel (Thomas Hunter II) #46984
  • [67e20f53cd] - doc: fix myUrl is not defined in url (Youngmin Yoo) #46968
  • [f903ea502c] - doc: remove useless SSL_OP_* options (Tobias Nießen) #46954
  • [5fdd3f454f] - doc: fix description of TLS dhparam option (Tobias Nießen) #46949
  • [ba5ff15b38] - doc: improve fs code example quality (jakecastelli) #46948
  • [6f18b947be] - doc: fix port of destination server is not defined in http2 (Deokjin Kim) #46940
  • [1b555ae72d] - doc: use number which is bigger than 1024 as port in http2 (Deokjin Kim) #46938
  • [07036cf1af] - doc: add release key for Juan Arboleda (Juan José) #46922
  • [553fd5b90a] - doc: fix links to SSL_CTX_set_options (Tobias Nießen) #46953
  • [282bf29884] - doc: fix fs missing import (jakecastelli) #46907
  • [f9739a85cb] - doc: add request to hold off publicising sec releases (Michael Dawson) #46702
  • [92a61388de] - doc: fix stream iterator helpers examples (Benjamin Gruenbaum) #46897
  • [8aca3cf410] - doc: add history info for node:test (Antoine du Hamel) #46851
  • [c0b6413086] - doc: sort import order (jakecastelli) #46847
  • [9d2532e2bb] - doc: use destructing import (jakecastelli) #46847
  • [48cf9845fe] - doc: add steps about signing the binary in single-executable docs (Darshan Sen) #46764
  • [bd5ef380a5] - doc: add marco-ippolito to collaborators (Marco Ippolito) #46816
  • [60d1a4887f] - doc: document how to use the tls.DEFAULT_CIPHERS (Andreas Martens) #46482
  • [00edc50874] - doc: add document for profiling and heap snapshot (cola119) #46787
  • [fc319d6a4f] - doc: add test:coverage event to custom reporter examples (Richie McColl) #46752
  • [1b3a25ef22] - doc: include context on .toWeb() parameters (Debadree Chatterjee) #46617
  • [88057dda3b] - doc: add in security steward for recent release (Michael Dawson) #46701
  • [d627164819] - doc: clarify semver-minor notable changes approach (Beth Griggs) #46592
  • [7806cae4fa] - doc: maintaining nghttp2 (Marco Ippolito) #46539
  • [dd66c48a74] - doc: add emit to NodeEventTarget (Deokjin Kim) #46356
  • [458671daeb] - doc,test: extend the list of platforms supported by single-executables (Darshan Sen) #47026
  • [18f0398242] - esm: allow resolve to return import assertions (Geoffrey Booth) #46153
  • [5eb5be8c71] - esm: move hooks handling into separate class (Geoffrey Booth) #45869
  • [9d4d916fe8] - esm: fix import assertion warning (Antoine du Hamel) #46971
  • [2c621d6e3a] - esm: add a runtime warning when using import assertions (Antoine du Hamel) #46901
  • [1a23eab614] - events: add trailing commas in source files (Antoine du Hamel) #46759
  • [2eb887549a] - (SEMVER-MINOR) events: add listener argument to listenerCount (Paolo Insogna) #46523
  • [4c12e6eeeb] - fs: add trailing commas in source files (Antoine du Hamel) #46696
  • [774eb1995c] - http: use listenerCount when adding noop event (Paolo Insogna) #46769
  • [aac5c28091] - http: correctly calculate strict content length (Robert Nagy) #46601
  • [e08514e337] - http: fix validation of "Link" header (Steve Herzog) #46466
  • [6f9cb982a1] - http: unify header treatment (Marco Ippolito) #46528
  • [05614f8cf6] - lib: enforce use of trailing commas (Antoine du Hamel) #46881
  • [5c7fc9290e] - lib: add trailing commas to all public core modules (Antoine du Hamel) #46848
  • [08bf01593f] - lib: fix BroadcastChannel initialization location (Shelley Vohr) #46864
  • [4e1865126c] - lib: rename internal module declaration as internal bindings (okmttdhr, okp) #46663
  • [f914bfff7d] - lib: add trailing commas to more internal files (Antoine du Hamel) #46811
  • [281f176ba4] - lib: fix DOMException property descriptors after being lazy loaded (Filip Skokan) #46799
  • [1c6a92b543] - lib: update punycode to 2.3.0 (Yagiz Nizipli) #46719
  • [7b5c00aacd] - lib: add trailing commas in internal/perf (Antoine du Hamel) #46697
  • [c1651bea41] - (SEMVER-MINOR) lib: add AsyncLocalStorage.bind() and .snapshot() (flakey5) #46387
  • [345c8c343b] - lib,src: fix a few typos in comments (Tobias Nießen) #46835
  • [4219c1e893] - meta: add single-executable labels and code owners (Joyee Cheung) #47004
  • [b199acd95c] - meta: remove AUTHORS file (Rich Trott) #46845
  • [c7f056cbe2] - meta: remove unnecessary onboarding step (Rich Trott) #46793
  • [4e0b93222c] - meta: update CODEOWNERS of url implementations (Yagiz Nizipli) #46775
  • [9d63ac2724] - meta: update AUTHORS (Node.js GitHub Bot) #46726
  • [40a7b0b993] - net: fix setting of value in 'setDefaultAutoSelectFamilyAttemptTimeout' (Deokjin Kim) #47012
  • [e0d098bd21] - net: rework autoSelectFamily implementation (Paolo Insogna) #46587
  • [58b1f33bd7] - node-api: add __wasm32__ guards on async works (Chengzhong Wu) #46633
  • [e5b8597f78] - os: improve network interface performance (Ruben Bridgewater) #46598
  • [d3d76c33ea] - punycode: add pending deprecation (Antoine du Hamel) #46719
  • [56dbb15e7c] - repl: remove lastInputPreview conditional check (Duy Mac Van) #46857
  • [c7d4ff3f72] - repl: fix .load infinite loop caused by shared use of lineEnding RegExp (Theodor Steiner) #46742
  • [4f2bf8c384] - repl: add trailing commas in source files (Antoine du Hamel) #46757
  • [ed31316c2e] - src: use std::array for passing argv in node::url (Anna Henningsen) #47035
  • [815d2af34d] - src: remove TLSEXT_TYPE_alpn guard (Tobias Nießen) #46956
  • [b051ac7220] - src: remove use of SSL_OP_SINGLE_DH_USE (Tobias Nießen) #46955
  • [9e65996d16] - src: remove unused v8::Uint32Array from encoding (Yagiz Nizipli) #47003
  • [6b60f38676] - src: use AliasedUint32Array for encodeInto results (Joyee Cheung) #46658
  • [dcba3a0673] - src: move encoding bindings to a new binding (Joyee Cheung) #46658
  • [6740679965] - src: fix negative nodeTiming milestone values (Chengzhong Wu) #46588
  • [074692a6f0] - src: fix missing trailing , (Cheng Zhao) #46909
  • [32bd38fb05] - src: make util.h self-containted (Joyee Cheung) #46817
  • [0d9c345f4d] - src: remove shadowed variable in OptionsParser (Shelley Vohr) #46672
  • [578a2c53a5] - src: do not track BaseObjects directly in Realm (Joyee Cheung) #46470
  • [9fab228115] - src: fix cb scope bugs involved in termination (ywave620) #45596
  • [c0fcad3827] - src: use an array for faster binding data lookup (Joyee Cheung) #46620
  • [973287a462] - src: per-realm binding data (Chengzhong Wu) #46556
  • [ad5f42d1e9] - src: add SetFastMethodNoSideEffect() (Joyee Cheung) #46619
  • [518b890f59] - Revert "src: let http2 streams end after session close" (Rich Trott) #46721
  • [19b5d0750c] - src: use string_view for report and related code (Anna Henningsen) #46723
  • [36f36b99b0] - (SEMVER-MINOR) src: update Blob implementation to use DataQueue / File-backed Blobs (James M Snell) #45258
  • [9b6270afe2] - (SEMVER-MINOR) src: implement DataQueue (James M Snell) #45258
  • [d48ed95a66] - (SEMVER-MINOR) src, lib: fixup lint and format issues for DataQueue/Blob (James M Snell) #45258
  • [f8866812fd] - stream: enable usage of webstreams on compose() (Debadree Chatterjee) #46675
  • [4ad48d9cb9] - stream: always delay construct callback by a nextTick (Matteo Collina) #46818
  • [93e91f3dde] - stream: fix respondWithNewView() errors when view.byteOffset != 0 (Debadree Chatterjee) #46465
  • [1f386570af] - stream: fix pipeline callback not called on ended stream (Debadree Chatterjee) #46600
  • [c972612c9d] - test: fix flakyness in test-runner reporter test (Moshe Atlow) #45930
  • [11509a4a2d] - test: move test-tls-autoselectfamily-servername to test/internet (Antoine du Hamel) #47029
  • [9556d98054] - test: fallback to IPv4 if IPv6 is unavailable (Abdirahim Musse) #47017
  • [5b81689efa] - test: simplify test-tls-ecdh-multiple (Tobias Nießen) #46963
  • [c8d528e979] - test: update WPT resources, common, streams, FileAPI, broadcastchannel (Filip Skokan) #46912
  • [acfd9b8879] - test: improve test coverage of lib/dns (Anderson Paiva) #46910
  • [21153f164d] - test: simplify test-tls-ecdh-auto (Tobias Nießen) #46911
  • [e5b8896186] - test: move testPath from CWD to temporary directory (Livia Medeiros) #46890
  • [db2ace1f94] - test: assume priv ports start at 1024 if it can't be changed (KrayzeeKev) #46536
  • [0e45470fd3] - test: update web-platform tests for url (Xuguang Mei) #46860
  • [6fa142d8f8] - test: move socket from CWD to temporary directory (Livia Medeiros) #46863
  • [df155b8fd5] - test: fix os-release check for Ubuntu in SEA test (Anna Henningsen) #46838
  • [e585a11fd5] - test: fix test-net-connect-reset-until-connected (Vita Batrla) #46781
  • [f21ed3a63f] - test: simplify test-tls-alert (Tobias Nießen) #46805
  • [e5fa7a139a] - test: fix WPT title when no META title is present (Filip Skokan) #46804
  • [bd097ca4bf] - test: update encoding WPTs (Filip Skokan) #46802
  • [3ab1aabb3f] - test: remove useless WPT init scripts (Filip Skokan) #46801
  • [323415535b] - test: remove useless require('../common') from WPTs (Filip Skokan) #46796
  • [76a9634305] - test: isolate hr-time specific wpt global init (Filip Skokan) #46795
  • [3daf508993] - test: stop faking performance idlharness (Filip Skokan) #46794
  • [e52ad92b08] - test: remove unreachable return (jakecastelli) #46807
  • [9c7a2e30fb] - test: fix test-v8-collect-gc-profile-in-worker.js (theanarkh) #46735
  • [a92be13dad] - test: improve control flow in test-tls-dhe (Tobias Nießen) #46751
  • [4e9915e383] - test: include strace openat test (Rafael Gonzaga) #46150
  • [2c4f670c6b] - test: fix IPv6 checks on IBM i (Abdirahim Musse) #46546
  • [b2cfcf9cd8] - test: fix default WPT titles (Filip Skokan) #46778
  • [f4cdc6f20f] - test: remove OpenSSL 1.0.2 error message compat (Tobias Nießen) #46709
  • [d5784c79bc] - test: fix flaky test-watch-mode-files_watcher (Moshe Atlow) #46738
  • [abba45e120] - test: remove obsolete util.isDeepStrictEqual tests (Ruben Bridgewater) #46593
  • [3401315e4e] - test: use newish OpenSSL feature in test-tls-dhe (Tobias Nießen) #46708
  • [95bbd0f7d6] - test: update web-platform tests for url (Yagiz Nizipli) #46547
  • [13f14a5efa] - test,crypto: update WebCryptoAPI WPT (Filip Skokan) #47010
  • [5e31599c26] - test_runner: default to spec reporter when on TTY environment (Moshe Atlow) #46969
  • [18146fc8c1] - test_runner: handle errors not bound to tests (Colin Ihrig) #46962
  • [7960ccb61e] - test_runner: throw if harness is not bootstrapped (Colin Ihrig) #46962
  • [b832d77500] - test_runner: track bootstrapping process (Colin Ihrig) #46962
  • [debc0adcf0] - test_runner: avoid running twice tests in describe (Moshe Atlow) #46888
  • [0923cbcfe6] - test_runner: fix reconstruction of errors extracted from YAML (Moshe Atlow) #46872
  • [ecf714e1d5] - test_runner: reset count on watch mode (Moshe Atlow) #46577
  • [6d32a16319] - test_runner: bootstrap reporters before running tests (Moshe Atlow) #46737
  • [ffa86f7fa9] - test_runner: emit test-only diagnostic warning (Richie McColl) #46540
  • [3a1a7fa741] - test_runner: flatten TAP output when running using --test (Moshe Atlow) #46440
  • [069ff1cc63] - test_runner: remove root tracking set (Colin Ihrig) #46961
  • [4b7198c3cb] - test_runner: give the root test a harness reference (Colin Ihrig) #46962
  • [762dc7cb7a] - test_runner: align behavior of it and test (Moshe Atlow) #46889
  • [aa41f27d53] - test_runner: add describe.only and it.only shorthands (Richie McColl) #46604
  • [dfe529b709] - test_runner: better handle async bootstrap errors (Colin Ihrig) #46720
  • [320ddc0a0c] - test_runner: centralize CLI option handling (Colin Ihrig) #46707
  • [66016e2a29] - test_runner: display skipped tests in spec reporter output (Richie McColl) #46651
  • [25069a60c7] - timers: use V8 fast API calls (Joyee Cheung) #46579
  • [bb9b1c637d] - (SEMVER-MINOR) tls: support automatic DHE (Tobias Nießen) #46978
  • [4df008457d] - tls: add trailing commas in source files (Antoine du Hamel) #46715
  • [36c48eab31] - tools: add daily WPT Report workflow step summary (Filip Skokan) #46763
  • [12a561875b] - tools: add undici WPTs to daily WPT Report (Filip Skokan) #46763
  • [0f1ecbccca] - tools: dont use cached node versions in daily wpt (Filip Skokan) #47024
  • [2e7ba3159b] - tools: automate cares update (Marco Ippolito) #46993
  • [8723844f29] - tools: update lint-md-dependencies to [email protected] (Node.js GitHub Bot) #46935
  • [f4a59b723d] - tools: add automation for updating OpenSSL dependency (Facundo Tuesca) #45605
  • [ecce6475b9] - tools: refactor dep_updaters (Tony Gorez) #46488
  • [132fc45d16] - tools: fix daily wpt nightly version selection (Filip Skokan) #46891
  • [078600c130] - tools: update eslint to 8.35.0 (Node.js GitHub Bot) #46854
  • [724f9d61a3] - tools: create llhttp update action (Marco Ippolito) #46766
  • [f558797744] - tools: fix linter message when using global DOMException (Antoine du Hamel) #46822
  • [f4cbe4ea4b] - tools: update lint-md-dependencies to [email protected] (Node.js GitHub Bot) #46843
  • [4b91420307] - tools: upload daily WPT Report to both staging and production (Filip Skokan) #46803
  • [2f09d3f9a1] - tools: update lint-md-dependencies to [email protected] (Node.js GitHub Bot) #46771
  • [f6bd145768] - tools: run format-cpp on node-api test c files (Chengzhong Wu) #46694
  • [694659cecb] - tools: cleanup WPT refs in daily-wpt-fyi.yml (Filip Skokan) #46740
  • [1756830e36] - tools: use actions pinned by commit hash in coverage-linux (Gabriela Gutierrez) #46294
  • [25ccaa7b3a] - tools: fix regex strings in Python tools (Jan Osusky) #46671
  • [dd400341ad] - tools: fixed path (Marco Ippolito) #46700
  • [a560a78962] - tools: update nghttp2 action (Marco Ippolito) #46700
  • [2ff9b20c3c] - tools: update-nghttp2 preserve config.h (Marco Ippolito) #46698
  • [6ff0b801f1] - tools: update lint-md-dependencies to [email protected] (Node.js GitHub Bot) #46712
  • [b7e027af4d] - tools: update lint-md-dependencies to [email protected] (Node.js GitHub Bot) #46712
  • [617b5b106a] - tools: update wpt.fyi used daily checkout ref (Filip Skokan) #46730
  • [63a83b4451] - typings: improve primordials typings (Antoine du Hamel) #46970
  • [1fa6352853] - url: offload URLSearchParams initialization (Yagiz Nizipli) #46867
  • [e754277a44] - url: fix array overrun in node:url::SetArgs() (Yagiz Nizipli) #47001
  • [b1747feb57] - url: set formatUrl method as no side effect (Yagiz Nizipli) #46884
  • [b8560ec8cc] - url: remove unnecessary call to FunctionPrototypeBind (Antoine du Hamel) #46870
  • [f8765be197] - url: remove unused kFormat from url (Yagiz Nizipli) #46867
  • [b10fe5856b] - url: improve isURLThis detection (Yagiz Nizipli) #46866
  • [1e20b05acd] - (SEMVER-MINOR) url: implement URLSearchParams size getter (James M Snell) #46308
  • [5a3ad8763b] - url: simplify and improve url formatting (Yagiz Nizipli) #46736
  • [a52405599c] - url: improve performance by removing host (Yagiz Nizipli) #46547
  • [9d55a5e5bb] - url: fix url spec compliance issues (Yagiz Nizipli) #46547
  • [77b4aca2cc] - vm: fix leak in vm.compileFunction when importModuleDynamically is used (Joyee Cheung) #46785
  • [b2a80d788a] - wasi: add wasi sock_accept stub (Michael Dawson) #46434
  • [60e5f45141] - (SEMVER-MINOR) wasi: add support for version when creating WASI (Michael Dawson) #46469
  • [a646a22d0f] - (SEMVER-MINOR) worker: add support for worker name in inspector and trace_events (Debadree Chatterjee) #46832

richiemccoll and others added 30 commits March 13, 2023 10:47
PR-URL: #46547
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Co-authored-by: Daniel Lemire <[email protected]>
PR-URL: #46547
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
PR-URL: #46547
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
PR-URL: #46621
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Fixes: #46595
PR-URL: #46600
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #46730
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #46387
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
See documentation in dataqueue/queue.h for details

Co-authored-by: flakey5 <[email protected]>
PR-URL: #45258
Reviewed-By: Matteo Collina <[email protected]>
PR-URL: #46695
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #46696
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #46697
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This reduces the overhead of getCIDR() to a minimum. No array is
allocated anymore and parts are directly sliced out of the netmask
string instead.

Signed-off-by: Ruben Bridgewater <[email protected]>
PR-URL: #46598
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
The test runner relies on a few CLI options. That code was spread
across a few locations. This commit centralizes that logic.

PR-URL: #46707
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
According to the comment that is being replaced here, this was not
possible with the current version of OpenSSL 1.0.2 at the time the test
was written. New OpenSSL versions appear to always print the length of
the temporary key.

Refs: nodejs/node-v0.x-archive#8272
PR-URL: #46708
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #46712
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
PR-URL: #46712
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
The method is meant to be removed by the V8 team. It is not a
critical functionality that is removed, therefore no alternative
is checked for either.

Refs: https://bugs.chromium.org/p/v8/issues/detail?id=9421

Signed-off-by: Ruben Bridgewater <[email protected]>
PR-URL: #46661
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Original commit message:

    [intl] Revert date formatting behavior change from ICU 72

    Replace U+202F with U+0020 after formatting date. This lets websites
    continue to work without any changes.

    This matches Firefox behavior, according to
    https://bugzilla.mozilla.org/show_bug.cgi?id=1806042#c17.

    Bug: chromium:1414292, chromium:1401829, chromium:1392814
    Change-Id: I7c2b58414d0890f8705e737f903403dc54e5fe57
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4237675
    Commit-Queue: Adam Klein <[email protected]>
    Reviewed-by: Shu-yu Guo <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#85757}

Refs: v8/v8@90be99f
PR-URL: #46646
Refs: #46123
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
This reworks most assert benchmarks to provide more reliable test
cases that also test more cases than before while keeping the
runtime low.

Signed-off-by: Ruben Bridgewater <[email protected]>
PR-URL: #46593
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
These tests are a copy of the assert tests that verify the
deep equal comparison algorithm. There is no need to duplicate the
tests as changing one would require to change the tests in two
places without knowing which ones to actually rely upon.

Signed-off-by: Ruben Bridgewater <[email protected]>
PR-URL: #46593
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
This is mainly a performance improvement for a lot of simple cases.
Diverging elements are detected earlier and equal entries are
partially also detected faster.

A small correctness patch is also included where recursions now
stop as soon as either side has a circular structure. Before, both
sides had to have a circular structure at the specific comparison
which could have caused more checks that likely fail at a later
point.

Signed-off-by: Ruben Bridgewater <[email protected]>
PR-URL: #46593
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
This commit is there to be reverted after merging. It makes it easy
to backport the overall PR and allows easy forward fixing.

Signed-off-by: Ruben Bridgewater <[email protected]>
PR-URL: #46593
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
NodeEventTarget.emit() is not described in document. Plus, make
type parameter of removeAllListeners as optional.

Refs: #35851
PR-URL: #46356
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Use `std::string_view` for process.report code and related
code, drop a few unnecessary `std::to_string` calls,
and use `MaybeStackBuffer` instead of `MallocedBuffer`,
all in order to avoid unnecessary heap allocations.

PR-URL: #46723
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
PR-URL: #46523
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
PR-URL: #46528
Fixes: #46395
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
PR-URL: #46738
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. v19.x labels Mar 14, 2023
@targos targos removed doc Issues and PRs related to the documentations. build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. labels Mar 14, 2023
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as duplicate.

@nodejs-github-bot

This comment was marked as duplicate.

@nodejs-github-bot

This comment was marked as duplicate.

@targos
Copy link
Member Author

targos commented Mar 14, 2023

@nodejs/releasers have I missed something with the list of commits? I used git node release --prepare as usual but the generated format is not like the other releases.

Notable changes:

buffer:
  * (SEMVER-MINOR) add Buffer.copyBytesFrom(...) (James M Snell) #46500
doc:
  * add marco-ippolito to collaborators (Marco Ippolito) #46816
events:
  * (SEMVER-MINOR) add listener argument to listenerCount (Paolo Insogna) #46523
lib:
  * (SEMVER-MINOR) add AsyncLocalStorage.bind() and .snapshot() (flakey5) #46387
src:
  * (SEMVER-MINOR) add `fs.openAsBlob` to support File-backed Blobs (James M Snell) #45258
tls:
  * (SEMVER-MINOR) support automatic DHE (Tobias Nießen) #46978
url:
  * (SEMVER-MINOR) implement URLSearchParams size getter (James M Snell) #46308
wasi:
  * (SEMVER-MINOR) add support for version when creating WASI (Michael Dawson) #46469
worker:
  * (SEMVER-MINOR) add support for worker name in inspector and trace_events (Debadree Chatterjee) #46832

PR-URL: #47087
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 14, 2023

@targos
Copy link
Member Author

targos commented Mar 14, 2023

I don't see anything obvious in CITGM but it's too red to reasonably be able to assess correctly.

@targos
Copy link
Member Author

targos commented Mar 14, 2023

@nodejs/releasers can someone please review?

@targos targos merged commit 4221dce into v19.x Mar 14, 2023
@targos targos deleted the v19.8.0-proposal branch March 14, 2023 18:49
targos added a commit that referenced this pull request Mar 14, 2023
targos added a commit that referenced this pull request Mar 14, 2023
Notable changes:

buffer:
  * (SEMVER-MINOR) add Buffer.copyBytesFrom(...) (James M Snell) #46500
doc:
  * add marco-ippolito to collaborators (Marco Ippolito) #46816
events:
  * (SEMVER-MINOR) add listener argument to listenerCount (Paolo Insogna) #46523
lib:
  * (SEMVER-MINOR) add AsyncLocalStorage.bind() and .snapshot() (flakey5) #46387
src:
  * (SEMVER-MINOR) add `fs.openAsBlob` to support File-backed Blobs (James M Snell) #45258
tls:
  * (SEMVER-MINOR) support automatic DHE (Tobias Nießen) #46978
url:
  * (SEMVER-MINOR) implement URLSearchParams size getter (James M Snell) #46308
wasi:
  * (SEMVER-MINOR) add support for version when creating WASI (Michael Dawson) #46469
worker:
  * (SEMVER-MINOR) add support for worker name in inspector and trace_events (Debadree Chatterjee) #46832

PR-URL: #47087
targos added a commit to targos/nodejs.org that referenced this pull request Mar 14, 2023
targos added a commit to nodejs/nodejs.org that referenced this pull request Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Issues and PRs related to Node.js releases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.