-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update nghttp2 to 1.52.0 #46636
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
nodejs-github-bot
added
http2
Issues or PRs related to the http2 subsystem.
needs-ci
PRs that need a full CI run.
labels
Feb 13, 2023
cjihrig
approved these changes
Feb 13, 2023
aduh95
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Feb 13, 2023
VoltrexKeyva
approved these changes
Feb 13, 2023
RafaelGSS
approved these changes
Feb 15, 2023
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Feb 16, 2023
I left a comment here about Line 15 in a2bbe5f
|
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Feb 21, 2023
34 tasks
the update now works automatically #46773 🎉 |
mcollina
added
commit-queue
Add this label to land a pull request using GitHub Actions.
and removed
needs-ci
PRs that need a full CI run.
labels
Feb 22, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Feb 22, 2023
Landed in 1aed454 |
31 tasks
targos
added a commit
that referenced
this pull request
Mar 13, 2023
Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.52.0 PR-URL: #46636 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.52.0 PR-URL: #46636 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
http2
Issues or PRs related to the http2 subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.52.0
Note that #45572 is still relevant.
I don't know if
config.h
is a generated file. I just reverted its removal.