debugger: improve validations and documents for watch and unwatch #46947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
debugger
cola119
changed the title
cola119
approved these changes
Mar 5, 2023
github-actions
bot
removed
the
request-ci
cola119
added
author ready
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/46947 ✔ Done loading data for nodejs/node/pull/46947 ----------------------------------- PR info ------------------------------------ Title debugger: Add string validation for watch, add information on unwatch(index) command (#46947) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch Dailyscat:add-string-validation-for-watch -> nodejs:main Labels author ready, needs-ci, debugger, commit-queue-squash Commits 4 - debugger: add string validation for watch(expr) - debugger: add help document for watch(index) - test: add test for watch(index) command - doc: add information on unwatch(index) option Committers 1 - eungyu.lee PR-URL: https://github.com/nodejs/node/pull/46947 Reviewed-By: Kohei Ueno ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/46947 Reviewed-By: Kohei Ueno -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 04 Mar 2023 10:43:28 GMT ✔ Approvals: 1 ✔ - Kohei Ueno (@cola119): https://github.com/nodejs/node/pull/46947#pullrequestreview-1325303593 ✖ This PR needs to wait 97 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-03-05T23:52:56Z: https://ci.nodejs.org/job/node-test-pull-request/50217/ - Querying data for job/node-test-pull-request/50217/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4352354485 |
cola119
removed
the
commit-queue-failed
|
@Dailyscat Can you squash all commits and update the initial commit message to a more relevant one? |
Dailyscat
force-pushed
the
add-string-validation-for-watch
branch
from
f52a538
to
4b84bc5
Compare
Dailyscat
force-pushed
the
add-string-validation-for-watch
branch
from
4b84bc5
to
b32bffd
Compare
github-actions
bot
removed
the
request-ci
- debugger: add string validation for watch(expr) - debugger: add help document for watch(index) - test: add test for watch(index) command - doc: add information on unwatch(index) option
Dailyscat
force-pushed
the
add-string-validation-for-watch
branch
from
b32bffd
to
28de121
Compare
22 tasks
github-actions
bot
removed
the
request-ci
20 tasks
cola119
changed the title
20 tasks
cola119
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/46947 ✔ Done loading data for nodejs/node/pull/46947 ----------------------------------- PR info ------------------------------------ Title debugger: improve validations and documents for watch and unwatch (#46947) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch Dailyscat:add-string-validation-for-watch -> nodejs:main Labels author ready, needs-ci, debugger Commits 1 - debugger: improve validations and documents for watch and unwatch Committers 1 - eungyu.lee PR-URL: https://github.com/nodejs/node/pull/46947 Reviewed-By: Kohei Ueno ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/46947 Reviewed-By: Kohei Ueno -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - debugger: improve validations and documents for watch and unwatch ℹ This PR was created on Sat, 04 Mar 2023 10:43:28 GMT ✔ Approvals: 1 ✔ - Kohei Ueno (@cola119): https://github.com/nodejs/node/pull/46947#pullrequestreview-1325303593 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-03-13T02:22:26Z: https://ci.nodejs.org/job/node-test-pull-request/50343/ - Querying data for job/node-test-pull-request/50343/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4401209251 |
cola119
approved these changes
Mar 13, 2023
cola119
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in f8bf498 |
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
- debugger: add string validation for watch(expr) - debugger: add help document for watch(index) - test: add test for watch(index) command - doc: add information on unwatch(index) option PR-URL: #46947 Reviewed-By: Kohei Ueno <[email protected]>
24 tasks
targos
pushed a commit
that referenced
this pull request
Mar 14, 2023
- debugger: add string validation for watch(expr) - debugger: add help document for watch(index) - test: add test for watch(index) command - doc: add information on unwatch(index) option PR-URL: #46947 Reviewed-By: Kohei Ueno <[email protected]>
This was referenced Mar 15, 2023
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
- debugger: add string validation for watch(expr) - debugger: add help document for watch(index) - test: add test for watch(index) command - doc: add information on unwatch(index) option PR-URL: #46947 Reviewed-By: Kohei Ueno <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#42882
#42913
I combined what was reflected in each PR.