Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v16.10.0 proposal #40175

Merged
merged 95 commits into from
Sep 22, 2021
Merged

v16.10.0 proposal #40175

merged 95 commits into from
Sep 22, 2021

Conversation

BethGriggs
Copy link
Member

@BethGriggs BethGriggs commented Sep 21, 2021

  • Update notable changes

2021-09-22, Version 16.10.0 (Current), @BethGriggs

Notable Changes

  • [fb226ff2ee] - (SEMVER-MINOR) crypto: add rsa-pss keygen parameters (Filip Skokan) #39927
  • [85206b7311] - deps: upgrade npm to 7.24.0 (npm team) #40167
  • [98f56d179c] - deps: update Acorn to v8.5.0 (Michaël Zasso) #40015
  • [9655329772] - doc: add Ayase-252 to collaborators (Qingyu Deng) #40078
  • [59fff925be] - (SEMVER-MINOR) fs: make open and close stream override optional when unused (Antoine du Hamel) #40013
  • [a63a4bce90] - (SEMVER-MINOR) http: limit requests per connection (Artur K) #40082
    • The maximum number of requests a socket can handle before closing keep alive connection can be set with server.maxRequestsPerSocket.
  • [9a672961fa] - (SEMVER-MINOR) src: add --no-global-search-paths cli option (Cheng Zhao) #39754
    • Adds the --no-global-search-paths command-line option to not search modules from global paths like $HOME/.node_modules and $NODE_PATH.
  • [fe920b6cbf] - (SEMVER-MINOR) src: make napi_create_reference accept symbol (JckXia) #39926
  • [97f3072ceb] - (SEMVER-MINOR) stream: add signal support to pipeline generators (Robert Nagy) #39067

Commits

  • [b7dc651884] - build: run modified internet tests on GitHub Actions (Rich Trott) #40100
  • [8d5787a043] - build: add .mailmap/AUTHORS to paths-ignore for test-macos (Rich Trott) #40109
  • [9793e7ff08] - build: add .mailmap/AUTHORS to path-ignore for test-asan (Rich Trott) #40109
  • [886921de38] - build: add paths-ignore for build-tarball workflow (Rich Trott) #40109
  • [01b1946b38] - build: only lint version numbers for pull requests (Michaël Zasso) #40027
  • [c804d070a6] - build: add daily/on-demand internet test workflow (Rich Trott) #40086
  • [7bddaecbf4] - build: add YAML linting to GitHub Actions (Rich Trott) #40007
  • [5a20f9055c] - build: add YAML linting (Rich Trott) #40007
  • [0b30867c08] - build: run AUTHORS update weekly (Rich Trott) #40004
  • [22a78a75ee] - build: preserves symbols during LTO with macOS linker (Jesse Chan) #39839
  • [f0dec58d43] - crypto: fix webcrypto ed(25519|448) spki/pkcs8 import (Filip Skokan) #40131
  • [d80082f3eb] - crypto: use validateObject (Voltrex) #39872
  • [d657ae6f8a] - crypto: fix RSA-PSS default saltLength (Tobias Nießen) #39999
  • [fc45cbe7a8] - crypto: fix default MGF1 hash for OpenSSL 3 (Tobias Nießen) #40031
  • [105c9e6d3b] - crypto: check webcrypto asymmetric key types during importKey (Filip Skokan) #39962
  • [fb226ff2ee] - (SEMVER-MINOR) crypto: add rsa-pss keygen parameters (Filip Skokan) #39927
  • [85206b7311] - deps: upgrade npm to 7.24.0 (npm team) #40167
  • [06f6e01f37] - deps: add riscv64 into openssl Makefile and gen openssl-riscv64 (Lu Yahan) #40063
  • [9c76c69972] - deps: patch V8 to 9.3.345.19 (Michaël Zasso) #40108
  • [0df47d5843] - deps: upgrade npm to 7.23.0 (npm team) #40055
  • [b3843bf417] - deps: patch v8 for vs2019 in std17 (Jiawen Geng) #40060
  • [67759585a0] - deps: patch for v8 on windows (Jiawen Geng) #40010
  • [98f56d179c] - deps: update Acorn to v8.5.0 (Michaël Zasso) #40015
  • [5c6708582e] - dns: cleanup validation (Voltrex) #40061
  • [e4825dcfd5] - doc: changes default values for fs.read fns (RISHABH BUDHIRAJA) #39163
  • [0254b4b0d3] - doc: fix markdown indentation in lists (Michaël Zasso) #40142
  • [b6939a3419] - doc: prepare README.md for stricter linting (Rich Trott) #40137
  • [a07d8444f9] - doc: fix comma splice (Rich Trott) #40133
  • [2488bc0c4f] - doc: clean up weird notes about reentrancy (Anna Henningsen) #40107
  • [8b80dcbc30] - doc: correct parameters in fs and stream documentation (vipul kumar) #39984
  • [1ced732078] - doc: fix CJS-ESM selector in Safari (Bradley Farias) #40135
  • [7fdb12739d] - doc: add timeout.close (Nikita Galkin) #40036
  • [81cb14bb58] - doc: clarify that ObjectWrap requires manual cleanup on shutdown (Gerhard Stöbich) #40074
  • [8aad81dd99] - doc: add full list of subsystems (FrankQiu) #39971
  • [9655329772] - doc: add Ayase-252 to collaborators (Qingyu Deng) #40078
  • [6d399e11e9] - doc: fix CCM cipher example in MJS (Tobias Nießen) #39949
  • [d426ee9b17] - doc: fix property name 'detail' of performanceEntry (Christian Boehlke) #40019
  • [846e7e880e] - doc: fix list indentation in corepack.md (Alexey Ten) #40029
  • [b6dd2ea930] - doc: fix missing history version in fs.md (Antoine du Hamel) #39972
  • [f666f5a8d1] - events: fix duplicate require which cause performance penalty (wwwzbwcom) #39892
  • [59fff925be] - (SEMVER-MINOR) fs: make open and close stream override optional when unused (Antoine du Hamel) #40013
  • [a63a4bce90] - (SEMVER-MINOR) http: limit requests per connection (Artur K) #40082
  • [bc9c2ca6af] - http: remove CRLF variable (shfshanyue) #40101
  • [dd50b91f77] - lib: remove useless statement (Maledong) #39983
  • [608528028c] - lib: avoid creating a throw away object in validateObject (Antoine du Hamel) #39807
  • [edcfffeaea] - lib: use standard property names (null) #39981
  • [640353af86] - lib,repl: ignore non-canBeRequiredByUsers built-in (Khaidi Chu) #39942
  • [4444b5c938] - meta: update AUTHORS (Node.js GitHub Bot) #40148
  • [4993318862] - meta: update GeoffreyBooth email addresses in AUTHORS and .mailmap (Rich Trott) #40132
  • [98d42fa1f4] - meta: add mailmap entry for LPardue (Rich Trott) #40129
  • [effdfa91be] - meta: update GeoffreyBooth email address (Geoffrey Booth) #40102
  • [588257c00a] - meta: add .mailmap entry for arcanis (Rich Trott) #40103
  • [7ee3fbd1e0] - meta: update AUTHORS (Node.js GitHub Bot) #40087
  • [2a41530a5e] - meta: consolidate AUTHORS entry for mikemaccana (Rich Trott) #40051
  • [a71579b05e] - meta: add more mailmap entries for bajtos (Rich Trott) #40023
  • [29104f5e64] - meta: consolidate AUTHORS entries for mithunsasidharan (Rich Trott) #40003
  • [381293f54a] - meta: update AUTHORS (Node.js GitHub Bot) #39957
  • [1eca9bc5b2] - module: support pattern trailers for imports field (Guy Bedford) #40041
  • [7376edca6d] - module: deprecate trailing slash pattern mappings (Guy Bedford) #40039
  • [92f182b23d] - module: fix $ pattern replacements (Guy Bedford) #40044
  • [d6124d8259] - repl: fix top level await with surrogate characters (Mestery) #39931
  • [9a672961fa] - (SEMVER-MINOR) src: add --no-global-search-paths cli option (Cheng Zhao) #39754
  • [51f9ad4897] - (SEMVER-MINOR) src: add option to disable global search paths (Cheng Zhao) #39754
  • [95528b284d] - src: remove unnecessary comment and add a CHECK in crypto_tls.cc (Darshan Sen) #39991
  • [31994fbf8e] - src: register zlib external references for snapshot (Joyee Cheung) #40050
  • [cfcd57182b] - src: fix -Wunreachable-code-return error (Shelley Vohr) #40034
  • [9f3a015b60] - src: add option to disable loading native addons (Dominic Elm) #39977
  • [570bef1710] - Revert "src: skip test_fatal/test_threads for Debug builds" (Anna Henningsen) #39954
  • [842f936e04] - src: use Isolate::TryGetCurrent where appropriate (Anna Henningsen) #39954
  • [fe920b6cbf] - (SEMVER-MINOR) src: make napi_create_reference accept symbol (JckXia) #39926
  • [73aa4e34ff] - src: fix C4805 MSVC warning (Michaël Zasso) #39998
  • [826eee363c] - src: register external references of PipeWrap for snapshot (Joyee Cheung) #39961
  • [7a17cbfdea] - src: register external references of TTYWrap for snapshot (Joyee Cheung) #39961
  • [00cca48081] - src: register external references of TCPWrap for snapshot (Joyee Cheung) #39961
  • [6095fb07b6] - src: register external references of SignalWrap for snapshot (Joyee Cheung) #39961
  • [db75711c5c] - src: register missing process methods external references (Joyee Cheung) #39961
  • [b4e074c295] - src: register missing stream wrap external references (Joyee Cheung) #39961
  • [a2c1c3ef64] - src: register external references of BaseObject for snapshot (Joyee Cheung) #39961
  • [6fdf02523e] - src: register external references of node-report for snapshot (Joyee Cheung) #39961
  • [bef78a2f88] - src: register external references of dtrace for snapshot (Joyee Cheung) #39961
  • [97f3072ceb] - (SEMVER-MINOR) stream: add signal support to pipeline generators (Robert Nagy) #39067
  • [6be405bd7b] - test: fix test-dgram-udp6-link-local-address on Windows (Michaël Zasso) #40005
  • [ec94bec9a3] - test: do not run test-corepack-yarn-install with no internet (Antoine du Hamel) #40090
  • [4aa2610252] - test: update OpenSSL3 error messages for 3.0.0+quic (Daniel Bevenius) #40093
  • [4367a61a9b] - test: mark test-crypto-timing-safe-equal-benchmarks flaky (Richard Lau) #40065
  • [5b5e27281c] - test: fix internet/test-dns (Rich Trott) #40083
  • [67bbfeb7e1] - test: make tests pass on Windows with Unix EOL (Michaël Zasso) #40002
  • [a8c99d9f09] - tools: update doc generator dependencies (Michaël Zasso) #40042
  • [ec6de1195a] - tools: update ansi-regex in lint-md rollup (Rich Trott) #40112
  • [d55804ca4e] - tools: update all dependencies of markdown linter (Michaël Zasso) #40035
  • [f03bae7c82] - tools: update remark-html to v13.0.2 (Michaël Zasso) #40043
  • [99af21292f] - tools,build: update YAML files in preparation for linting (Rich Trott) #40007
  • [590ace418d] - tools,doc: fix misrendering of consecutive JS blocks (Rich Trott) #40146
  • [5983568204] - worker: avoid potential deadlock on NearHeapLimit (Santiago Gimeno) #38403

ronag and others added 30 commits September 10, 2021 20:34
Generators in pipeline must be able to be aborted or pipeline
can deadlock.

PR-URL: #39067
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
man ld -export_dynamic:

```
Preserves all global symbols in main executables during LTO.

Without this option, Link Time Optimization is allowed to inline
and remove global functions.

This option is used when a main executable may load a plug-in which
requires certain symbols from the main executable.
```

Bug: vercel/pkg#1155
Signed-off-by: Jesse Chan <[email protected]>

PR-URL: #39839
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #39957
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #39961
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #39961
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #39961
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #39961
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #39961
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #39961
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #39961
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #39961
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #39961
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Refs: #33716
Refs: #35993
Refs: #35911

PR-URL: #39972
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
PR-URL: #40003
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
e.g. `wasi` under no `--experimental-wasi-unstable-preview1` flag
shouldn't be pre-required.

PR-URL: #39942
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
'==' : unsafe mix of type 'bool' and type 'int' in operation

PR-URL: #39998
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
It is possible on Windows to configure Git to checkout line-endings
"as-is", which for Node.js means Unix-style.
This change makes the tests that rely on line endings pass in that case.

PR-URL: #40002
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #40004
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Fix indentation, traiiling spaces, and missing newline issues in
preparation for linting.

PR-URL: #40007
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
PR-URL: #40007
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
PR-URL: #40007
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
PR-URL: #40029
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #39926
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #40015
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
In two places, we call `Isolate::GetCurrent()` even though that is
technically invalid usage of the function.
Now that V8 exposes `Isolate::TryGetCurrent()`, we can do this
in a proper way.

PR-URL: #39954
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
This reverts commit 1fc4d43.

PR-URL: #39954
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #40019
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
The standard property names that aren't strings can be used where
appropiate, this is one of them.

PR-URL: #39981
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@nodejs-github-bot
Copy link
Collaborator

@mcollina
Copy link
Member

mcollina commented Sep 22, 2021

pino is just a coverage check. I will adjust the build.

[email protected] is out with a fix.

@nodejs-github-bot
Copy link
Collaborator

@wraithgar
Copy link

Those Error: Failure getting project from npm failures are tests that will never pass with npm@7 and beyond. See nodejs/citgm#872 for more info.

@nodejs-github-bot
Copy link
Collaborator

@BethGriggs
Copy link
Member Author

fedora-last-latest-x64 CIs are failing - it's not obvious yet if it's a regression or a intermittent memory or Jenkins issue.

16:20:33 FATAL: command execution failed
16:20:33 java.nio.channels.ClosedChannelException
16:20:33 	at org.jenkinsci.remoting.protocol.NetworkLayer.onRecvClosed(NetworkLayer.java:154)
16:20:33 	at org.jenkinsci.remoting.protocol.impl.NIONetworkLayer.ready(NIONetworkLayer.java:179)
16:20:33 	at org.jenkinsci.remoting.protocol.IOHub$OnReady.run(IOHub.java:792)
16:20:33 	at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)
16:20:33 	at jenkins.security.ImpersonatingExecutorService$1.run(ImpersonatingExecutorService.java:68)
16:20:33 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
16:20:33 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
16:20:33 	at java.lang.Thread.run(Thread.java:748)
16:20:33 Caused: java.io.IOException: Backing channel 'JNLP4-connect connection is disconnected.

Trying a run on v16.9.1 - https://ci.nodejs.org/job/node-test-commit-linux/nodes=fedora-last-latest-x64/43050/

@nodejs-github-bot
Copy link
Collaborator

@richardlau
Copy link
Member

I have rebooted both fedora-last-latest hosts and resumed again.

PR-URL needs to be updated in the release commit message.

Notable changes:

crypto:
  * (SEMVER-MINOR) add rsa-pss keygen parameters (Filip Skokan) #39927
doc:
  * add Ayase-252 to collaborators (Qingyu Deng) #40078
fs:
  * (SEMVER-MINOR) make `open` and `close` stream override optional when unused (Antoine du Hamel) #40013
http:
  * (SEMVER-MINOR) limit requests per connection (Artur K) #40082
src:
  * (SEMVER-MINOR) add --no-global-search-paths cli option (Cheng Zhao) #39754
  * (SEMVER-MINOR) add option to disable global search paths (Cheng Zhao) #39754
  * (SEMVER-MINOR) make napi_create_reference accept symbol (JckXia) #39926
stream:
  * (SEMVER-MINOR) add signal support to pipeline generators (Robert Nagy) #39067

PR-URL: #40175
@BethGriggs
Copy link
Member Author

@BethGriggs BethGriggs merged commit aff2a0a into v16.x Sep 22, 2021
BethGriggs added a commit that referenced this pull request Sep 22, 2021
BethGriggs added a commit that referenced this pull request Sep 22, 2021
Notable changes:

crypto:
  * (SEMVER-MINOR) add rsa-pss keygen parameters (Filip Skokan) #39927
doc:
  * add Ayase-252 to collaborators (Qingyu Deng) #40078
fs:
  * (SEMVER-MINOR) make `open` and `close` stream override optional when unused (Antoine du Hamel) #40013
http:
  * (SEMVER-MINOR) limit requests per connection (Artur K) #40082
src:
  * (SEMVER-MINOR) add --no-global-search-paths cli option (Cheng Zhao) #39754
  * (SEMVER-MINOR) add option to disable global search paths (Cheng Zhao) #39754
  * (SEMVER-MINOR) make napi_create_reference accept symbol (JckXia) #39926
stream:
  * (SEMVER-MINOR) add signal support to pipeline generators (Robert Nagy) #39067

PR-URL: #40175
BethGriggs added a commit to BethGriggs/nodejs.org that referenced this pull request Sep 22, 2021
BethGriggs added a commit to nodejs/nodejs.org that referenced this pull request Sep 22, 2021
@BethGriggs BethGriggs deleted the v16.10.0-proposal branch September 23, 2021 12:17
@targos targos removed the wip Issues and PRs that are still a work in progress. label Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Issues and PRs related to Node.js releases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.