Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: check webcrypto asymmetric key types during importKey #39962

Closed
wants to merge 1 commit into from
Closed

crypto: check webcrypto asymmetric key types during importKey #39962

wants to merge 1 commit into from

Conversation

panva
Copy link
Member

@panva panva commented Aug 31, 2021

This PR fixes an issue where any KeyObject.prototype.type matching key would result in a CryptoKey despite it being the wrong KeyObject.prototype.asymmetricKeyType

@panva panva requested a review from jasnell August 31, 2021 17:50
@panva
Copy link
Member Author

panva commented Aug 31, 2021

cc @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Aug 31, 2021
@panva panva mentioned this pull request Aug 31, 2021
Closed
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@panva panva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Aug 31, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 1, 2021 •
edited by panva
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/39729/ 💚

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 7, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 7, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2021

Landed in 0c6f345...5d34ef5

@github-actions github-actions bot closed this Sep 7, 2021
nodejs-github-bot pushed a commit that referenced this pull request Sep 7, 2021
@panva @nodejs-github-bot
crypto: check webcrypto asymmetric key types during importKey
5d34ef5 
PR-URL: #39962
Reviewed-By: James M Snell <[email protected]>
@panva panva deleted the webcrypto-check-import-key-type branch September 7, 2021 18:34
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@panva @BethGriggs
crypto: check webcrypto asymmetric key types during importKey
105c9e6 
PR-URL: #39962
Reviewed-By: James M Snell <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Sep 21, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@tniessen tniessen Awaiting requested review from tniessen

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. webcrypto
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@panva @nodejs-github-bot @jasnell