Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: update AUTHORS #40087

Closed
wants to merge 1 commit into from
Closed

Conversation

nodejs-github-bot
Copy link
Collaborator

If this PR exists, there's presumably new additions to the AUTHORS file. This is an automatically generated PR by the authors.yml GitHub Action, which runs tools/update-authors.js and submits a new PR or updates an existing PR.

Please note that there might be duplicate entries. If there are, please remove them and add the duplicate emails to .mailmap directly to this PR.

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Sep 12, 2021
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be two entries that do not points to real user information, should we remove those?

AUTHORS Show resolved Hide resolved
AUTHORS Show resolved Hide resolved
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 13, 2021
@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 14, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 14, 2021
@github-actions
Copy link
Contributor

Commit Queue failed
- Loading data for nodejs/node/pull/40087
✔  Done loading data for nodejs/node/pull/40087
----------------------------------- PR info ------------------------------------
Title      meta: update AUTHORS (#40087)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     nodejs-github-bot:actions/authors-update -> nodejs:master
Labels     meta, author ready
Commits    1
 - meta: update AUTHORS
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/40087
Reviewed-By: Rich Trott 
Reviewed-By: Michaël Zasso 
Reviewed-By: Antoine du Hamel 
Reviewed-By: James M Snell 
Reviewed-By: Tobias Nießen 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/40087
Reviewed-By: Rich Trott 
Reviewed-By: Michaël Zasso 
Reviewed-By: Antoine du Hamel 
Reviewed-By: James M Snell 
Reviewed-By: Tobias Nießen 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 12 Sep 2021 00:13:57 GMT
   ✔  Approvals: 6
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/40087#pullrequestreview-752227983
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/40087#pullrequestreview-752380264
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/40087#pullrequestreview-752410279
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/40087#pullrequestreview-752781492
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/40087#pullrequestreview-753027081
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/40087#pullrequestreview-753099880
   ✖  GitHub CI is still running
   ℹ  Green GitHub Actions CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1232170175

@github-actions github-actions bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Sep 14, 2021
PR-URL: #40087
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@Trott
Copy link
Member

Trott commented Sep 14, 2021

Landed in fa7c477

@Trott Trott closed this Sep 14, 2021
@Trott Trott deleted the actions/authors-update branch September 14, 2021 03:59
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
PR-URL: #40087
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
PR-URL: #40087
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Sep 21, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants