Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix -Wunreachable-code-return error #40034

Closed
wants to merge 1 commit into from
Closed

src: fix -Wunreachable-code-return error #40034

wants to merge 1 commit into from

Conversation

codebytere
Copy link
Member

Resolves a -Wunreachable-code-return compilation error encountered in Electron surfaced during a recent Chromium roll.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Sep 8, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39871/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39905/

@codebytere
Copy link
Member Author

Landed in f8836b2

@codebytere codebytere closed this Sep 11, 2021
codebytere added a commit that referenced this pull request Sep 11, 2021
@codebytere
src: fix -Wunreachable-code-return error
f8836b2 
PR-URL: #40034
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@codebytere codebytere deleted the unreachable-code-error branch September 11, 2021 07:56
This was referenced Sep 14, 2021
Open
Open
Open
Open
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@codebytere @BethGriggs
src: fix -Wunreachable-code-return error
b5d22cc 
PR-URL: #40034
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@codebytere @BethGriggs
src: fix -Wunreachable-code-return error
cfcd571 
PR-URL: #40034
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Sep 21, 2021
Merged
1 task
codebytere added a commit to electron/electron that referenced this pull request Sep 23, 2021
@codebytere
fix: -Wunreachable-code-return
9406f8c 
nodejs/node#40034
codebytere added a commit to electron/electron that referenced this pull request Sep 27, 2021
@codebytere
fix: -Wunreachable-code-return
ec35ce9 
nodejs/node#40034
codebytere added a commit to electron/electron that referenced this pull request Sep 27, 2021
@codebytere
fix: -Wunreachable-code-return
dd97861 
nodejs/node#40034
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen left review comments

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@codebytere @nodejs-github-bot @jasnell @addaleax @lpinca @targos @cjihrig @tniessen