ci: tag maintainers for review

[khaneliman]

Description

Checklist

• Change is backwards compatible.

• Code formatted with nix fmt or ./format.

• Code tested through nix-shell --pure tests -A run.all
  or nix build --reference-lock-file flake.lock ./tests#test-all using Flakes.

• Test cases updated/added. See example.

• Commit messages are formatted like

  {component}: {description}
  
  {long description}
  

  See CONTRIBUTING for more information and recent commit messages for examples.

• If this PR adds a new module

  • Added myself as module maintainer. See example.

Maintainer CC

[khaneliman]

@rycee I think our github token needs.

"Pull requests" repository permissions (write)

I don't have access to see the settings on the repo, though.

[rycee]

Is this just for figuring out which path to use while developing the workflow?

[rycee]

Wouldn't it be possible to make jq read the file directly?

Suggested change

	MAINTAINERS=$(jq -r ".[\"$PATH_FORMAT\"] | if . != null then .[].github else empty end" <<< "$MODULE_MAINTAINERS" 2>/dev/null || true)
	MAINTAINERS=$(jq -r ".[\"$PATH_FORMAT\"] | if . != null then .[].github else empty end" ./result 2>/dev/null || true)

[rycee]

Looks nice! About the permissions I'm not certain. From what I could see in the GitHub documentation it should be possible to add a permissions field in the yaml file. Something like

permissions:
  contents: read
  pull-requests: write

perhaps. This seems to be used by the eval flow in Nixpkgs: https://github.com/NixOS/nixpkgs/blob/d66115b18ccf2fbb03da4f2ea8a41499eb8d3136/.github/workflows/eval.yml#L241-L243

[khaneliman]

Looks nice! About the permissions I'm not certain. From what I could see in the GitHub documentation it should be possible to add a permissions field in the yaml file. Something like

permissions:
  contents: read
  pull-requests: write

perhaps. This seems to be used by the eval flow in Nixpkgs: https://github.com/NixOS/nixpkgs/blob/d66115b18ccf2fbb03da4f2ea8a41499eb8d3136/.github/workflows/eval.yml#L241-L243

I'm wondering if this is related to something I've seen previously, github wont let us request reviews from those who aren't collaborators. In nixpkgs, we add everyone to the Nixos organization. We might not be able to do this here, then....

https://github.com/NixOS/nixpkgs/blob/d66115b18ccf2fbb03da4f2ea8a41499eb8d3136/ci/request-reviews/request-reviewers.sh#L61-L69

Tested with this block in there and that seems to be the case

[khaneliman]

Using PR target I need to check this in to really test it. But from a test in my repo with https://github.com/khaneliman/home-manager/actions/runs/16031756101/job/45233835846?pr=567 it appeared to make it down to requesting a review but failed because it was looking against my fork and not this repo.

EDIT: Still have some cleanup I want to do

[khaneliman]

https://github.com/khaneliman/home-manager/actions/runs/16033202876/job/45238595516?pr=568 looks even better. Was able to test simplifying some logic and handling people who have already been reviewing so they dont get re-requested.

[khaneliman]

Would like to test against someone invited to my fork as a collaborate to make sure that flow works to avoid a bunch of fixes PRs.

[khaneliman]

Sweet, got it working khaneliman#568